Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
- Composer 1 doesn't work on PHP 8, so DrupalCI uses Composer 2 to test on PHP 8.
- DrupalCI uses Composer 2.0.3. It's possible that the problem described below is not an issue with Composer 2.0.7.
- It appears that on Composer 2.0.3, the use of relative paths in
ComposerProjectTemplatesTest::makeVendorPackage()
causes an uncaught exception. See the failure for PHP 8 on #3156595-142: Make Drupal 9 installable on PHP8.
Proposed resolution
Write the absolute path rather than the relative path in the test fixture setup.
Comment | File | Size | Author |
---|---|---|---|
#2 | 3156595-4-148.patch | 681 bytes | effulgentsia |
Comments
Comment #2
effulgentsia CreditAttribution: effulgentsia at Acquia commentedUploading the same patch as in #3156595-148: Make Drupal 9 installable on PHP8. I just split this issue out from that one.
Comment #4
effulgentsia CreditAttribution: effulgentsia at Acquia commentedCrediting @alexpott, who figured this out in #3156595-146: Make Drupal 9 installable on PHP8.
Comment #5
effulgentsia CreditAttribution: effulgentsia at Acquia commentedSince @alexpott wrote the patch, I'm eligible to RTBC it, so doing so.
Comment #6
alexpottThis should be backported to 9.1.x - it is test only and helps us to ensure that that branch stays PHP 8 compatible regardless of what we decide for the 9.1 RC.
Comment #9
catchCommitted/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!