Problem/Motivation

Drupal\FunctionalTests\Installer\StandardInstallerTest::curlExec() overrides a method in WebTestBase. This now does nothing as WebTestBase is no longer the test base class since Simpletest was refactored away in #2907728: Installer: Convert system functional tests to phpunit.

Steps to reproduce

Proposed resolution

Remove the method.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3178248.patch1013 byteslongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3178248.patch1013 bytes
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Bug Smash Initiative

Thanks for the issue and patch!

1) Confirmed that curlExec was removed in #2907728: Installer: Convert system functional tests to phpunit.

2) Patch still applies to 9.2.

3) After applying patch, the only reference to curlExec is:

./core/tests/Drupal/KernelTests/AssertContentTrait.php:   * Parse content returned from curlExec using DOM and SimpleXML.

4) Code looks good and addresses issue in summary.

5) Tests pass.

6) No manual testing was done but doesn't seem necessary.

Assuming leaving #3 is okay, then marking this RTBC.

  • catch committed 2202760 on 9.2.x 
    Issue #3178248 by longwave, Kristen Pol: StandardInstallerTest::curlExec...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

#3 might need some tidying up, but I think that's a separate issue from removing this dead code.

Committed 2202760 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.