See #3156609: Cross icon of the 'Configure link' is overlapping on the expanded header on scroll and #3158585: z-index issue when using webform wizard pages

Also see Z-indexes in Drupal 8 documentation

https://www.drupal.org/files/issues/2020-07-03/Cross%20icon%20overlappin...

CommentFileSizeAuthor
#2 3177918.patch6.86 KBmherchel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Version: 9.1.x-dev » 9.2.x-dev
Status: Active » Needs review
FileSize
3177918.patch6.86 KB

Patch attached.

Things to test:

  1. Ensure that flyout header covers everything (check things like contextual links, buttons for layout builder, webform wizard elements, etc)
  2. Do the same as above but for the mobile flyout menu
  3. Ensure that the desktop search covers the same items as #1
  4. Ensure that dropdown menus cover the same as #1, as well as the desktop search

Tugboat preview is at https://3177918-z-index-vhdnwx10smc9jdwzkphc9kdwa0kryrr7.tugboat.qa/

proeung’s picture

proeung
she/her
CreditAttribution: proeung as a volunteer commented
Status: Needs review » Reviewed & tested by the community

The patch looks good and items are showing up as expected according to the testing instructions above.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

It looks like once Olivero and Claro are stable we need to update https://www.drupal.org/docs/theming-drupal/z-indexes-in-drupal-8

Committed and pushed bdf6131d9f to 9.2.x and c2e9bd2fc5 to 9.1.x. Thanks!

Backported to 9.1.x as olivero is experimental.

  • alexpott committed bdf6131 on 9.2.x 
    Issue #3177918 by mherchel: Holistically refactor use of Olivero's z-...

  • alexpott committed c2e9bd2 on 9.1.x 
    Issue #3177918 by mherchel: Holistically refactor use of Olivero's z-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.