From @lauriii in #216 in #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

+++ b/core/themes/olivero/templates/content/node--article--full.html.twig
@@ -0,0 +1,5 @@
+{% include '@olivero/content/node.html.twig' with
Missing @file documentation.
CommentFileSizeAuthor
#11 interdiff_6_11.txt765 bytesKapilV
#11 3176919-11.patch550 bytesKapilV
#6 interdiff_2-6.txt705 byteskomalk
#6 3176919-6.patch541 byteskomalk
#3 3176919-2.patch455 bytesnitesh624
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
CreditAttribution: nitesh624 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » nitesh624

Working on it

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
CreditAttribution: nitesh624 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: nitesh624 » Unassigned
Status: Active » Needs review
FileSize
3176919-2.patch455 bytes

Status: Needs review » Needs work

The last submitted patch, 3: 3176919-2.patch, failed testing. View results

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Title: [Code Review] Missing @file documentation in node.html.twig » Missing @file documentation in Olivero's node.html.twig
Project: Olivero » Drupal core
Version: 8.x-1.x-dev » 9.1.x-dev
Component: Code » Olivero theme
komalk’s picture

komalk CreditAttribution: komalk at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3176919-6.patch541 bytes
interdiff_2-6.txt705 bytes
ranjith_kumar_k_u’s picture

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented

The above patch works fine ,it adds @file documentation in /core/themes/olivero/templates/content/node--article--full.html.twig

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented
Status: Needs review » Reviewed & tested by the community
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work 
+++ b/core/themes/olivero/templates/content/node--article--full.html.twig
@@ -1,3 +1,9 @@
+ * Olivero's theme implementation to display a article type node full.

This has some improper grammar. We should be using "an" instead of "a" and the order is kind of strange.

Maybe "Olivero's theme implementation for an article content type's full view mode."

KapilV’s picture

KapilV CreditAttribution: KapilV as a volunteer and at Innoraft for Drupal Care, Drupal Association commented
Assigned: Unassigned » KapilV
KapilV’s picture

KapilV CreditAttribution: KapilV as a volunteer and at Innoraft for Drupal Care, Drupal Association commented
Assigned: KapilV » Unassigned
Status: Needs work » Needs review
FileSize
3176919-11.patch550 bytes
interdiff_6_11.txt765 bytes

head an updated patch.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Status: Needs review » Reviewed & tested by the community

#11 looks good!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 3176919-11.patch, failed testing. View results

kostyashupenko’s picture

kostyashupenko
Primary language Russian
Location Omsk
CreditAttribution: kostyashupenko commented
Status: Needs work » Reviewed & tested by the community

  • catch committed 0ea2e4d on 9.2.x 
    Issue #3176919 by kapilkumar0324, komalk, nitesh624, mherchel: Missing @...

  • catch committed a2dd35a on 9.1.x 
    Issue #3176919 by kapilkumar0324, komalk, nitesh624, mherchel: Missing @...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.