From @lauriii in #216 in #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

 +++ b/core/themes/olivero/templates/form/fieldset.html.twig
@@ -0,0 +1,81 @@
+ * @file
We should add available variables to the documentation.
CommentFileSizeAuthor
#3 3176908-3.patch1.43 KBkostyashupenko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Title: [Code Review] Add variables to fieldset.html.twig documentation » Add variables to Olivero's fieldset.html.twig documentation
Project: Olivero » Drupal core
Version: 8.x-1.x-dev » 9.1.x-dev
Component: Code » Olivero theme
Priority: Normal » Minor
kostyashupenko’s picture

kostyashupenko
Primary language Russian
Location Omsk
CreditAttribution: kostyashupenko at Skilld commented
Status: Active » Needs review
FileSize
3176908-3.patch1.43 KB
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Status: Needs review » Reviewed & tested by the community

This looks perfect.

Note that I noticed that the title_display and inline_items variables were missing as compared to core's core/modules/system/templates/fieldset.html.twig file. I verified that these variables are not present in our version of this template, so the variables listed appear to be correct.

+1 Thanks!

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented

The above patch works fine , it documents all the variables used the Olivero's fieldset.html.twig file .RTBC +1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 20e0758ae8 to 9.2.x and 5e3f052007 to 9.1.x. Thanks!

  • alexpott committed 20e0758 on 9.2.x 
    Issue #3176908 by kostyashupenko, mherchel: Add variables to Olivero's...

  • alexpott committed 5e3f052 on 9.1.x 
    Issue #3176908 by kostyashupenko, mherchel: Add variables to Olivero's...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.