From @lauriii in #216 in #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

+++ b/core/themes/olivero/olivero.info.yml
@@ -0,0 +1,85 @@
+  content_below: 'Content Below (Flex Layout)'
+  footer_top: 'Footer Top (Flex Layout)'
Is there a less technical term than flex layout? This is displayed in the UI and I could imagine that non-technical users could find this confusing.
CommentFileSizeAuthor
#4 3176901-applied_patch.png17.45 KBAbhijith S
#3 3176901-3.patch535 byteskomalk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Title: [Code Review] Rename "Flex Layout" region description » Rename Olivero's "Flex Layout" region description
Project: Olivero » Drupal core
Version: 8.x-1.x-dev » 9.1.x-dev
Component: Code » Olivero theme
komalk’s picture

komalk CreditAttribution: komalk at Srijan | A Material+ Company for Drupal India Association commented
Status: Active » Needs review
FileSize
3176901-3.patch535 bytes

content_below: 'Content Below (Flex Layout)' keep similar to content_above: Content Above

Abhijith S’s picture

Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commented
FileSize
3176901-applied_patch.png17.45 KB

Applied patch #3 and it works fine .The flex layout is removed from those two regions, which seems standard when comparing other themes.

after

Abhijith S’s picture

Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commented
Status: Needs review » Reviewed & tested by the community
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Issue tags: +Needs subsystem maintainer review
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Issue tags: -Needs subsystem maintainer review

This looks good to me!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 06820af334 to 9.2.x and 847122a058 to 9.1.x. Thanks!

  • alexpott committed 06820af on 9.2.x 
    Issue #3176901 by komalk, Abhijith S, mherchel: Rename Olivero's "Flex...

  • alexpott committed 847122a on 9.1.x 
    Issue #3176901 by komalk, Abhijith S, mherchel: Rename Olivero's "Flex...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.