Problem/Motivation

In core/modules/views/tests/src/Functional/Plugin/FilterTest.php, $view variable never used.

CommentFileSizeAuthor
#2 remove-unused-variable-3175665-2.patch716 bytesshetpooja04
#2 views.png522.28 KBshetpooja04
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shetpooja04 created an issue. See original summary.

shetpooja04’s picture

shetpooja04 CreditAttribution: shetpooja04 at QED42 commented
Assigned: shetpooja04 » Unassigned
Status: Active » Needs review
FileSize
views.png522.28 KB
remove-unused-variable-3175665-2.patch716 bytes

Commit ID: 1f0a6298

Link: https://git.drupalcode.org/project/drupal/-/commit/1f0a629875ae4f1b63ca218573145b3a5491081b

File: core/modules/views/src/Tests/Plugin/FilterTest.php Line: 151

For Issue: https://www.drupal.org/project/drupal/issues/2651328 the variable never used

Please review

jijojoseph_zyxware’s picture

jijojoseph_zyxware CreditAttribution: jijojoseph_zyxware as a volunteer and at Zyxware Technologies commented
Status: Needs review » Reviewed & tested by the community

I have reviewed the Patch #2. $view is never getting used. It is working fine without this variable.
Patch Applied cleanly.

@shetpooja04 Thanks for your patch.

RTBC!!!!!

  • catch committed 8c63aba on 9.1.x 
    Issue #3175665 by shetpooja04, jijojoseph_zyxware: Remove unused $view...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 8c63aba and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.