Problem/Motivation

symfony/phpunit-bridge to 5.1.4 provides an upstream fix for #3162403: Upgrade symfony/phpunit-bridge to 5.1.6 to fix badly formed deprecation error message, so it should be updated once it's out.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3168107-13.patch8.96 KBjungle
#10 interdiff-5-10.txt1.64 KBjungle
#10 3168107-10.patch3.6 KBjungle
#5 3168107-5.patch2.46 KBjungle
#3 3168107-3.patch6.54 KBmondrake
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Postponed » Active

Symfony 5.1.4 is out

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Active » Needs review
FileSize
3168107-3.patch6.54 KB

Tried following instructions from https://www.drupal.org/node/3089540 from a git clone, but not sure I got it right.

Status: Needs review » Needs work

The last submitted patch, 3: 3168107-3.patch, failed testing. View results

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs work » Needs review
FileSize
3168107-5.patch2.46 KB

Changes to files other than the following 2 files are unnecessary.

  1. composer.lock
  2. composer/Metapackage/PinnedDevDependencies/composer.json

Attaching a new patch without interdiff.

$ composer-lock-diff --no-links
+------------------------+--------+--------+
| Dev Changes            | From   | To     |
+------------------------+--------+--------+
| symfony/phpunit-bridge | v5.1.3 | v5.1.4 |
+------------------------+--------+--------+

Command used: COMPOSER_ROOT_VERSION=9.1.x-dev composer update symfony/phpunit-bridge -vvv

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Needs work

Thanks @jungle! Really do not understand what was wrong with #3 - maybe I git cloned and composer installed rather than run a composer project command?

IMO the problem with #5 is that it updates but does not raise the minimum version in composer.json. We need to set ^5.1.4 as minimum to ensure we do not have earlier versions that have the bug from #3162403: Upgrade symfony/phpunit-bridge to 5.1.6 to fix badly formed deprecation error message.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs work » Needs review

Re #6 I do not think we have to update ^5.1.3 in composer.json to ^5.1.4. We do not want to touch the composer.json file when possible so that we use ^ in composer.json .

See #3134731: Update coder to 8.3.9 as an example -- while updating coder to 8.3.9, composer.json did not get touched.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented

#7 OTOH, #3157434: Deprecate \Drupal\Tests\Traits\ExpectDeprecationTrait in favour of \Symfony\Bridge\PhpUnit\ExpectDeprecationTrait did exactly that - it updated to 5.1.3 and increased the composer.json constraint to ^5.1.3.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#3157296: Upgrade dependencies prior to 9.1.0

There's more needs update

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
FileSize
3168107-10.patch3.6 KB
interdiff-5-10.txt1.64 KB

Re #8, well, this one is what you wanted.

Steps:

  1. Changed the constraint in composer.json from ^5.1.3 to ^5.1.4.
  2. Run COMPOSER_ROOT_VERSION=9.1.x-dev composer update symfony/phpunit-bridge -vvv
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

Thanks @jungle. This patch updates symfony/phpunit-bridge to latest version, that is meant to fix an issue on how deprecations are reported by PHPUnit currently.

See an example of current problem in #3166543-15: Deprecate UiHelperTrait::drupalPostForm, keep deprecation silenced, test run report https://www.drupal.org/pift-ci-job/1807297.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Title: Bump symfony/phpunit-bridge to 5.1.4 » Bump composer.json symfony/phpunit-bridge constraint to ^5.1.4
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
3168107-13.patch8.96 KB

Rerolled.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thanks a lot!

  • catch committed c5a0d92 on 9.1.x 
    Issue #3168107 by jungle, mondrake: Bump composer.json symfony/phpunit-...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed c5a0d92 and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +9.1.0 release notes