Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Plugin%21...
PluginWithFormsInterface should tell you to use PluginWithFormsTrait.
PluginWithFormsTrait should tell you that it's there to help with implementing PluginWithFormsInterface.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3165065-patch-applied.png | 13.47 KB | Abhijith S |
| #3 | PluginWithFormsTrait-3165065-3.patch | 831 bytes | sarvjeetsingh |
Comments
Comment #2
sarvjeetsingh CreditAttribution: sarvjeetsingh as a volunteer and at QED42 for Drupal India Association commentedComment #3
sarvjeetsingh CreditAttribution: sarvjeetsingh as a volunteer and at QED42 for Drupal India Association commentedI have provided information about PluginWithFormsInterface.php methods in PluginWithFormsTrait.php.
I have gone through several core interfaces and traits and I think we don't need to provide the information about the trait in PluginWithFormsInterface.php.
Please review.
Thanks.
Comment #5
Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commentedI've applied patch #3 and its works fine.The information added to PluginWithFormsTrait is provided correctly. As @sarvjeetsingh said Interfaces generally doesn't tends to add information about.So no need for it
Comment #6
Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commentedComment #8
catchCommitted/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!