Problem/Motivation

As pre-requisite of #2795567: Use Symfony's VarDumper for easier test debugging with dump()

Repository: https://github.com/symfony/var-dumper
Release cycle:
Security policies:
Security issue reporting:
Contact(s) :

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

symfony/var-dumper is now a top-level development dependency and has been upgraded from 4.4 to 5.1.7. (Note that an older version of the dependency was previously installed indirectly as a requirement for symfony/error-handler.

CommentFileSizeAuthor
#4 interdiff-3-4.txt594 bytesjungle
#4 3164349-4.patch5.7 KBjungle
#3 3164349-3.patch5.69 KBjungle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Title: Add symfony/var-dumper as a dev dependency » Add symfony/var-dumper as a top-level dev dependency 
$ composer why symfony/var-dumper
symfony/error-handler  v4.4.10  requires  symfony/var-dumper (^4.4|^5.0)  
$ composer why symfony/error-handler
drupal/drupal        9.1.x-dev  requires (for development)  symfony/error-handler (^4.4)  
symfony/http-kernel  v4.4.10    requires                    symfony/error-handler (^4.4)

symfony/var-dumper is in core already, should we add it as a top-level dev dependency?

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Active » Needs review
FileSize
3164349-3.patch5.69 KB 
  1. $ composer-lock-diff
[No output]

  2. +++ b/composer/Plugin/VendorHardening/Config.php
@@ -81,6 +81,7 @@ class Config {
+    'symfony/var-dumper' => [],

    Nothing to remove, but added an empty array here. No sure if this is necessary.

  3. $ COMPOSER_ROOT_VERSION=9.1.x-dev composer update --lock -vvv Used.
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
FileSize
3164349-4.patch5.7 KB
interdiff-3-4.txt594 bytes

+ 'symfony/var-dumper' => [],

Nothing to remove, but added an empty array here. No sure if this is necessary.

The Tests could be removed, see https://github.com/symfony/var-dumper/tree/v5.1.2/Tests

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Reviewed & tested by the community

OK, this formalizes a dependency that is already loaded as a sub-dependency.

  • catch committed b7f992c on 9.1.x 
    Issue #3164349 by jungle, mondrake: Add symfony/var-dumper as a top-...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

This is already a dependency, so we don't need a separate evaluation here.

Committed b7f992c and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +9.1.0 release notes
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue summary: View changes

Adding the release note.