Needs work
Project:
Drupal core
Version:
main
Component:
dblog.module
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
6 Aug 2020 at 09:56 UTC
Updated:
20 May 2025 at 12:37 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
idebr commentedAccording to #2015149: Replace dblog recent log entries with a view comment #142 this is by design:
Comment #3
dagmarI think @longwave refers when you are viewing a particular event page page, not the listing page. I think this is a valid feature request.
Comment #4
longwaveYeah, I often find when I'm using dblog to figure out an issue that I start from the listing page and then end up opening numerous tabs and lose track of which order the events happened in. I realised that basically I just want to jump in sequence from one log entry to the next usually, so a Next button would be really helpful.
Comment #11
vinaygawadeWorking on this Feature request.
Comment #13
vinaygawadeHi,
I've submitted a merge request for review that implements navigation between database log event pages using "Next" and "Previous" buttons.
Please review and share any feedback. Thanks!
Comment #14
smustgrave commentedWill need UX sign off, but the issue summary seems to be void of screenshots to assist the UX team. Tagging for such
Thanks!
Comment #15
vinaygawadeThanks for the update!
I've added some screenshots showing the new navigation links added to the DB log detail page:
- Example of the “Next” and “Previous” links at the bottom of a log entry.
- Behavior at the first and last entry to show correct disabling/hiding of links.
Let me know if further clarification is needed.
Comment #16
dagmar@vinaygawade Thanks. Looks really good. I think the symbols next to
Next >and< Prevwill have to live outside the text buttons, so we can reuse translations.I also checked if would be possible to have only one query instead of 2. But it requires the use of UNION, and there is no real gain there.
Finally would be good to have a test when there is only one entry in the logs. To verify no buttons and no errors are rendered.
Comment #17
vinaygawadeThank you @dagmar,
- Good point about the arrow symbols — I’ve removed them for simplicity, so the translatable strings can be reused.
- I agree on the single-query idea — not worth the added complexity for minimal gain.
- I also tested the case with only one log entry. On the event details page, no Previous or Next buttons are rendered, and everything works without errors.
Let me know if you have any other feedback!
Comment #18
vinaygawadeAdded prev/next ID handling in overview() to avoid extra DB queries in eventDetails(). Uses query params for faster navigation between log entries.
Comment #19
vinaygawadeComment #20
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #21
vinaygawadeComment #22
vinaygawadeAdded updated screenshots for review.
Comment #23
dagmarIt seems one test is not passing now.
Comment #24
rkollerUsability review
We discussed this issue at #3523597: Drupal Usability Meeting 2025-05-16. That issue will have a link to a recording of the meeting.
For the record, the attendees at the usability meeting were benjifisher, rkoller, shaal, simohell, and worldlinemine.
We have based todays discussion on MR12089, in the following a list of details we’ve noticed:
PreviousandNextare styled as buttons, but they are actually links.PreviousandNextare missing some sort of context.PreviousorNextbutton repeatedly, you will notice that the column with the row labels is sort of uneasy and shifting constantly in width in between log messages - on some page the column gets even that narrow that the label wraps to a second line. From a readability point of view, you don’t have a fixed starting point for your eyes, you have to adjust on every page, which leads to an increased cognitive load if you are clicking through several error messages in a row (see column_width.mp4).PreviousandNextbutton are not respecting the applied filters. If you filter your log messages for example for a particular error message, and then click on one of the filter results, the filter scope is being reset - pressingPreviousorNexton the details page will not bring you to the next/previous log message of your filter results, but to the next log message overall.Aside the aforementioned points we’ve also asked ourselves if there is already a pattern in Core using such a
PreviousandNextpattern to step through instances - but we were unable to come up with one - there is only the remotely related Pager pattern used on Views (for example on/admin/content). In conclusion, these are the points the group reached a consensus on to suggest in scope for this issue:Previous log message&Next log messageas the label for the action links.PreviousandNextaction links respect a set filter value. If you are for example filtering for the type “php” with a severity of “error” and you get four matches, log message number 25, 126, 134, 175, and you click on the detail view for number 126, the behavior on the detail page should be as follows:Clear filterNext, forwards you to log message number 134Previoustwice, forwards you to log message number 25Clear filterbutton, the button would get hidden, and in this case the previous button would get shown again (since in the scope of the filter results 25 is the first available message andPreviousbutton hidden) - clicking thePreviousbutton would forward you to log message number 24, clicking theNextbutton to log message 26, instead of going through the four available numbers of filter results.Clear filterbutton it should be self explanatory that the current scope of displayed log messages are filter matches, while when theClear filterbutton is not shown the scope is all the existing log messages. But ideally that could be validated in user tests, perhaps additional (visual) cues might be necessary.In regard to the problem with the shifting column width, we’ve thought that is not “directly” related to this issue and should probably be moved to a followup issue instead.
If you want more feedback from the usability team, a good way to reach out is in the #ux channel in Slack.
Comment #25
dagmarCreated the follow up for https://www.drupal.org/project/drupal/issues/3525492
Good point. This will be interesting to implement. Not sure if this will also require extract the logic of filtering from the dblog controller so we can reuse the logic in both the dblog details and the listing.
Also, I'm thinking this will create some caching issues to consider as well.