Incorrect Drupal\Composer\VendorHardening namespace is used instead of Drupal\Composer\Plugin\VendorHardening

#3088730: Include 'composer' directory in phpcs scans as related but this error I don't think is caught by phpcs. I tested with another file in core.

Here is a fix.

So how does this test even work? Shouldn't it error out? Maybe I'm missing something.

Interesting I would have thought it would error out too. It is not because.

1. It seems that you can add "::class" to anything and it will return back a namespace string.

   If you add to the test:
   use Drupal\IamNotReal;
   and then later
   print "class=" . IamNotReal::class;

   It will print
   "class=Drupal\IamNotReal"

   If you don't add the use statement it would print out
   "class=Drupal\Tests\Composer\Plugin\VendorHardening\IamNotReal"
   which just uses the namespace of the current class.

   but in either case if you actually try
   new IamNotReal(); it will error
   Error : Class 'Drupal\Tests\Composer\Plugin\VendorHardening\IamNotReal' not found or the other namespace.

   I guess this because using ::class doesn't actually check the class exists.

2. Apparently you can pass any string to \PHPUnit\Framework\TestCase::getMockBuilder() until it actually has to check something like if the original class or interface has a constructor or method.

   I tried changing
   \Drupal\Tests\rest\Unit\Plugin\views\style\SerializerTest

   I changed

   -$this->view = $this->getMockBuilder(ViewExecutable::class)
   +    $this->view = $this->getMockBuilder('pancake')

   This worked fine because it the original code is

   $this->view = $this->getMockBuilder('pancake')
         ->disableOriginalConstructor()
         ->getMock();

   So it doesn't do anything with the mock except disableOriginalConstructor()

   In the same class if I try the same with

   $this->displayHandler = $this->getMockBuilder(RestExport::class)
         ->disableOriginalConstructor()
         ->getMock();
   
       $this->displayHandler->expects($this->any())
         ->method('getContentType')
         ->willReturn('json');
   

   It will fail because there is no getContentType() method.

   In our test there is

   $config = $this->getMockBuilder(Config::class)
         ->setMethods(['getPathsForPackage'])
         ->disableOriginalConstructor()
         ->getMock();
       $config->expects($this->once())
         ->method('getPathsForPackage')
         ->willReturn(['tests']);

   getPathsForPackage doesn't exist but setMethods() sets it so it doesn't fail. Commenting out
   ->setMethods(['getPathsForPackage']) make it fail.

   If you fix the class namespace in the use statement you don't need setMethods().

We could fix this in this issue but it seems like a bigger problem with this test.

Anyways I have included it.