Filter button in User interface translation form has more whitespace than it needs [#3159892]

Problem/Motivation

Enable locale, head to admin/config/regional/translate, and notice that the filter button has more distance between it and other elements than seems necessary.

This may impact other forms, this is just where I happened to notice it.

Proposed resolution

Get agreement that this should be changed
If there is agreement to change, determine the change that should be made
Determine if this impacts other forms
Impement, check for side effects in other forms

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#21	3159892-21.patch	495 bytes	Gauravvvv
#21	10.1.x: PHP 8.1 & MySQL 5.7 29,035 pass
#11	3159892-11.patch	501 bytes	phenaproxima
#11	9.3.x: PHP 8.0 & MySQL 5.7 28,835 pass, 1 fail 10.1.x: PHP 8.1 & MySQL 5.7 Patch Failed to Apply
#11	3159892-11-after.png	41.55 KB	phenaproxima
#8	After-patch.png	120.47 KB	Sakthivel M
#8	before-patch.png	102.13 KB	Sakthivel M
#6	3159892-applied_patch.png	17.81 KB	Abhijith S
#6	3159892-before.png	18.15 KB	Abhijith S
#4	selected_9645.png	102.46 KB	KondratievaS
#3	3159892-3.patch	2 KB	kostyashupenko
#3	9.1.x: PHP 7.4 & MySQL 5.7 28,037 pass, 1 fail 9.2.x: PHP 7.3 & MySQL 5.7 28,103 pass
	Screen Shot 2020-07-17 at 11.03.23 AM.png	41.42 KB	bnjmnm

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

17 July 2020 at 15:10

bnjmnm created an issue. See original summary.

Comment #2

mayurjadhav CreditAttribution: mayurjadhav at Srijan | A Material+ Company commented 29 July 2020 at 10:51

Hi @bnjmnm
Yes we need to change this, Extra padding is added to the filter form action button on Locale translate filter form.
This is completely independent and removing padding will not make any impact on any other forms or action buttons.

.locale-translate-filter-form .form-actions {
    float: left;
    padding: 3.8ex 0 0 0;
}

Patch is ready with me, once we get the confirmation i'll update here.

Thanks.

Comment #3

kostyashupenko

Russian

Omsk

CreditAttribution: kostyashupenko at Skilld commented 5 August 2020 at 07:03

Status:

Active

» Needs review

File	Size
3159892-3.patch	2 KB
9.1.x: PHP 7.4 & MySQL 5.7 28,037 pass, 1 fail 9.2.x: PHP 7.3 & MySQL 5.7 28,103 pass

File

Size

3159892-3.patch

2 KB

9.1.x:
PHP 7.4 & MySQL 5.7 28,037 pass, 1 fail

9.2.x:
PHP 7.3 & MySQL 5.7 28,103 pass

Not sure, maybe best way here to not just extend original library, but carefully rewrite it from scratch (from Claro only)?

Comment #4

KondratievaS CreditAttribution: KondratievaS at Skilld commented 5 August 2020 at 14:00

File	Size
selected_9645.png	102.46 KB

Tested patch from #3 for mobile and desktop resolutions in Chrome, FF, Safari and IE browsers. Result is OK

Comment #5

5 August 2020 at 14:00

Version:

9.1.x-dev

» 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Comment #6

Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commented 4 February 2021 at 13:56

File	Size
3159892-before.png	18.15 KB
3159892-applied_patch.png	17.81 KB

Applied the patch #3 on 9.2.x and it works fine.The whitespace is reduced after this patch.Adding screenshots below.

Before patch;
before

After patch:
after

Comment #7

4 February 2021 at 13:56

Version:

9.2.x-dev

» 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #8

Sakthivel M CreditAttribution: Sakthivel M at QED42 for Drupal India Association commented 11 June 2021 at 07:35

File	Size
before-patch.png	102.13 KB
After-patch.png	120.47 KB

Applied the patch #3 on 9.3.x and it works fine.The whitespace is reduced after this patch. Adding screenshots below.

Moved to RTBC

Comment #9

Sakthivel M CreditAttribution: Sakthivel M at QED42 for Drupal India Association commented 11 June 2021 at 07:35

Status:

Needs review

» Reviewed & tested by the community

Comment #10

lauriii

he/him

Finnish

Finland

CreditAttribution: lauriii as a volunteer commented 29 June 2021 at 15:16

Status:

Reviewed & tested by the community

» Needs work

Did you try if unloading core/modules/locale/css/locale.admin.css would solve this? I checked the CSS and it seems like at least most of it isn't needed in Claro.

Comment #11

phenaproxima

he/him

English

Massachusetts

CreditAttribution: phenaproxima at Acquia commented 29 June 2021 at 15:34

Status:

Needs work

» Needs review

File	Size
3159892-11-after.png	41.55 KB
3159892-11.patch	501 bytes
9.3.x: PHP 8.0 & MySQL 5.7 28,835 pass, 1 fail 10.1.x: PHP 8.1 & MySQL 5.7 Patch Failed to Apply

File

Size

3159892-11-after.png

41.55 KB

3159892-11.patch

501 bytes

9.3.x:
PHP 8.0 & MySQL 5.7 28,835 pass, 1 fail

10.1.x:
PHP 8.1 & MySQL 5.7 Patch Failed to Apply

I tried @lauriii's suggestion of removing locale.admin.css in Claro, and it had the desired effect:

"After" screenshot, with spacing corrected

Attaching a patch which takes this approach.

Comment #12

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett at Acquia commented 29 June 2021 at 15:46

Status:

Needs review

» Reviewed & tested by the community

Good suggestion @lauriii, indeed the core locale.admin.css has a lot of unnecessary code, and I don't see any visual regressions after unloading it, only the desired improvements.

Comment #13

lauriii

he/him

Finnish

Finland

CreditAttribution: lauriii as a volunteer commented 30 June 2021 at 07:29

Status:

Reviewed & tested by the community

» Needs work

It seems like the patch from #11 failed CI.

Comment #14

phenaproxima

he/him

English

Massachusetts

CreditAttribution: phenaproxima at Acquia commented 30 June 2021 at 12:39

Status:

Needs work

» Reviewed & tested by the community

Looks like it's passed now...?

Comment #15

4 July 2021 at 14:25

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 11: 3159892-11.patch, failed testing. View results

Comment #16

bnjmnm

he/him

English

Ann Arbor, MI

CreditAttribution: bnjmnm at Acquia commented 6 July 2021 at 11:30

Status:

Needs work

» Reviewed & tested by the community

Another unrelated test failure switched this out of RTBC. Switching back

Comment #17

14 August 2021 at 13:55

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 11: 3159892-11.patch, failed testing. View results

Comment #18

14 August 2021 at 13:55

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #19

14 August 2021 at 13:55

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #20

14 August 2021 at 13:55

Version:

9.5.x-dev

» 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #21

Gauravvvv CreditAttribution: Gauravvvv at Axelerant for Drupal India Association commented 20 March 2023 at 03:59

Status:

Needs work

» Needs review

File	Size
3159892-21.patch	495 bytes
10.1.x: PHP 8.1 & MySQL 5.7 29,035 pass

Re-rolled Patch #11, as it's no longer applies to 10.1.x.

Comment #22

ameymudras CreditAttribution: ameymudras at Salsa Digital commented 20 March 2023 at 13:35

Status:

Needs review

» Reviewed & tested by the community

Ive tested the patch on 10.1.x and following are my findings

1. The Issues summary is clear and explains the problem
2. Was able to replicate the problem
3. The patch applies cleanly
4. The patch fixes the issue and eliminates the extra space.
5. Did a code review and its a simple change to offload the locale.admin.css css as per #10

Moving the issue to RTBC, skipping before / after screenshots, since a few have been already provided

Comment #23

lauriii

he/him

Finnish

Finland

CreditAttribution: lauriii as a volunteer commented 21 March 2023 at 08:48

Status:

Reviewed & tested by the community

» Needs work

I am not sure we should actually get rid of this CSS file completely. The file seems to contain several UX enhancements to the translation related UIs. They may seem minor but I assume some thought has been put behind them.

Comment #24

21 March 2023 at 08:48

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.