Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Similar to #3134475: Avoid directly comparing string to blob in CommentIntegrationTest, not all databases are able to use blobs in where clauses. This test can be changed exactly the same manner as the previous issue to make it more universal.
Comment | File | Size | Author |
---|---|---|---|
#6 | interdiff-4-6.txt | 686 bytes | jungle |
#6 | 3159739-6.patch | 1.2 KB | jungle |
Comments
Comment #2
BeakerboyPatch for this issue
Comment #3
daffie CreditAttribution: daffie commentedThe change looks good to me.
It is the same solution as the one for #3134475: Avoid directly comparing string to blob in CommentIntegrationTest.
For me it is RTBC.
Comment #4
jungleOne nitpick:
assertEqual($actual, $expected)
->assertEquals($expected, $actual)
, the order of$actual
and$expected
should be swapped as well.$this->assertEquals(serialize($arguments), $variables)
;Addressing and stay RTBC.
Comment #5
alexpottIf we're making this change then we should unserialise $variables. It makes it easier to see what is different. If this breaks.
Comment #6
jungleGood point. @alexpott thanks for the review.
Comment #7
daffie CreditAttribution: daffie commentedThe point of @alexpott has been addressed.
Back to RTBC.
Comment #8
alexpottCommitted and pushed 9346c2ff9b to 9.1.x and 32aaf3ebc9 to 9.0.x and 84bd359419 to 8.9.x. Thanks!
Backported to 8.9.x to keep tests aligned.