There are some unused variables present in the Views UI module i.e. the variables are initialized but never used and we should fix it. Below is the list for the same:

core/modules/views_ui/tests/src/Functional/OverrideDisplaysTest.php
196 | WARNING | Unused variable $new_block_title.

CommentFileSizeAuthor
#9 3157933-9.patch834 bytesS_Bhandari
#3 3157933-3.patch1.5 KBS_Bhandari
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

S_Bhandari created an issue. See original summary.

S_Bhandari’s picture

S_Bhandari CreditAttribution: S_Bhandari at Srijan | A Material+ Company for Drupal India Association commented
Issue summary: View changes
S_Bhandari’s picture

S_Bhandari CreditAttribution: S_Bhandari at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3157933-3.patch1.5 KB

Added a patch for the same.

shaktik’s picture

shaktik
he/him
Primary language Hindi
Location New Delhi
CreditAttribution: shaktik as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Issue tags: +Novice

tagged to Novice.

S_Bhandari’s picture

S_Bhandari CreditAttribution: S_Bhandari at Srijan | A Material+ Company for Drupal India Association commented
Assigned: S_Bhandari » Unassigned
Status: Needs work » Needs review
joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
CreditAttribution: joshua1234511 as a volunteer and at SJ Innovation LLC commented

Reviewed the Patch #3
https://www.drupal.org/files/issues/2020-07-09/3157933-3.patch
Php 7.4 and Drupal core 9.1 3157933-3.patch

Works for me, No issue on the working.

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs review » Needs work 
+++ b/core/modules/views_ui/src/Controller/ViewsUIController.php
@@ -120,7 +120,7 @@ public function reportPlugins() {
-      foreach ($row['views'] as $row_name => $view) {

There is no need to remove the key $row_name in looping.

S_Bhandari’s picture

S_Bhandari CreditAttribution: S_Bhandari at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » S_Bhandari
Issue summary: View changes

Working on it.

S_Bhandari’s picture

S_Bhandari CreditAttribution: S_Bhandari at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3157933-9.patch834 bytes

Added a patch for the same.

S_Bhandari’s picture

S_Bhandari CreditAttribution: S_Bhandari at Srijan | A Material+ Company for Drupal India Association commented
Assigned: S_Bhandari » Unassigned
Status: Needs work » Needs review
joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Reviewed & tested by the community

LGTM.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

This has been an unused variable since all the way back to views 7.x-3.x. It was brought into core unused. It looks like a c&p from other test methods in the same class.

This fix is fine I think.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 4e50d880e9 to 9.1.x and 537d8fae34 to 9.0.x and c98772f42a to 8.9.x. Thanks!

  • alexpott committed 4e50d88 on 9.1.x 
    Issue #3157933 by S_Bhandari: Remove Unused variables from Views UI...

  • alexpott committed 537d8fa on 9.0.x 
    Issue #3157933 by S_Bhandari: Remove Unused variables from Views UI...

  • alexpott committed c98772f on 8.9.x 
    Issue #3157933 by S_Bhandari: Remove Unused variables from Views UI...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.