Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
In #2999549: Allow button tag in LinkGenerator for better accessibility support for semantically-correct buttons was added to LinkGenerator for better accessibility, but this is not yet documented/described in the LinkWidget's help text.
Related: https://www.drupal.org/node/3053689
Proposed resolution
Add help text indicating that button is an option as a keyboard-accessible version of nolink.
User interface changes
Adds information about route: to help text (description) of fields using LinkWidget (e.g. Menu links).
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3153394-after.png | 115.07 KB | joegraduate |
| #5 | 3153394-before.png | 112.7 KB | joegraduate |
| #2 | 3153394-2.patch | 2.5 KB | azslay |
Comments
Comment #2
azslay CreditAttribution: azslay as a volunteer commentedPatch that adds help text to the menu link field, indicating that button is a keyboard accessible option.
Comment #3
azslay CreditAttribution: azslay as a volunteer commentedComment #4
joegraduatePatch in #2 looks good to me. Having the button feature/functionality better documented for menu links (and more discoverable for site builders and content editors) would be a great improvement IMHO.
Comment #5
joegraduateComment #6
joegraduateComment #7
joegraduateComment #8
joegraduateComment #9
Shoshana Mayden CreditAttribution: Shoshana Mayden commentedThis looks good to me. Was able to install the patch and see the same help text as the screen shot. The help text is useful for creating a keyboard-accessible version of nolink.
Comment #10
hedrickbt CreditAttribution: hedrickbt as a volunteer commentedI was able to apply the patch cleanly and see the changes indicated by the screenshots. I also verified I could create a route: menu item and see a button with "hover help" by adding the menu to a block in the footer.
Moving the ticket to Reviewed & tested by the community.
Comment #11
hedrickbt CreditAttribution: hedrickbt as a volunteer commentedComment #13
catchCommitted 6752b8d and pushed to 9.1.x. Thanks!
Comment #14
joegraduateAny chance this could also get committed to 9.0.x and 8.9.x since it's really just a documentation change? The actual change to LinkGenerator that this change documents was made in 8.8.x.
Comment #15
catchIt's a string change, which we don't normally backport to patch releases unless the string is actively misleading - since doing so breaks translations until they're updated.