Problem/Motivation

Part of #3012523: Convert the update.inc file functions to a class

The update_check_incompatibility() function is not used in core
The only usage in contrib is drush 6 http://grep.xnddx.ru/search?text=update_check_incompatibility

Proposed resolution

Deprecate function without replacement, the alternative implementation is \Drupal\Core\Extension\ExtensionList::checkIncompatibility() per each extension type

Remaining tasks

- deprecate
- review/commit

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3150726-4.patch2.04 KBandypost
#4 interdiff.txt614 bytesandypost
#3 3150726-3.patch1.98 KBandypost
#2 3150726-2.patch1.28 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Active » Needs review
FileSize
3150726-2.patch1.28 KB

Patch to see that no usage exists

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
3150726-3.patch1.98 KB

Filed CR and here deprecation with test

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue summary: View changes
FileSize
interdiff.txt614 bytes
3150726-4.patch2.04 KB

CR should be updated with reference to \Drupal\Core\Extension\ExtensionList::checkIncompatibility() as extensions lists encapsulated this check

The last submitted patch, 2: 3150726-2.patch, failed testing. View results

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
CreditAttribution: naresh_bavaskar as a volunteer and at QED42 for Drupal India Association commented

+1 RTBC,
yeah update_check_incompatibility() is not used anywhere in Drupal core.

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
CreditAttribution: naresh_bavaskar as a volunteer and at QED42 for Drupal India Association commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed
Related issues: +#2917600: update_fix_compatibility() puts sites into unrecoverable state

The last usage in core was removed in #2917600: update_fix_compatibility() puts sites into unrecoverable state. That issue just missed out on deprecating this method.

Committed 0334414 and pushed to 9.1.x. Thanks!

  • alexpott committed 0334414 on 9.1.x 
    Issue #3150726 by andypost: Deprecate update_check_incompatibility as...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.