Problem/Motivation

\PHPUnit\Framework\TestCase::expectExceptionMessageRegExp is deprecated. We need to use \PHPUnit\Framework\TestCase::expectExceptionMessageMatches instead.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3143235-4.patch1.55 KBalexpott
#3 3143235-3.patch2.12 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Related issues: +#3142267: Allow the full list of deprecations from PHPUnit8Warning to respect the --suppress-deprecations behavior on DrupalCI
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Active » Needs review
FileSize
3143235-3.patch2.12 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
FileSize
3143235-4.patch1.55 KB

So #3 proves we've fixed them all. But we should commit the patch attached here so we don't clash with #3142267: Allow the full list of deprecations from PHPUnit8Warning to respect the --suppress-deprecations behavior on DrupalCI and that patch can get on with triggering deprecations to make upgrading from Drupal 8 to Drupal 9 easier.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Reviewed & tested by the community

LGTM. Note: I think this can not be backported to D8 without a fc shim for PHPUnit 6.

  • catch committed eba9a18 on 9.1.x 
    Issue #3143235 by alexpott, mondrake: Convert ::...

  • catch committed 503ce08 on 9.0.x 
    Issue #3143235 by alexpott, mondrake: Convert ::...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.1.x-dev » 9.0.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.1.x and cherry-picked to 9.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.