Problem/Motivation

OptimizedPhpArrayDumper doesn't define the alias property it uses for local storage and caching of container aliases.
Additionally, it builds the list of aliases twice instead of using that cache during array building.

Proposed resolution

Define the property and optimize the array build.

Remaining tasks

Review patch.

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Release notes snippet

n/a

CommentFileSizeAuthor
#2 3143085-2.patch1.07 KBneclimdul
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neclimdul created an issue. See original summary.

neclimdul’s picture

Status: Active » Needs review
FileSize
1.07 KB

patch

amateescu’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me :)

alexpott’s picture

Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 075cd95226 to 9.1.x and 1467e54db4 to 9.0.x and a6faaa96ae to 8.9.x. Thanks!

Looks like a simple enough patch to apply back to 8.9.x. (famous last words).

  • alexpott committed 075cd95 on 9.1.x
    Issue #3143085 by neclimdul: Define and optimize alias definition in...

  • alexpott committed 1467e54 on 9.0.x
    Issue #3143085 by neclimdul: Define and optimize alias definition in...

  • alexpott committed a6faaa9 on 8.9.x
    Issue #3143085 by neclimdul: Define and optimize alias definition in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.