Replace usages of deprecated AssertLegacyTrait::assert(No)FieldChecked()

Thanks.

1. +++ b/core/modules/views_ui/tests/src/Functional/DisplayAttachmentTest.php
   @@ -39,7 +38,7 @@ public function testAttachmentUI() {
        foreach (['default', 'page-1'] as $display_id) {
   -      $this->assertNoFieldChecked("edit-displays-$display_id", new FormattableMarkup('Make sure the @display_id can be marked as attached', ['@display_id' => $display_id]));
   +      $this->assertSession()->checkboxNotChecked("edit-displays-$display_id");
        }
   

   It seems overkill to have this in a foreach loop. Better two straight individual calls?

2. +++ b/core/tests/Drupal/FunctionalTests/BrowserTestBaseTest.php
   @@ -582,101 +582,15 @@ public function testFieldAssertsForButton() {
      /**
       * Tests legacy field asserts for checkbox field type.
   +   *
   +   * @group legacy
   +   * @expectedDeprecation AssertLegacyTrait::assertFieldChecked() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->checkboxChecked() instead. See https://www.drupal.org/node/3129738
   +   * @expectedDeprecation AssertLegacyTrait::assertNoFieldChecked() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->checkboxNotChecked() instead. See https://www.drupal.org/node/3129738
       */
      public function testFieldAssertsForCheckbox() {
        $this->drupalGet('test-field-xpath');
   -
   -    // Part 1 - Test by name.
   -    // Test that checkboxes are found/not found correctly by name, when using
   -    // TRUE or FALSE to match their 'checked' state.
   -    $this->assertFieldByName('checkbox_enabled', TRUE);
   -    $this->assertFieldByName('checkbox_disabled', FALSE);
   -    $this->assertNoFieldByName('checkbox_enabled', FALSE);
   -    $this->assertNoFieldByName('checkbox_disabled', TRUE);
   -
   -    // Test that checkboxes are found by name when using NULL to ignore the
   -    // 'checked' state.
   -    $this->assertFieldByName('checkbox_enabled', NULL);
   -    $this->assertFieldByName('checkbox_disabled', NULL);
   -
   -    // Test that checkboxes are found by name when passing no second parameter.
   -    $this->assertFieldByName('checkbox_enabled');
   -    $this->assertFieldByName('checkbox_disabled');
   -
   -    // Test that we have legacy support.
   -    $this->assertFieldByName('checkbox_enabled', '1');
   -    $this->assertFieldByName('checkbox_disabled', '');
   -
   -    // Test that the assertion fails correctly when using NULL to ignore state.
   -    try {
   -      $this->assertNoFieldByName('checkbox_enabled', NULL);
   -      $this->fail('The "checkbox_enabled" field was not found by name, using NULL value.');
   -    }
   -    catch (ExpectationException $e) {
   -      $this->pass('assertNoFieldByName failed correctly. The "checkbox_enabled" field was found using NULL value.');
   -    }
   -
   -    // Part 2 - Test by ID.
   -    // Test that checkboxes are found/not found correctly by ID, when using
   -    // TRUE or FALSE to match their 'checked' state.
   -    $this->assertFieldById('edit-checkbox-enabled', TRUE);
   -    $this->assertFieldById('edit-checkbox-disabled', FALSE);
   -    $this->assertNoFieldById('edit-checkbox-enabled', FALSE);
   -    $this->assertNoFieldById('edit-checkbox-disabled', TRUE);
   -
   -    // Test that checkboxes are found by ID, when using NULL to ignore the
   -    // 'checked' state.
   -    $this->assertFieldById('edit-checkbox-enabled', NULL);
   -    $this->assertFieldById('edit-checkbox-disabled', NULL);
   -
   -    // Test that checkboxes are found by ID when passing no second parameter.
   -    $this->assertFieldById('edit-checkbox-enabled');
   -    $this->assertFieldById('edit-checkbox-disabled');
   -
   -    // Test that we have legacy support.
   -    $this->assertFieldById('edit-checkbox-enabled', '1');
   -    $this->assertFieldById('edit-checkbox-disabled', '');
   -
   -    // Test that the assertion fails correctly when using NULL to ignore state.
   -    try {
   -      $this->assertNoFieldById('edit-checkbox-disabled', NULL);
   -      $this->fail('The "edit-checkbox-disabled" field was not found by ID, using NULL value.');
   -    }
   -    catch (ExpectationException $e) {
   -      $this->pass('assertNoFieldById failed correctly. The "edit-checkbox-disabled" field was found by ID using NULL value.');
   -    }
   -
   -    // Part 3 - Test the specific 'checked' assertions.
        $this->assertFieldChecked('edit-checkbox-enabled');
        $this->assertNoFieldChecked('edit-checkbox-disabled');
   -
   -    // Test that the assertion fails correctly with non-existent field id.
   -    try {
   -      $this->assertNoFieldChecked('incorrect_checkbox_id');
   -      $this->fail('The "incorrect_checkbox_id" field was found');
   -    }
   -    catch (ExpectationException $e) {
   -      $this->pass('assertNoFieldChecked correctly failed. The "incorrect_checkbox_id" field was not found.');
   -    }
   -
   -    // Test that the assertion fails correctly for a checkbox that is checked.
   -    try {
   -      $this->assertNoFieldChecked('edit-checkbox-enabled');
   -      $this->fail('The "edit-checkbox-enabled" field was not found in a checked state.');
   -    }
   -    catch (ExpectationException $e) {
   -      $this->pass('assertNoFieldChecked correctly failed. The "edit-checkbox-enabled" field was found in a checked state.');
   -    }
   -
   -    // Test that the assertion fails correctly for a checkbox that is not
   -    // checked.
   -    try {
   -      $this->assertFieldChecked('edit-checkbox-disabled');
   -      $this->fail('The "edit-checkbox-disabled" field was found and checked.');
   -    }
   -    catch (ExpectationException $e) {
   -      $this->pass('assertFieldChecked correctly failed. The "edit-checkbox-disabled" field was not found in a checked state.');
   -    }
      }
   

   Are not we losing test coverage here? Better leave the test as-is converting the calls, and add a separate deprecation test just for the unconverted calls.

Also, the deprecation silencer in DeprecationListener is not removed.

@jungle #18.2 actually I did not check if there is other test coverage for that, but now I see that the docblock says 'Tests legacy field asserts for checkbox field type.'. If we're not losing coverage of other methods, that'd be fine I guess.

Thanks!

Reroll of #22. #25 is likely a random failure, but I rerolled from last green patch.