Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Discovered at #2972224: Add .cspell.json to automate spellchecking in Drupal core, and pointed by @xjm in https://www.drupal.org/project/drupal/issues/3122088#comment-13628724
+++ b/core/.cspell.json
@@ -0,0 +1,1288 @@
+ "autcomplete",
Proposed resolution
@xjm: "autocomplete".
As title and see the change record https://www.drupal.org/node/3122084 for how to work with cspell.
Remaining tasks
Pick out all applicable words from #2972224: Add .cspell.json to automate spellchecking in Drupal core and fix them.
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#11 | interdiff-3-11.txt | 292 bytes | jungle |
#11 | 3138788-11.patch | 1.24 KB | jungle |
Comments
Comment #2
sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commentedComment #3
sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commentedComment #5
sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commentedThe test is failing because of changed spelling.
Should this test be fixed along with this issue? Because this seems to be out of scope to me.
We should open another issue to fix this.
Comment #6
mohrerao CreditAttribution: mohrerao as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #7
mohrerao CreditAttribution: mohrerao as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #8
longwaveFailure seems unrelated and I can't reproduce locally. Otherwise the patch looks good so marking RTBC and triggering a retest; the bot will set it back to needs work if it does fail again.
Comment #9
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae as a volunteer and commentedQuickfix. Looks good to commit. +1 for RTBC.
Edit: The patch needs backport to 8.x.
Comment #10
xjmNow that #2972224: Add .cspell.json to automate spellchecking in Drupal core is in, we can make sure this spelling error never happens again by removing the entry from Drupal's dictionrary, so let's update the patch to include that. Thanks!
Comment #11
jungleRemoved autcomplete from the dictionary. Setting back to RTBC as this is a tiny change.
Comment #12
xjmBoth could probably be two words in the comment.
Then these two actually have uses in code:
So, that's a long-winded saying of "I think we need a followup for auto-complete run on names in JavaScript" which would need review by the frontend framework manager probably to explain. I'm tagging "Needs followup" for that, and reducing the scope of this issue to just the non-JS case.
The change in this patch is allowable because it is a fix to an internal variable name in a test that is not exposed publicly anywhere. If someone were to later use the correct spelling without us fixing this, that could introduce bugs.
Comment #16
xjmCommitted and pushed #12 to 9.1.x. Thanks!
Since 9.0.x and earlier do not have the dictionary, but these are test spelling bugs, we can backport the fixes themselves to 9.0/8.9. Fortunately we have a patch that does just that in #3, so I'm going to try using that patch for backport. Committed #3 to 9.0.x and cherry-picked it to 8.9.x. Thanks everyone!
Comment #17
jungle@xjm, thanks for committing!
Removing the Needs followup tag, as I just added it to the parent issue's Remaining tasks section in IS. It's a bit hard for me to do it myself.