Problem/Motivation

Discovered at #2972224: Add .cspell.json to automate spellchecking in Drupal core, and pointed by @xjm in https://www.drupal.org/project/drupal/issues/3122088#comment-13628724

Becalled
Isnew
describedby this is from aria-describedby, I don't think there's anything to fix -- this needs to stay in the word list.
Bytouched
Entitiesto
Fieldby
Groupby
Librariesby
Urlto
intefacewithconstants
invalidateby
mydistro
mydriver
myeditor
myeditoroverride
myfragment
myfrontpage
myfunctions
mymenu
mymodule - too many instances of this, this can be done separately
mynewpassword
myothermenu
mypath
myprimarykey
myprofile
myproject
myrootuser
myroute
mysetting
mysite - too many instances of this, this can be done separately
mytab
mytable
mytheme
mytube
mytype
myvalue
myvar
myverylongurl
myverylongurlexample
nosuchcolumn
nosuchindex
nosuchscheme - part of XssTest which has many spelling issues, should be done separately
nosuchtable
nosuchtag - part of XssTest which has many spelling issues, should be done separately
testid
testnoschema
wrongparam

Proposed resolution

Make sure everything isProperlyCamelCased or snake_cased as appropriate.

Remaining tasks

Pick out all applicable words from #2972224: Add .cspell.json to automate spellchecking in Drupal core and fix them.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#48 3138746-48.patch70.1 KBjungle
#48 interdiff-42-48.txt1.33 KBjungle
#42 3138746-42.patch71.25 KBquietone
#42 diff-40-42.txt6.37 KBquietone
#40 3138746-40.patch72.27 KBjungle
#40 raw-interdiff-38-40.txt1.53 KBjungle
#39 3138746-39.patch71.48 KBjungle
#39 raw-interdiff-38-39.txt2.37 KBjungle
#38 interdiff-36-38.txt541 bytesjungle
#38 3138746-38.patch72.72 KBjungle
#36 interdiff-34-36.txt814 bytesjungle
#36 3138746-36.patch73.25 KBjungle
#34 3138746-34.patch72.45 KBjungle
#32 3138746-32.patch72.01 KBjungle
#32 interdiff-26-32.txt3.76 KBjungle
#26 interdiff-25-26.txt657 bytesjungle
#26 3138746-26.patch73.38 KBjungle
#25 interdiff.3138746.23-25.txt44.95 KBlongwave
#25 3138746-25.patch73.41 KBlongwave
#23 raw-interdiff-19-23.txt3.66 KBjameszhang023
#23 3138746-23.patch29.98 KBjameszhang023
#19 interdiff_16-19.txt11.28 KBrajandro
#19 3138746-19.patch31.17 KBrajandro
#16 interdiff_13-16.txt1.96 KBrajandro
#16 3138746-16.patch20.73 KBrajandro
#13 3138746-13.patch18.68 KBsja112
#4 3138746-4.patch4.61 KBsja112
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jungle created an issue. See original summary.

dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented
Issue summary: View changes

Simplifying the summary:

a) This doesn't necessarily require cspell or knowledge of how to work with it.

b) We don't need to keep being reminded that we're supposed to wrap comments to 80 chars. The pedantic dreditor review crowd will definitely make sure that happens naturally. ;)

Thanks,
-Derek

sja112’s picture

sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » sja112
sja112’s picture

sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3138746-4.patch4.61 KB

Addressed Becalled and Isnew,

describedby is coming in aria label.

$variables['attributes']['aria-describedby'] = $description_id;

sja112’s picture

sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: sja112 » Unassigned
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

Several more we can hopefully fix here. Some of these may need snake_case instead of camelCase.

Bytouched
Entitiesto
Groupby
Librariesby
Urlto
intefacewithconstants
invalidateby
mydistro
mydriver
myeditor
myeditoroverride
myfragment
myfrontpage
myfunctions
mymenu
mymodule
mynewpassword
myothermenu
mypath
myprimarykey
myprofile
myproject
myrootuser
myroute
mysetting
mysite
mytab
mytable
mytheme
mytube
mytype
myvalue
myvar
myverylongurl
myverylongurlexample
nosuchcolumn
nosuchindex
nosuchscheme
nosuchtable
nosuchtag
testid
testnoschema
wrongparam

dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented
Issue summary: View changes
Status: Needs review » Needs work

A) Moved @longwave's list from #6 into the summary. Added "or properly snake_cased" to the proposed resolution. Also removing the punctuation/formatting noise from the original list (pasted from dreditor).

B) I crossed off "describedby" since that's not camelCase nor snake_case. It's from aria-describedby which is the actual name of the attribute. That one should say in the word list.

C) Given the changes in patch #4, I don't understand why we aren't already getting fatal errors for our tests. ;) WTF? If we misspelled the method name and are calling that in our tests, why aren't we seeing fatal errors about it? If we're not actually calling these things, why are they in the test suite at all? If we are calling them, why aren't they blowing up?

NW for the vastly expanded list, and for an answer to C. ;)

Thanks,
-Derek

dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented
Issue summary: View changes

Whoops, fixing my formatting #fail.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Issue summary: View changes

One more; Fieldby

sja112’s picture

sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » sja112
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

> I don't understand why we aren't already getting fatal errors for our tests. ;) WTF? If we misspelled the method name and are calling that in our tests, why aren't we seeing fatal errors about it?

PHP is not case sensitive for function, method or variable names, so $this->shouldbecamelcased() is identical to $this->shouldBeCamelCased(). So there is no technical issue here, but fixing this improves readability.

sja112’s picture

sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commented

On this.

sja112’s picture

sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: sja112 » Unassigned
Status: Needs work » Needs review
FileSize
3138746-13.patch18.68 KB

I have included the changes for the list of words shared in #6.

I have not changed many words where in my view change was not required. Below is the list,

intefacewithconstants
mydistro
mydriver
myeditor
myeditoroverride
myfragment
myfrontpage
myfunctions
mymenu
mymodule
mynewpassword
myothermenu
mypath
myprimarykey
myprofile
myproject
myrootuser
myroute
mysite
mytab
mytable
mytube
myvalue
myverylongurl
myverylongurlexample
nosuchcolumn
nosuchindex
nosuchscheme
nosuchtable
nosuchtag
testid
testnoschema
wrongparam

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Needs work

#2972224: Add .cspell.json to automate spellchecking in Drupal core landed, let's remove typos from core/misc/cspell/dictionary.txt to avoid making the same mistakes again.

rajandro’s picture

rajandro CreditAttribution: rajandro as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » rajandro

I am working on this.

rajandro’s picture

rajandro CreditAttribution: rajandro as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: rajandro » Unassigned
Status: Needs work » Needs review
FileSize
3138746-16.patch20.73 KB
interdiff_13-16.txt1.96 KB

I have update core/misc/cspell/dictionary.txt by removing the above-listed typos from the list. Please review the changes.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented 
  1. +++ b/core/modules/editor/js/editor.admin.es6.js
@@ -174,7 +174,7 @@
-              touchedBytouchedByForbiddenPropertyRule: false,
+              touchedByTouchedByForbiddenPropertyRule: false,

+++ b/core/modules/editor/js/editor.admin.js
@@ -33,7 +33,7 @@
-              touchedBytouchedByForbiddenPropertyRule: false
+              touchedByTouchedByForbiddenPropertyRule: false

    I am not sure about this one. JavaScript is case sensitive and so technically changing the T here might cause a bug in the code. But the property doesn't seem used anywhere else, so why does it exist in the first place? Even a case insensitive search for "forbiddenpropertyrule" only finds these two lines. 

  2. +++ b/core/modules/field/field.api.php
@@ -190,9 +190,9 @@ function hook_field_widget_info_alter(array &$info) {
-  // Add a css class to widget form elements for all fields of type mytype.
+  // Add a css class to widget form elements for all fields of type my_type.

@@ -257,9 +257,9 @@ function hook_field_widget_WIDGET_TYPE_form_alter(&$element, \Drupal\Core\Form\F
-  // Add a css class to widget form elements for all fields of type mytype.
+  // Add a css class to widget form elements for all fields of type my_type.

    Probably out of scope here but I wonder if we can find a way of enforcing initialisms and acronyms such as "CSS" being correctly capitalised. 

  3. +++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityQueryAggregateTest.php
@@ -517,7 +517,7 @@ public function testAggregation() {
-    // Groupby and aggregate by fieldapi field, and sort by the aggregated
+    // Group by and aggregate by fieldapi field, and sort by the aggregated

    "fieldapi" should be really be "Field API" which is technically in scope of this issue. 

  4. +++ b/core/tests/Drupal/Tests/Core/Database/InstallerObjectTest.php
@@ -47,7 +47,7 @@ public function testDbInstallerObject($driver, $namespace, $expected_class_name)
-   * Dataprovider for testDbUrltoConnectionConversion().
+   * Dataprovider for testDbUrlToConnectionConversion().

+++ b/core/tests/Drupal/Tests/Core/Database/UrlConversionTest.php
@@ -48,13 +48,13 @@ protected function setUp(): void {
-   * Dataprovider for testDbUrltoConnectionConversion().
+   * Dataprovider for testDbUrlToConnectionConversion().

    Dataprovider -> Data provider

rajandro’s picture

rajandro CreditAttribution: rajandro as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » rajandro
Status: Needs review » Needs work

Ok, Let me work on #17

rajandro’s picture

rajandro CreditAttribution: rajandro as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: rajandro » Unassigned
Status: Needs work » Needs review
FileSize
3138746-19.patch31.17 KB
interdiff_16-19.txt11.28 KB

I have addressed point 1, 3, 4 of comment #17 where point 2 kept as it is as I think we can create a separate ticket for this.

Also in addition to the above update, I have noticed * Dataprovider in near about 30 places I have changed it to * Data provider

Thanks
Rajandro

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs reroll 
  1. +++ b/core/modules/editor/js/editor.admin.js
@@ -370,4 +370,4 @@
-})(jQuery, _, Drupal, document);
\ No newline at end of file
+})(jQuery, _, Drupal, document);

    .js file(s) should be generated by cd core && yarn && yarn build:js

  2. Needs reroll
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Issue tags: +Global2020

Also tagging "Global2020"

jameszhang023’s picture

jameszhang023 CreditAttribution: jameszhang023 commented
Assigned: Unassigned » jameszhang023

working on this

jameszhang023’s picture

jameszhang023 CreditAttribution: jameszhang023 commented
Assigned: jameszhang023 » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
3138746-23.patch29.98 KB
raw-interdiff-19-23.txt3.66 KB

Rerollling done, please review, thanks.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Needs work

@jameszhang023, thanks for rerolling!

$ yarn spellcheck:core
yarn run v1.22.4
$ cspell "**/*" "../composer/**/*" "../composer.json"
[Output omitted]
CSpell: Files checked: 14630, <strong>Issues found: 19 in 8 files</strong>

Spelling check did not pass, and did not see removals of my* words from the directory in #23

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Needs review
FileSize
3138746-25.patch73.41 KB
interdiff.3138746.23-25.txt44.95 KB

Regenerated the dictionary, as the Annotation component that copies Doctrine was ignored in #3138766: Fix "Don't" relevant typos in core and this removes several words including some of the ones identified here.

I have left mymodule and mysite alone for now (except on lines touched by other changes in this patch) as they are used in a large number of places. I also left nosuchscheme and nosuchtag as I think we should deal with XssTest in a separate issue, it has many words we could ignore.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Reviewed & tested by the community
FileSize
3138746-26.patch73.38 KB
interdiff-25-26.txt657 bytes

Thanks @longwave!

Addressing:

  1. Spellcheck did not pass, because "distro" is a unknown word. 
  2. +++ b/core/modules/editor/js/editor.admin.js
@@ -370,4 +370,4 @@
-})(jQuery, _, Drupal, document);
\ No newline at end of file
+})(jQuery, _, Drupal, document);

    .js file should be generated by running yarn build:js

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Title: Fix "shouldBeCamelCased" typos in core » Fix "shouldBeCamelCased" and relevant typos in core

Change the title/scope slightly to inline with the changes here/patch.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Title: Fix "shouldBeCamelCased" and relevant typos in core » Fix 50+ "shouldBeCamelCased" and relevant typos in core

Adding the total number

dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented
Status: Reviewed & tested by the community » Needs review

Mostly looks great.

I had a brief scare about changing function names, but then I remembered that PHP is case insensitive. ;)

A few concerns:

  1. +++ b/core/misc/cspell/dictionary.txt
@@ -326,7 +324,6 @@ conkey
-contant

@@ -808,12 +803,8 @@ instaclick
-inteface
...
-invalida

@@ -1962,14 +1913,12 @@ uploadsize
-upserting

    Are these getting fixed here? I don't see them. Seems out of scope. 

  2. +++ b/core/modules/views/tests/src/Kernel/QueryGroupByTest.php
@@ -75,8 +75,8 @@ public function testAggregateCount() {
-    $this->assertEqual($types['name1'], 4, 'Groupby the name: name1 returned the expected amount of results.');
-    $this->assertEqual($types['name2'], 3, 'Groupby the name: name2 returned the expected amount of results.');
+    $this->assertEqual($types['name1'], 4, 'Group by the name: name1 returned the expected amount of results.');
+    $this->assertEqual($types['name2'], 3, 'Group by the name: name2 returned the expected amount of results.');

    If we're touching these anyway, why not entirely remove the redundant messages in the final arg?

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Issue summary: View changes
  1. contant, inteface and invalida are only in tests/Drupal/Tests/Component/Annotation/Doctrine/ which was ignored in #3138766: Fix "Don't" relevant typos in core

    upserting was removed in #3129560: Remove the Upsert implementation for PostgreSQL < 9.5

    Neither of these issues regenerated the dictionary. Perhaps this task should be spun out to a separate issue?

  2. I was already concerned about scope creep when fixing some instances of "mymodule" but not all of them - I think making PHPunit changes here is definitely out of scope

Also updated IS to remove words that I think should be handled elsewhere.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Related issues: +#3164211: Remove 8 fixed typos from misc/cspell/dictionary.txt

Re #29.1/#30.1 filed #3164211: Remove 8 fixed typos from misc/cspell/dictionary.txt

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Title: Fix 50+ "shouldBeCamelCased" and relevant typos in core » Fix ~50 "shouldBeCamelCased" and relevant typos in core
FileSize
interdiff-26-32.txt3.76 KB
3138746-32.patch72.01 KB
  1. Without including those 7 pending removal typos, typos fixed here could be 1) "shouldBeCamelCased" typos + 2) "shouldBeCamelCased" relevant typos -- side effects. So I think the scope here is ok.
  2. distro is a new unknown word from fixing mydistro
  3. Re #29.2. Besides removing the message, replaced assertEqual() with assertEquals() at the same time.
  4. The total words involving is 46, so changing 50+ to ~50 in title.
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Postponed

Postpone on #3164211

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Postponed » Needs review
FileSize
3138746-34.patch72.45 KB

#32 was built upon #3164211, this patch includes #3164211.

Status: Needs review » Needs work

The last submitted patch, 34: 3138746-34.patch, failed testing. View results

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs work » Needs review
FileSize
3138746-36.patch73.25 KB
interdiff-34-36.txt814 bytes

Fixing test failed.

--- a/sites/default/default.settings.php
+++ b/sites/default/default.settings.php
@@ -230,9 +230,9 @@
  * Sample Database configuration format for a driver in a contributed module:
  * @code
  *   $databases['default']['default'] = [
- *     'driver' => 'mydriver',
- *     'namespace' => 'Drupal\mymodule\Driver\Database\mydriver',
- *     'autoload' => 'modules/mymodule/src/Driver/Database/mydriver/',
+ *     'driver' => 'my_driver',
+ *     'namespace' => 'Drupal\my_module\Driver\Database\my_driver',
+ *     'autoload' => 'modules/my_module/src/Driver/Database/my_driver/',
  *     'database' => 'databasename',
  *     'username' => 'sqlusername',
  *     'password' => 'sqlpassword',
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Needs work 
+++ b/core/modules/migrate_drupal/tests/fixtures/drupal7.php
@@ -50894,7 +50894,7 @@
-  'name' => 'viewsUiGroupbyTestCase',
+  'name' => 'viewsUiGroupByTestCase',

Do not change anything in the Drupal 7 test fixture.

The migrate fixtures, drupal6.php and drupal7.php, are in the ignoredPaths in .cspell.json.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs work » Needs review
FileSize
3138746-38.patch72.72 KB
interdiff-36-38.txt541 bytes

Good point, @quietone, thanks! Reverted.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
FileSize
raw-interdiff-38-39.txt2.37 KB
3138746-39.patch71.48 KB

#3164211: Remove 8 fixed typos from misc/cspell/dictionary.txt was in. Rerolled.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
FileSize
raw-interdiff-38-40.txt1.53 KB
3138746-40.patch72.27 KB

Please ignore #39. Rerolled from #38 again.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
FileSize
diff-40-42.txt6.37 KB
3138746-42.patch71.25 KB

Needed a reroll.

Abhijith S’s picture

Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commented

Applied patch #42 . Works fine on 9.2.x

Checking patch core/assets/scaffold/files/default.settings.php...
Checking patch core/core.api.php...
Checking patch core/includes/form.inc...
Checking patch core/lib/Drupal/Core/Cache/PhpBackend.php...
Checking patch core/lib/Drupal/Core/Database/database.api.php...
Checking patch core/lib/Drupal/Core/Extension/module.api.php...
Checking patch core/lib/Drupal/Core/Field/Plugin/Field/FieldFormatter/EntityReferenceFormatterBase.php...
Checking patch core/lib/Drupal/Core/Render/theme.api.php...
Checking patch core/lib/Drupal/Core/Routing/routing.api.php...
Checking patch core/lib/Drupal/Core/Template/Loader/FilesystemLoader.php...
Checking patch core/misc/ajax.es6.js...
Checking patch core/misc/cspell/dictionary.txt...
Checking patch core/modules/block_content/tests/src/Kernel/BlockContentAccessHandlerTest.php...
Checking patch core/modules/block_content/tests/src/Unit/Access/DependentAccessTest.php...
Checking patch core/modules/config/tests/config_schema_test/config/install/config_schema_test.someschema.yml...
Checking patch core/modules/editor/editor.api.php...
Checking patch core/modules/editor/js/editor.admin.es6.js...
Checking patch core/modules/editor/js/editor.admin.js...
Checking patch core/modules/editor/src/Annotation/Editor.php...
Checking patch core/modules/field/field.api.php...
Checking patch core/modules/field/tests/src/Kernel/FieldAttachStorageTest.php...
Checking patch core/modules/field_ui/field_ui.api.php...
Checking patch core/modules/layout_builder/tests/src/Functional/LayoutBuilderTest.php...
Checking patch core/modules/layout_builder/tests/src/Kernel/LayoutEntityHelperTraitTest.php...
Checking patch core/modules/layout_builder/tests/src/Unit/BlockComponentRenderArrayTest.php...
Checking patch core/modules/layout_builder/tests/src/Unit/LayoutEntityHelperTraitTest.php...
Checking patch core/modules/locale/locale.compare.inc...
Checking patch core/modules/node/tests/src/Functional/NodeQueryAlterTest.php...
Checking patch core/modules/system/tests/modules/layout_test/src/Plugin/Layout/LayoutTestDependenciesPlugin.php...
Checking patch core/modules/system/tests/src/FunctionalJavascript/OffCanvasTestBase.php...
Checking patch core/modules/update/tests/src/Functional/UpdateCoreTest.php...
Checking patch core/modules/views/tests/src/Kernel/QueryGroupByTest.php...
Checking patch core/scripts/password-hash.sh...
Checking patch core/tests/Drupal/FunctionalTests/Installer/DistributionProfileExistingSettingsTest.php...
Checking patch core/tests/Drupal/FunctionalTests/Installer/DistributionProfileTest.php...
Checking patch core/tests/Drupal/FunctionalTests/Installer/DistributionProfileTranslationQueryTest.php...
Checking patch core/tests/Drupal/FunctionalTests/Installer/DistributionProfileTranslationTest.php...
Checking patch core/tests/Drupal/KernelTests/Core/Config/ConfigSchemaTest.php...
Checking patch core/tests/Drupal/KernelTests/Core/Database/RegressionTest.php...
Checking patch core/tests/Drupal/KernelTests/Core/Database/SelectComplexTest.php...
Checking patch core/tests/Drupal/KernelTests/Core/Entity/EntityQueryAggregateTest.php...
Checking patch core/tests/Drupal/KernelTests/Core/Extension/ModuleInstallerTest.php...
Checking patch core/tests/Drupal/Tests/Component/Bridge/ZfExtensionManagerSfContainerTest.php...
Checking patch core/tests/Drupal/Tests/Component/Uuid/UuidTest.php...
Checking patch core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php...
Checking patch core/tests/Drupal/Tests/Core/Asset/LibraryDiscoveryTest.php...
Checking patch core/tests/Drupal/Tests/Core/Database/ConnectionTest.php...
Hunk #1 succeeded at 19 (offset 1 line).
Hunk #2 succeeded at 68 (offset 1 line).
Hunk #3 succeeded at 117 (offset 1 line).
Hunk #4 succeeded at 290 (offset 1 line).
Hunk #5 succeeded at 366 (offset 1 line).
Hunk #6 succeeded at 402 (offset 1 line).
Hunk #7 succeeded at 644 (offset 16 lines).
Checking patch core/tests/Drupal/Tests/Core/Database/InstallerObjectTest.php...
Checking patch core/tests/Drupal/Tests/Core/Database/UrlConversionTest.php...
Checking patch core/tests/Drupal/Tests/Core/EventSubscriber/ActiveLinkResponseFilterTest.php...
Checking patch core/tests/Drupal/Tests/Core/Extension/ExtensionDiscoveryTest.php...
Checking patch core/tests/Drupal/Tests/Core/Extension/InfoParserUnitTest.php...
Checking patch core/tests/Drupal/Tests/Core/Form/FormStateDecoratorBaseTest.php...
Checking patch sites/default/default.settings.php...
warning: sites/default/default.settings.php has type 100755, expected 100644
Applied patch core/assets/scaffold/files/default.settings.php cleanly.
Applied patch core/core.api.php cleanly.
Applied patch core/includes/form.inc cleanly.
Applied patch core/lib/Drupal/Core/Cache/PhpBackend.php cleanly.
Applied patch core/lib/Drupal/Core/Database/database.api.php cleanly.
Applied patch core/lib/Drupal/Core/Extension/module.api.php cleanly.
Applied patch core/lib/Drupal/Core/Field/Plugin/Field/FieldFormatter/EntityReferenceFormatterBase.php cleanly.
Applied patch core/lib/Drupal/Core/Render/theme.api.php cleanly.
Applied patch core/lib/Drupal/Core/Routing/routing.api.php cleanly.
Applied patch core/lib/Drupal/Core/Template/Loader/FilesystemLoader.php cleanly.
Applied patch core/misc/ajax.es6.js cleanly.
Applied patch core/misc/cspell/dictionary.txt cleanly.
Applied patch core/modules/block_content/tests/src/Kernel/BlockContentAccessHandlerTest.php cleanly.
Applied patch core/modules/block_content/tests/src/Unit/Access/DependentAccessTest.php cleanly.
Applied patch core/modules/config/tests/config_schema_test/config/install/config_schema_test.someschema.yml cleanly.
Applied patch core/modules/editor/editor.api.php cleanly.
Applied patch core/modules/editor/js/editor.admin.es6.js cleanly.
Applied patch core/modules/editor/js/editor.admin.js cleanly.
Applied patch core/modules/editor/src/Annotation/Editor.php cleanly.
Applied patch core/modules/field/field.api.php cleanly.
Applied patch core/modules/field/tests/src/Kernel/FieldAttachStorageTest.php cleanly.
Applied patch core/modules/field_ui/field_ui.api.php cleanly.
Applied patch core/modules/layout_builder/tests/src/Functional/LayoutBuilderTest.php cleanly.
Applied patch core/modules/layout_builder/tests/src/Kernel/LayoutEntityHelperTraitTest.php cleanly.
Applied patch core/modules/layout_builder/tests/src/Unit/BlockComponentRenderArrayTest.php cleanly.
Applied patch core/modules/layout_builder/tests/src/Unit/LayoutEntityHelperTraitTest.php cleanly.
Applied patch core/modules/locale/locale.compare.inc cleanly.
Applied patch core/modules/node/tests/src/Functional/NodeQueryAlterTest.php cleanly.
Applied patch core/modules/system/tests/modules/layout_test/src/Plugin/Layout/LayoutTestDependenciesPlugin.php cleanly.
Applied patch core/modules/system/tests/src/FunctionalJavascript/OffCanvasTestBase.php cleanly.
Applied patch core/modules/update/tests/src/Functional/UpdateCoreTest.php cleanly.
Applied patch core/modules/views/tests/src/Kernel/QueryGroupByTest.php cleanly.
Applied patch core/scripts/password-hash.sh cleanly.
Applied patch core/tests/Drupal/FunctionalTests/Installer/DistributionProfileExistingSettingsTest.php cleanly.
Applied patch core/tests/Drupal/FunctionalTests/Installer/DistributionProfileTest.php cleanly.
Applied patch core/tests/Drupal/FunctionalTests/Installer/DistributionProfileTranslationQueryTest.php cleanly.
Applied patch core/tests/Drupal/FunctionalTests/Installer/DistributionProfileTranslationTest.php cleanly.
Applied patch core/tests/Drupal/KernelTests/Core/Config/ConfigSchemaTest.php cleanly.
Applied patch core/tests/Drupal/KernelTests/Core/Database/RegressionTest.php cleanly.
Applied patch core/tests/Drupal/KernelTests/Core/Database/SelectComplexTest.php cleanly.
Applied patch core/tests/Drupal/KernelTests/Core/Entity/EntityQueryAggregateTest.php cleanly.
Applied patch core/tests/Drupal/KernelTests/Core/Extension/ModuleInstallerTest.php cleanly.
Applied patch core/tests/Drupal/Tests/Component/Bridge/ZfExtensionManagerSfContainerTest.php cleanly.
Applied patch core/tests/Drupal/Tests/Component/Uuid/UuidTest.php cleanly.
Applied patch core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php cleanly.
Applied patch core/tests/Drupal/Tests/Core/Asset/LibraryDiscoveryTest.php cleanly.
Applied patch core/tests/Drupal/Tests/Core/Database/ConnectionTest.php cleanly.
Applied patch core/tests/Drupal/Tests/Core/Database/InstallerObjectTest.php cleanly.
Applied patch core/tests/Drupal/Tests/Core/Database/UrlConversionTest.php cleanly.
Applied patch core/tests/Drupal/Tests/Core/EventSubscriber/ActiveLinkResponseFilterTest.php cleanly.
Applied patch core/tests/Drupal/Tests/Core/Extension/ExtensionDiscoveryTest.php cleanly.
Applied patch core/tests/Drupal/Tests/Core/Extension/InfoParserUnitTest.php cleanly.
Applied patch core/tests/Drupal/Tests/Core/Form/FormStateDecoratorBaseTest.php cleanly.
Applied patch sites/default/default.settings.php cleanly.
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Reviewed & tested by the community 
$ yarn spellcheck:core
yarn run v1.22.4
$ cspell "**/*" ".*" "../composer/**/*" "../composer.json"
CSpell: Files checked: 15133, Issues found: 0 in 0 files
✨  Done in 432.56s.

$ yarn build # Check passed

Looks great. thanks!

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Issue tags: +Needs followup

Needs followup to remove leftovers in misc/cspell/dictionary.txt

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Issue tags: -Needs followup
Related issues: +#3178581: Remove misspelled words from dictionary that are no longer used

Removing the Needs followup tag

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/editor/js/editor.admin.es6.js
@@ -174,7 +174,7 @@
-              touchedBytouchedByForbiddenPropertyRule: false,
+              touchedByForbiddenPropertyRule: false,

+++ b/core/modules/editor/js/editor.admin.js
@@ -33,7 +33,7 @@
-              touchedBytouchedByForbiddenPropertyRule: false
+              touchedByForbiddenPropertyRule: false

This was asked in #17.1 but there was no reply - JS is case sensitive so some sleuthing needs to take place to explain what it go on here. It was added in #1894644: Unidirectional editor configuration -> filter settings syncing. I think this is dead code that was in previous iterations of the patch a so should be removed. Imo should file an issue to do that rather than change it here. It could block this one or we could remove the change and revert the bytouched fix in the dictionary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs work » Needs review
Issue tags: +Needs followup
FileSize
interdiff-42-48.txt1.33 KB
3138746-48.patch70.1 KB

Sorry, missed #17.1, reverting. Tagging needs followup for #17.1

$ yarn spellcheck:core
yarn run v1.22.4
$ cspell "**/*" ".*" "../composer/**/*" "../composer.json"
CSpell: Files checked: 15146, Issues found: 0 in 0 files
✨  Done in 230.24s.
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs followup
Related issues: +#3181290: Remove dead code in editor.admin.es6.js involving touchedBytouchedByForbiddenPropertyRule

Filed #3181290: Remove dead code in editor.admin.es6.js involving touchedBytouchedByForbiddenPropertyRule and setting back to RTBC

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Title: Fix ~50 "shouldBeCamelCased" and relevant typos in core » Fix 45 "shouldBeCamelCased" and related typos in core
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 0eec7fe50d to 9.2.x and a5dac86510 to 9.1.x. Thanks!

Backported to 9.1.x since this only changes the case of things in runtime code and documentation. There are test changes too but not things that are part of the API.

  • alexpott committed 0eec7fe on 9.2.x 
    Issue #3138746 by jungle, rajandro, sja112, longwave, jameszhang023,...

  • alexpott committed a5dac86 on 9.1.x 
    Issue #3138746 by jungle, rajandro, sja112, longwave, jameszhang023,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.