Argument 1 passed to Drupal\Core\Form\SubformState::createForSubform() must be of the type array, null given

Reproduced the issue in my local, We don't need to add any content with the new text format to reproduce the issue.

Just add a new Text Format 'Simple Plain' with the 'Ckeditor' selected. Then edit the Text Format with "None" selected.

Assigning to me to start working on it.

Patch added

I am also able to reproduce this issue.

I tested your patch, it looks good to me.

+1 for RTBC.

Hello codersukanta,

Thanks for working on this, the fix has come really fast.

Thanks for filing this bug report and for fixing the issue.

In order to commit a bug fix, we need an automated to test to prove that we've fixed the bug and ensure that we don't break it again in the future. For more information about writing tests in Drupal 8 see the following links:

1. https://www.drupal.org/docs/8/testing
2. https://api.drupal.org/api/drupal/core%21core.api.php/group/testing/8.9.x

Hello xjm,
Thanks for the guidance and the resources shared....

I checked the piece of code that #3 has worked upon, it has a test coverage already mentioned in "core/modules/editor/tests/src/Functional/EditorAdminTest.php" file at function testAddEditorToNewFormat()

How can we have that triggered on the patch at #3, or how D.O test runner checks for the existing test cases to be executed. This will help us better understand the test bot.

Thanks.

didn't noticed status changing to 'Neede Review' reverting as per #6

I see this been executed by test bot and bot seems happy with the patch at #3

I think this might meet the test requirement as suggested in #6, kindly correct if I get this otherwise.
Updateing for needs review.

Patch #3 is working fine in Drupal-8.8.6 and there are no logs were found in /admin/reports/dblog

+++ b/core/modules/editor/editor.module
@@ -247,7 +247,9 @@ function editor_form_filter_admin_format_submit($form, FormStateInterface $form_
+  if (($editor_plugin = $form_state->get('editor_plugin')) && $editor_set && $subform_array_exists) {

$editor_plugin = $form_state..., is that meant to be an assignment = or comparison ==?

Hi @Devjojodae,

$editor_plugin = $form_state->get('editor_plugin')
This is an assignment statement(=) as $editor_plugin is used to call the submitConfigurationForm function.

I just had the same error in 9.0.3. Tried to switch off CKEditor in the settings. No error switching CKEditor on. I guess the code is the similar.

In 9.0.3, the change is at line 250 but #3 does not fix it. The code must be a bit different.

Patch #3 works like a charm with 8.9.6

This is a fatal error reproducible purely by configuration in the UI, so bumping to critical.

@atul4drupal

We need to add test coverage to show that this patch fixes the bug - at the moment the test coverage only shows that it doesn't make things worse.

So Functional/EditorAdminTest.php should be expanded to check the case where the editor selection is changed to none - and that test should fail without the patch applied.

Patch #3 works.

I can reproduce this fatal error by saving the editor configuration under the testAddEditorToExistingFormat() test without the patch.

Patch added with minor adjustment to the tests. Should we make separate test for this issue or should this minor change to the tests be sufficient enough?

I an confirm the steps to reproduce in the IS are accurate.

I changed the form settings for "/admin/config/content/formats/manage/full_html".

In the dropdown "form-item-editor-editor" I select "none" (not CKeditor)

Error:

TypeError: Argument 1 passed to Drupal\Core\Form\SubformState::createForSubform() must be of the type array, null given, called in /Applications/MAMP/htdocs/drupal9/core/modules/editor/editor.module on line 251 in /Applications/MAMP/htdocs/drupal9/core/lib/Drupal/Core/Form/SubformState.php on line 56 #0 /Applications/MAMP/htdocs/drupal9/core/modules/editor/editor.module(251): Drupal\Core\Form\SubformState::createForSubform(NULL, Array, Object(Drupal\Core\Form\FormState))
#1 [internal function]: editor_form_filter_admin_format_submit(Array, Object(Drupal\Core\Form\FormState))
#2 /Applications/MAMP/htdocs/drupal9/core/lib/Drupal/Core/Form/FormSubmitter.php(113): call_user_func_array('editor_form_fil...', Array)
#3 /Applications/MAMP/htdocs/drupal9/core/lib/Drupal/Core/Form/FormSubmitter.php(51): Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object(Drupal\Core\Form\FormState))
...

I can confirm the following steps produce the same error on the latest 9.2.x-dev branch:

- Go to /admin/config/content/formats/manage/full_html
- Change the drop-down Text editor from CKEditor to None
- Press button Save configuration
- CLUNK
TypeError: Argument 1 passed to Drupal\Core\Form\SubformState::createForSubform() must be of the type array, null given, called in D:\htdocs\drupal\core\modules\editor\editor.module on line 251 in Drupal\Core\Form\SubformState::createForSubform() (line 56 of D:\htdocs\drupal\core\lib\Drupal\Core\Form\SubformState.php)

Bumping version to 9.2.x-dev (looks like this is going to be a backport-party when we got a working patch...)
Assigning to myself to create a test that fails without the patch and passes when it's applied

Let's see what TestBot has to say about these patches.

Ok, so now we have a failing test without the patch and the same test passes with the patch, so Needs Review seems in order.

Also:

We have confirmation that this bug also appears in 9.0.x and 8.9.x.
Basically that means it also appears in 9.1.x

I think this patch will smoothly apply to 9.1 and 9.0, for 8.9 we probably have to change the $this->submitForm to the 8.x equivalent $this->drupalPostForm

I like it.

As expected argument_one_must_be_an_array-3136406-22.patch applies cleanly on 9.0.x, 9.1.x and 9.2.x.

Looks like 8.9.x just has a few lines offset, but no code changes are needed.
Let's see if that theory is correct with the attached patch.

TLDR;

9.2.x, 9.1.x, 9.0.x: argument_one_must_be_an_array-3136406-22.patch
8.9.x: argument_one_must_be_an_array-3136406-d89-25.patch

Removing needs tests tag because there is test.

I manually tested this locally before and after the patch and confirmed both the bug and that this fixes it.

We also have test coverage for the bug.

I also verified that we could switch back to an editor, and this worked too.

As this is a bug fix, non disruptive and critical - backported to 9.1.x

Leaving at 9.0.x for possible backport there too.

I think this should go in 8.9.x as well as 9.0.x too

Backported to 9.0.x and 8.9.x

Thanks all