Problem/Motivation

In #3020385: Symfony 3 and Symfony ^4.2 JsonEncode constructors are incompatible we introduced a compatibility layer to \Drupal\serialization\Encoder\JsonEncoder to allow it to work with both Symfony 3 and Symfony 4. Now Symfony 3 is no longer used in Drupal 9 we can remove this compatibility layer again.

Proposed resolution

Remove the compatibility layer.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3135304.patch2.71 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3135304.patch2.71 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Parent issue: » #3136002: [meta] Remove compatibility shims for Symfony 4.3 and earlier
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Reviewed & tested by the community

Looks great and thanks for keeping track of these.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Committed d02bccb and pushed to 9.1.x. Thanks!

  • alexpott committed d02bccb on 9.1.x 
    Issue #3135304 by longwave: Remove Symfony 3 compatibility layer from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.