Hello all, it’s time for the weekly migration initiative meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to here:
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? State your name and your favorite thing about @Gábor Hojtsy (he/him)

webchick Ha! :smile: webchick and I don't think I could pick a favourite, but up there is that he's always concerned with how to boost OTHER people to be awesome!
mikelutz I think you essentially took mine, lol.
benjifisher Benji Fisher. Today, my favorite thing about @Gábor Hojtsy (he/him) is that he committed #3102724: Improve usability of core compatibility ranges on available updates report!
webchick I have more if you want to steal them. :wink:
damienmckenna Damien.
alison Alison here! -- I don't know him well, but I like his care for documentation :slightly_smiling_face: (edited)
heddn heddn, his quiet and confident manner.
Gábor Hojtsy (he/him) Gábor Hojtsy, humbled

1️⃣ What do we need to talk about? We’ll triage the Core Migration NR queue as usual, What else?

mikelutz We had a very productive week last week and cleaned the queue up pretty well, only 5 issues today.
benjifisher #3093652: Make migrate_upgrade compatible with Drush 10.
benjifisher What about #3114974: \Drupal\migrate\Plugin\MigrateDestinationInterface::fields() $migration argument is deprecated?
benjifisher @mikelutz ^
mikelutz Thanks, @benjifisher For whatever reason I was filtered on 8.x issues.

2️⃣ Derive block migration per theme and per block plugin type (edited) 

mikelutz #3115938: Derive block migration per theme and per block plugin type
mikelutz For reasons similar to what we stated on #3097336: Improve the DX for migrating content entities: view modes, fields, formatters, widgets etc should be migrated per entity type + bundle I think this issue should be moved to migrate_upgrade
webchick It is within that same class of issues.
webchick This class of issues seems to be stuck on justification for splitting things up in order to minimize troubleshooting surface area. We seem to be at an impasse with that, and I'm curious if there are specific questions I/we could be answering that could help move things along?
webchick Or, if it's better for us to create our own contrib project for this, OR... etc. :slightly_smiling_face:
heddn I think we should incubate in contrib. Maybe even provide a flag to the generator to turn on the feature...
mikelutz I’m not fundamentally opposed to it, provided it’s done in an opt-in way for developers, I just think contrib is the place to do that. If it doesn’t make sense in migrate_upgrade and needs to be its own module, then so be it.
webchick Well that's where I'm slightly confused, because it was originally moved to migrate_upgrade but even there we seem to be getting pushback due to maintenance concerns. (Not to say those concerns are invalid, just to say we—or at least I—am not sure what to do now to move things forward.)
heddn upgrade is fine. no more splintering then necessary. however, we need to convert the existing methods into contrib-land, rather then hoping it will land in core :disappointed:
webchick Then my only question is about xjm's comment... she seems to state there that having clear dependency info, even in core, would be useful, but it seems you disagree with that.
heddn the last few comments have been still based off core, not contrib.
webchick Ahhh, gotcha.
heddn so, rebase on contrib. and if we have dependency issues in core, fix them in core :slightly_smiling_face:

3️⃣ Migrate d7 menu translation

mikelutz #3112249: Migrate d7 menu translation

4️⃣ Migrate empty, and link field

mikelutz #3110064: Migrate empty, <nolink> and <none> link field
mikelutz Set to NW for tests

5️⃣ Migration of menu links does not set the appropriate bundle

mikelutz #3070495: Migration of menu links does not set the appropriate bundle

6️⃣ Move actions migrations and tests to system module

mikelutz #3067299: Move actions migrations and tests to system module
mikelutz Sent back to NW because it deprecates while we are not in a deprecation window.

7️⃣ Migrate D6 and D7 node revision translations to D8

mikelutz #2746541: Migrate D6 and D7 node revision translations to D8
mikelutz Oh wait, that is RTBC. :stuck_out_tongue:
mikelutz I’ve just been linking it for so long now it’s habit…
webchick It is, and it's been escalated to core committer slack as of this morning :slightly_smiling_face: I'm not 100% sure who can commit it.
webchick But we will figure it out!
Gábor Hojtsy (he/him) I tried to shop it around
mikelutz Lee will do it, he’s fearless, lol.
quietone Woohoo!
mikelutz Look, here come the NZ/Aussies now.. :stuck_out_tongue:

8️⃣ [Contrib] [migrate_upgrade] Make migrate_upgrade compatible with Drush 10.

mikelutz #3093652: Make migrate_upgrade compatible with Drush 10.
webchick This one scares the daylight out of me because it is a couple dozen comments long and apparently Drush 9 support ends in May. :stuck_out_tongue:
benjifisher I looked into it yesterday and left a comment on the issue. Does anyone here have experience with Drush testing traits?
webchick Yeah, that was some EPIC level debugging, sir! \m/
heddn I'll pick it up again one of these days. I'm not too worried just yet
heddn I've done a fair bit w/ drush testing at this point. but the tricky thing is wiring into the db and credentials
benjifisher Do we need a functional test here? We could add to the existing kernel test instead. (edited)
heddn well, kernel doesn't actually do much of anything w/ drush :disappointed:
heddn i switched to using functional on migrate tools for just that reason. it wasn't catching enough testing regressions without the functional
benjifisher Short version of my comment on the issue: I think that running the Drush command from the testing trait restarts PHP, losing static variables. In particular, calls to Database::addConnectionInfo() are ineffective.

9️⃣ \Drupal\migrate\Plugin\MigrateDestinationInterface::fields() $migration argument is deprecated

mikelutz #3114974: \Drupal\migrate\Plugin\MigrateDestinationInterface::fields() $migration argument is deprecated
mikelutz RTBCed this, but tagged for RM review

🔟 Deprecate Migration::set()

mikelutz #2796755: [PP-1] Deprecate Migration::set()
mikelutz Postponing this for 9.1.x

Participants:

webchick, mikelutz, benjifisher, damienmckenna, alison, heddn, Gábor Hojtsy (he/him), quietone

Comments

mikelutz created an issue. See original summary.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented

Why not add a link to https://www.drupal.org/project/issues/drupal?status=8&component=migratio... to the issue summary so that it is copied to the issues for all future meetings?

mikelutz credited webchick.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Issue summary: View changes
Related issues: +#3115938: Derive block migration per theme and per block plugin type, +#3110064: Migrate empty, <nolink> and <none> link field, +#3067299: Move actions migrations and tests to system module, +#2746541: Migrate D6 and D7 node revision translations to D8, +#3093652: Make migrate_upgrade compatible with Drush 10., +#3114974: \Drupal\migrate\Plugin\MigrateDestinationInterface::fields() $migration argument is deprecated, +#2796755: [PP-1] Deprecate Migration::set()

mikelutz credited DamienMcKenna.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented

mikelutz credited alisonjo315.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented

mikelutz credited heddn.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented

mikelutz credited Gábor Hojtsy.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented

mikelutz credited quietone.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.