Drupal 9 readiness meeting / 13 January 2020 [#3104659]

Meeting will happen in #d9readiness on drupal.slack.com.

Hello and welcome to this Drupal 9 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 9 upgrade of their sites are also welcome.
➤ Usually happens every other Monday at 19:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/node/3104659`
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

Gábor Hojtsy (he/him)	hi! Gábor Drupal 9 coordinator :slightly_smiling_face:
tedbow	:ocean:Ted, core contributor
timplunkett (he/him)	:wave::skin-tone-2: Tim, core contributor
TravisCarden	Travis Carden. Acquia. Core contributor. (edited)
heddn	heddn, migrate sub system maintainer
mradcliffe	Matthew, :soon: :moustache: . core contributor
Gábor Hojtsy (he/him)	cc @catch @xjm @mikelutz @berdir @mglaman @shaal @andypost in case you needed a ping :slightly_smiling_face:
shaal	Ofer Shaal, core contributor (Umami) + Drupal8rector :wave:
mikelutz	Here, but about to head into a meeting, so I may be in and out or commenting later.
mglaman	:wave: Matt
greg.1.anderson	@greg.1.anderson Just lurking today
berdir	Berdir, core and contrib maintainer
catch	Nat, core committer.

1️⃣ Do you have suggested topics you are looking to discuss (other than those posted in the issue)? Post in this thread and we’ll open threads for them as appropriate.

2️⃣ Discuss whether we should try to increase 9.0's minimum PHP version requirement to 7.3 or 7.4 once initial dependency updates are complete

Gábor Hojtsy (he/him)	see #2917655: [9.4.x only] Drop official PHP 7.3 support in Drupal 9.4
Gábor Hojtsy (he/him)	the above is a policy discussion while @heddn just opened #3106075: Bump minimum PHP for Drupal 9 to PHP 7.3 today
mglaman	Given when D9 will land, I think 7.3 is a smart choice. I've been running D8 on 7.3 for a while now on P.sh
mradcliffe	What's the impact on policy option 1 and 2 for the automated updates initiative?
heddn	@mradcliffe I doubt there is any. but it seems there's a question behind that question
mradcliffe	I agree. 7.3 seems like the most feasible for May, but 7.4 would be pretty nice.
heddn	@mradcliffe there's a link to a hosting support table on the meta parent. in there it shows that 7.3 is pretty well supported by hosts. but that 7.4 is still pretty far behind
heddn	#2938725: [tracking issue] Track hosting provider support for PHP 7 so you don't have to hunt for it
andypost	The only question here is which minimal 7.3 version to use
mradcliffe	@heddn, probably. I'm thinking about what the UX is for users on hosts that would try to update to a minor Drupal 9 release, but then wouldn't because of the php policy decision in #2917655.
heddn	@andypost I did some hunting in symfony 5 to see if it uses a point release. I couldn't find any, nor have I heard of any specific blacklisted point releases for 7.3
mglaman	I think, also, software needs to dictate what hosting providers support. We're back by the new ggressive release schedule
mradcliffe	Has the policy been decided in #2917655? The issue summary isn't clear that it has.
heddn	@mradcliffe I went off @catch's comment about opening an issue for 7.3. I think the data speaks for 7.3 and we should still figure out an official long term policy. but I could be over eager too :slightly_smiling_face:
berdir	as of now, we don't support PHP 7.4 yet, so going for that now seems very early. but +1 to PHP 7.3
mradcliffe	Right, 7.3. I'm more thinking about the policy question.
heddn	https://twitter.com/lucashedding/status/1216801312857346050
mikelutz	The developer in me definitely wants the latest php the rms will agree to. The higher the version we start with, the longer before we need to worry about multiple phpunit versions.
Gábor Hojtsy (he/him)	Also the later the pain of upping the required PHP version under Drupal 9 users.
Gábor Hojtsy (he/him)	which will likely inevitably happen for PHP 7.4 to PHP 8 at least according to what we current know
heddn	Do we need to open a infrastructure issue to bump the default PHP version on 9x before 3106075 lands? it came green, so that seems like the next thing is to bump defaults before it can RTBC
Gábor Hojtsy (he/him)	@heddn the default testing version?
Gábor Hojtsy (he/him)	I think @catch or @xjm can update it alongside committing :slightly_smiling_face:
heddn	@Gábor Hojtsy (he/him) yes. 7.2 was the default in #5 when I uploaded the patch. I don't think we want every patch to fall on its face the second that patch lands
andypost	Also would be great to check which version in 7.4-dev now
Gábor Hojtsy (he/him)	@heddn I would assume that would be part of committing it, it should not be raised without this being committed, as then we would commit stuff that may not work on 7.2 anymore, but once this lands, it should be set to 7.3
catch	Yeah that's a UI setting on the d.o project so we can just change it.
heddn	updated IS to make that explicit
catch	given 7.3 seems uncontroversial I think we can commit that but then keep discussing 7.4 (and PHP 8....)
heddn	I'd suggest we give it a day or 2 to see if my tweet about blacklisted php 7.3 versions gets any responses
andypost	Otoh it could be updated later to some specific version, commiting early could help catch bugs early
heddn	sure, that seems fine as well.
berdir	one thing with PHP 7.3 is that afaik, e.g. ubuntu lts is still on 7.2, so that would make it harder for contributors/people trying out D9, e.g. during the upcoming sprint 20.04 will have (at least?) 7.3 then
mglaman	But isn't that always a problem?
catch	Next Ubuntu release is in April with PHP 7.3 it looks like https://wiki.ubuntu.com/EoanErmine/ReleaseNotes
Gábor Hojtsy (he/him)	people can also add PHP 7.3 on existing Ubuntu installs if they need to
catch	Yeah I don't think it's a problem.
mradcliffe	Also, the quicksprint environment uses PHP 7.3.
andypost	It's good for sprints to teach ppl to use docker or just install new versions (edited)
heddn	adding the apt repo and updating to php 7.3 seems like something folks should already be including in their body of knowledge. given the shorter timeframes for php support, if not now, then sometime they'll need to learn
heddn	or using docker (prefered)

3️⃣ Upgrade Status updates: new 8.x-2.x branch based on phpstan 0.12, now with twig deprecation checking support thanks to @lauriii :slightly_smiling_face:

Gábor Hojtsy (he/him)	well the phpstan 0.12 support is based on @mglaman’s prior work on phpstan-drupal :slightly_smiling_face:
Gábor Hojtsy (he/him)	also new on the 8.x-2.x branch is twig deprecation testing support :slightly_smiling_face: (edited)
Gábor Hojtsy (he/him)	this branch is currently alpha, but IMHO should soon progress to more stable
Gábor Hojtsy (he/him)	also @lauriii has been finding a bunch of interesting issues, resolving which will make it possible for example to run 2.x with php’s built in webserver even :slightly_smiling_face:
Gábor Hojtsy (he/him)	also @lauriii and @mglaman are looking to integrate deprecated library checking as well :slightly_smiling_face:
mglaman	yep! had a good call to discuss

4️⃣ New rector runner UI module called Upgrade Rector :boom:

Gábor Hojtsy (he/him)	https://www.drupal.org/project/upgrade_rector
Gábor Hojtsy (he/him)	https://www.drupal.org/files/project-images/UpgradeRector.png(95 kB)https://www.drupal.org/files/project-images/UpgradeRector.png
Gábor Hojtsy (he/him)	UI allows you to pick which project to run it on, reformats Rector output as valid patch to post in an issue :slightly_smiling_face:
Gábor Hojtsy (he/him)	unfortunately Upgrade Status and Upgrade Rector cannot run in the same environment due to conflicting dependencies ATM, but updating drupal8-rector to latest rector versions should solve that :fingerscrossed:
Gábor Hojtsy (he/him)	I believe @shaal is working on doing that update
Gábor Hojtsy (he/him)	@mxr576 also started a pull request about it at https://github.com/drupal8-rector/drupal8-rector/pull/37 (edited)
andypost	As I got it also could care about PHP version compatibility/fixes ...like 7.4 deprecations
shaal	I have a branch of WIP using the latest version of Rector (using phar). Now the additional work needed is to update Drupal8-rector with all API changes that happened since rector 0.4.2 (now at 0.6.9)
Gábor Hojtsy (he/him)	@andypost yeah it can help with that, I disabled those in Upgrade Rector for now to avoid the expected noise as I think there may be too many “nice to have” changes it wants to force on you, but maybe not :slightly_smiling_face:
shaal	https://github.com/palantirnet/drupal8-rector/tree/feature/rector-prefix
Gábor Hojtsy (he/him)	@andypost also I think we’ll need the updated rector version for that too (at least for PHP 7.4 support)
Gábor Hojtsy (he/him)	@shaal posted at https://github.com/drupal8-rector/drupal8-rector/pull/37#issuecomment-57... about that, good link :slightly_smiling_face:
shaal	So what works - latest version of Rector can be installed within a drupal websiteWhat doesn't work - drupal8rector itself

5️⃣ Plans for Drupal Global Contribution Weekend

Gábor Hojtsy (he/him)	At least @dasjo, @rafuel92 and @vijaycs85 reached out to me in some form about preparing for this weekend with Drupal 9 porting in mind :slightly_smiling_face:
Gábor Hojtsy (he/him)	I updated http://hojtsy.hu/blog/2019-may-03/present-your-own-state-drupal-9-sessio... last week in prep for that
Gábor Hojtsy (he/him)	I also worked on a quickstart guide that still needs some refinements but got some good feedback from @lauriii, @webchick et. al.
Gábor Hojtsy (he/him)	PDF Drupal9ContributionCheatSheet.pdf59 kB PDF — Click to view
Gábor Hojtsy (he/him)	I’d like to post this on my blog so people have an easy reference, at least better than slack thread posts :smile: (edited)
Gábor Hojtsy (he/him)	any better ways we can help Drupal 9 porting contribution in 2 weeks?
mglaman	I don't know if I'll be findin somewhere to go, but my plan is to hack on phpstan-drupal and drupal-check
andypost	@Gábor Hojtsy (he/him) is this pdf shared publicly?
Gábor Hojtsy (he/him)	@andypost well now above :smile: but https://drupal.slack.com/archives/CDDD98AMN/p1578943372073900?thread_ts=...
andypost	Hm, can't download now, will check later on laptop

6️⃣ Drupal 8 upgrade path criticals https://www.drupal.org/project/issues/search/drupal?project_issue_follow...

Gábor Hojtsy (he/him)	all of these block Drupal 9 beta :slightly_smiling_face: anyone interested in helping with them? (edited)
Gábor Hojtsy (he/him)	I believe @timplunkett (he/him) is looking at these, anyone wanna work with him? :slightly_smiling_face:
berdir	I'm trying to help a bit with the path_alias stuff, but since fixing subpathauto, we haven't found any reproducible issues
Gábor Hojtsy (he/him)	@berdir well that is good news :slightly_smiling_face:
berdir	yes and no, lots of people had really weird errors. but I suppose lots of is relative, usage stats of 8.8 are picking up quite well I think and I assume most people didn't have issues or found workarounds
berdir	will see about having a look at some of the other issues too, the taxonomy one is something that I should be able to fix, had similar issues once

7️⃣ Removing Drupal 8 updates up to and including 88* (edited)

Gábor Hojtsy (he/him)	#3087644: Remove Drupal 8 updates up to and including 88**
Gábor Hojtsy (he/him)	This in itself directly blocks beta but also indirectly blocks removing a bunch of @deprecated APIs.
Gábor Hojtsy (he/him)	#3102059: Make tests of the update system use UpdatePathTestTrait instead of UpdatePathTestBase was one of the dependencies of it and landed earlier today
berdir	We currently have two sub-issues, but I'm not quite sure yet if that works. the only thing we can do partially is removing only the tests, we can't remove a part of the update functions (of modules installed in the default standard dump) or it would fail
Gábor Hojtsy (he/him)	#3104974: Remove Drupal 8 updates from system.module
berdir	and I think the latest comment from @catch also suggests to do one big patch for the removal, need to catch up on what he said there and in his previous comment
catch	So what I am thinking is 1. Move the update system tests to a sub-namespace UpdateSystem) 2. try another mega-patch.
catch	The one thing that concerns me about a mega-patch this time is any updates added to 8.9.x since 8.8.0 was released.
berdir	I'll have a look at that.
berdir	I think another issue could do what alexpott suggested and I've created an issue for a while ago.. have a filled dump including all the new stable (and beta?) modules like media/media_library/layout_builder/workspaces and so on.. that would make writing update tests for these modules a lot easier. the fixture that @jibran created to have a workspaces test against 8.8.0 is insane..
berdir	would be awkward if whe'd remove one of these modules again :stuck_out_tongue: (edited)
catch	Yes we should add that as well. That workspaces fixture should be no-longer needed due to the workspaces test refactor in the issue I just committed though iirc. But we're going to need to quickly regardless.
berdir	yes, we don't need it anymore now, but as soon as we add another update function to it, we'd need to bring it back

8️⃣ Cleanup followups after rebuild of bundled jQuery UI

Gábor Hojtsy (he/him)	Anyone interested in #3098489: Remove deprecated jQuery UI library definitions
Gábor Hojtsy (he/him)	hopefully @zrpnr can shed some light on why the second one is still postponed?!
zrpnr	that issue was created before 3087685 landed, I just commented to set it to "active"
Gábor Hojtsy (he/him)	Thanks @zrpnr
lendude	Started wrapping my head around the first one earlier yesterday, will see if I can find some time to get that running at least

9️⃣ Zend Framework became the Laminas framework (https://framework.zend.com/blog/2019-04-17-announcing-laminas.html), we need to act accordingly (edited)

Gábor Hojtsy (he/him)	#3104015: Replace ZendFramework/* dependencies with their Laminas equivalents
Gábor Hojtsy (he/him)	As far as I see @alexpott has some good suggestions here for general direction :slightly_smiling_face:
Gábor Hojtsy (he/him)	may require some upstream work though if comment 7 can be reproduced
catch	xjm asked for a dependency evaluation. I found their security policy but nothing else yet.

🔟 Stability of multilingual migrations

Gábor Hojtsy (he/him)	New direction on #3076447: Migrate D7 entity translation revision translations is that we are looking for code reviews and commit them to promote for testing
Gábor Hojtsy (he/him)	@alexpott and @mikelutz were going to look at these :slightly_smiling_face:
Gábor Hojtsy (he/him)	more eyes would be very welcome
mikelutz	I haven’t had a chance to do another review yet.
Gábor Hojtsy (he/him)	as we’ve not had success to find people in this problem space to prove it more, we’ll need to go by what we believe is right :slightly_smiling_face:
Gábor Hojtsy (he/him)	then :fingerscrossed: we get more testing once 8.9 becomes beta :slightly_smiling_face:
Gábor Hojtsy (he/him)	I am sure @quietone is happy to provide feedback to reviewers as well :slightly_smiling_face:
webchick	Given the bunches of path-related upgrade bugs we found post-release in 8.8 I'm not confident people test betas. :stuck_out_tongue: But one can always hope!
Gábor Hojtsy (he/him)	well at least this is a new capability some people need :smile:
Gábor Hojtsy (he/him)	or at least we think they need it :smile: