Add a new recipe to Umami demo - Chicken souvlaki and couscous

Thank you, it looks delicious!

I used grammarly.com to find spelling mistakes and (american?) grammar suggestions.
I updated the CSV and the instruction html file accordingly.

Umami comes with this responsive image style - Large 3:2 2x (1536x1024)
So we'll probably need higher resolution of the original image for this recipe.
(if you view this image at 100% you will see how pixelerated it got by this image style)

What's Umami's writing rules regarding using cm. vs inches? can/should we use both?
What's Umami's writing rules regarding using measurements in cups (the american way) vs grams? can/should we use both?

Yum!

Re. #4: The writing style was covered in an early issue, but it doesn't appear to answer all the questions about units.
I don't think we should mix imperial and metric units, but I don't know what the outcome was on which one to use. (At least, not from the proposed resolution there; it might be worth reviewing all the comments again.)

The cups (volume) vs. grams (mass) for measuring powders seems weird to many British readers, but at least it's a well known Americanism. I think it's becoming easier to purchase measuring cups over here in the last decade. We settled on U.S. English for the writing style, so I think we'd probably go for cups as the measurement style?

...hmmm
Should we add a little javascript code that converts on the fly imperial and metric units?
(can even save a cookie according to user's last chosen preference)

This looks delicious and the patch looks splendid as well.

I'm going to mark this as RTBC and then we can look at VIDEO IN MEDIA!!! That will be exciting!

Thanks for working on this @kjay @shaal @andrewmacpherson

The recipe looks great! Looking forward to trying it someday myself 😋

I noticed this adds English text and link to the recipe in English to the front page on the Spanish translation. We should open another issue to exclude nodes that are not translated from the front page list. We probably should either block this issue on that new issue or add Spanish translation.

I noticed that, but presumed it was done in this way to showcase what happens when a recipe is not translated.

I'm happy for us to leave it like this, OR for us to create a follow-up issue and postpone this until we merge the follow-up.

I think this behavior is intentional, by another issue #3068721: Umami demo views should display items from all languages
We can have a larger discussion, what kind of multilingual features we would like to demo, because there are so many options, and every websites might have different reasons to display all content vs only the selected language.

Let's put this back to RTBC in that case.

In my opinion that could potentially make sense in some other use case, but it seems strange to have one of the recipes highlighted on the frontpage displayed in an incorrect language. Since it seems like I was having an opposing argument on #3068721: Umami demo views should display items from all languages too, I asked the product managers to weigh in on this to make a decision.

It would be great IMHO to translate the article, rather than attempt to come up with some elaborate multilingual strategy. I don't think that is necessarily a show-stopper for committing this patch though as the patch also opens the door for inclusion of the video, if I understand that right?

@Gábor Hojtsy yes, that's correct. This patch is our first that will use video.

We can easily create a follow-up to translate the recipe then.

Shall we commit this so?

It sounds like we should at least have a followup for the translation?

We discussed in the past, the great opportunity of introducing some content that did not get translated, as it is a reality in multilingual websites, and allow demonstrate Drupal's behavior around these cases.

But that might surface some interesting new features we might consider adding to Drupal core, to provide a better support for multilingual websites.

@berdir has many ideas around that :)

The latest patch here, #7, is being tested on Drupal 8.9.x. It needs to be updated for 9.3.x. Adding tag for a reroll. Sorry folks.

If there is a plan to do a real multilingual demo, then it would be great to see that. I think it would probably have been possible to find volunteers to translate the recipe in the past month or so either here or in a followup. (Or alternately formulate a plan on how Umami pivots to a fully multilingual demo, which I think would be significantly harder to achieve).

Would be great to move forward with this, so we can get the video demo in :)

Removing Needs Reroll tag as patch #7 apply on Drupal 9.3.x.

Needs works for CSpell fails in the following files:
core/profiles/demo_umami/modules/demo_umami_content/default_content/LICENCE.txt
core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/media/image.csv
core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/node/recipe.csv

@kjay, I left previous comments #11and #19 regarding (NOT getting) translation for this content.
I still believe that having some content in one language and not the other, will bring a whole new level of showcasing what's possible with Drupal multilingual features.
What do you think?

Or the MR should be updated for 10.1

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 200, following Review a patch or merge require as a guide.

Tested this out with a fresh drupal install with the umami theme.

I do see the new recipe Chicken souvlaki (looks delicious)

Sending this back to NW though for an issue summary update. Not entirely clear what is being included.

This recipe is also being used for a video that we have both produced to help demonstrate core Media in Umami

Does that mean there should be a video I see the next sentence said this is the first step. Is there a follow up for the video?

Would be super helpful to use the standard template about what exactly is being proposed in this ticket. Helps the committer later.

Hiding old patches and MRs for clarity.

The proposal is pretty simple -- add this recipe to the default content that ships with the Umami demo profile. I don't think there's any dearth of information missing from the IS:
https://www.drupal.org/docs/umami-drupal-demonstration-installation-profile

Code review and manual testing are the next steps.

The original purpose of adding this recipe to Umami, was to demonstrate Drupal's ability to display a video.
A special video was produced by @kjay. I watched the draft version of that video, which was awesome! I don't think @kjay published the finished version of the video.

@shaal you are correct about the video.

It's a pity we don't have this patch merged yet, it was such as cool feature to demo and the video looked great. Let's get this closed out and merged as soon as we can.

@kjay can you remember where the video is/was and how we can get it into this patch?