Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Once the roadmap for the Workspaces is complete, we'll need sign-offs on the final state as well as a patch to actually mark the module stable.
Proposed resolution
- Add to or update
MAINTAINERS.txt
entry for the module as needed. - Remove the experimental module designation from
workspaces.info.yml
. - Remove the
@internal
from Workspaces APIs intended to be public. - Replace the
@internal
text for APIs that are intended to remain internal even after the module is stable with explanations of why the code in question is internal (e.g., specific categories from https://www.drupal.org/core/d8-bc-policy, etc.) - Copy CSS and templates to Stable or Classy as appropriate.
Remaining tasks
Release management checklist
- Security
- Data integrity
- Impact on stable functionality
Integrations
- All revisionable and publishable entity types (Node, Taxonomy term, Custom menu link, Media, Path alias)
- Content Moderation
- REST and JSON:API
- Multilingual functionality
- Other areas?
- Maintenance and technical debt
- Active maintainers listed with their agreement to maintainer roles documented
- Issue queue review
- API definition and BC policy
- Core gates
- Usability
- Accessibility
- Testing
- Documentation
- API documentation and definitition
- Module name and description
hook_help()
- Handbook page
- Performance
Release notes snippet
Workspaces was added as an experimental module to Drupal core in 2018. Based on uses in real scenarios, all outstanding stability requirements were resolved, and workspaces is now a stable module in Drupal 10.3.0!
Comment | File | Size | Author |
---|
Issue fork drupal-3088643
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3088643-mark-workspaces-stable changes, plain diff MR !7193
Comments
Comment #2
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedLet's start with a small patch :)
Comment #4
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedMost of the test fails are fixed in #3088870: Add missing REST and JSON:API test coverage for the workspace entity type, so here we need to copy the css to Stable in order to fix the last failing test.
The combined patch includes the patch from comment #7 in the issue mentioned above.
Comment #7
Gábor HojtsyUpdated how this is blocked as per @amateescu.
Comment #8
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedWondering if #3132022: Content moderation check does not take into account entity IDs being used by two content entities is a candidate for "WI critical", even if it's technically within an already stable module.
Comment #9
andypostComment #15
amateescu CreditAttribution: amateescu for Tag1 Consulting commentedNow that the parent roadmap issue has only one "must-have" issue left, I think it's time to open the review process from core maintainers for this one :)
Comment #16
catchI've gone through the entire workspaces queue to look for any hidden blockers as well as the roadmap meta.
#2968165: Finish the Views integration means that some listing queries aren't perfectly previewed in workspaces (i.e. if you order by a field that is changed in the current workspace the order is still based on the published revisions), I think this is fine as a should-have given this module can potentially replace the internals of content_moderation and maybe entity form previews in the future, neither of which handle full site preview at all. It won't require any massive refactoring to fix, just applying some existing query alter patterns to more places. Actual entity content is already correctly handled everywhere, it's just ordering and group by that aren't there yet.
#3419548: Workspace switcher block does not check access looked like potential security hardening/protection against mis-configuration, it's already fixed this week.
#3096017: Finalize the Workspaces UI doesn't have lots of activity on the issue itself, but @amateescu confirmed the child issues are up-to-date and most of them are completed. There is a navigation initiative issue looking at workspaces, so it may be better to revisit again as part of that too.
There are 43 open issues in total, fairly even split between bugs and tasks. Everything else is in normal bug/task/feature request territory and more likely to be fixed if workspaces picks up more users once it's stable.
I've been reviewing this initiative since it started and also worked on its Drupal 7 predecessors cps and drafty, so confident removing both the release manager and framework manager review tags here.
Comment #17
smustgrave CreditAttribution: smustgrave at Mobomo commentedBased on the roadmap seems #3300639: Improve and add explicit test coverage for the workspace conflict validator and #3000749: Layout builder overrides on a single content item not allowed in a workspace are needed.
Comment #18
catch@smustgrave yes that's right, #16 assumes those both land before this issue is RTBCed - one just did.
Comment #19
smustgrave CreditAttribution: smustgrave at Mobomo commentedSweet! Pinged @Tim.plunkett about the layout builder as it may be above my head to make that call.
Comment #20
Gábor HojtsyNo concerns from core product manager side, removing tag :) Would be great to be able to suggest this amazing feature finally! Further features could be added later to it and/or as contrib modules.
Comment #21
smustgrave CreditAttribution: smustgrave at Mobomo commentedAmazing to see this so close! I'm postponing as I've left a comment on #3000749: Layout builder overrides on a single content item not allowed in a workspace if that does need an upgrade path it'll need more work.
Comment #22
catchThe last blocker is in, I think this is ready!
Comment #23
Gábor HojtsyAdded a brief release note snippet. I am not aware of things users need to do in order to "move" to the stable module, if they are already using workspaces.
Comment #24
Fabianx CreditAttribution: Fabianx at Tag1 Consulting commentedRTBC + 1 - Been using workspaces together with wse in production since a few years on several Enterprise sites.
Comment #27
longwaveGreat work, nice to see this finally over the line.
Committed and pushed 42ddeb3337 to 11.x and 27eda1233b to 10.3.x. Thanks!
Comment #29
matthieuscarset CreditAttribution: matthieuscarset as a volunteer commented🙌 Congratulations, what an acheivement! 🙌
Could we have more details about this?
I am very curious about realword Drupal project using workspaces.