Problem/Motivation

Once the roadmap for the Workspaces is complete, we'll need sign-offs on the final state as well as a patch to actually mark the module stable.

Proposed resolution

  • Add to or update MAINTAINERS.txt entry for the module as needed.
  • Remove the experimental module designation from workspaces.info.yml.
  • Remove the @internal from Workspaces APIs intended to be public.
  • Replace the @internal text for APIs that are intended to remain internal even after the module is stable with explanations of why the code in question is internal (e.g., specific categories from https://www.drupal.org/core/d8-bc-policy, etc.)
  • Copy CSS and templates to Stable or Classy as appropriate.

Remaining tasks

Release management checklist

  1. Security
  2. Data integrity
  3. Impact on stable functionality

    Integrations

    • All revisionable and publishable entity types (Node, Taxonomy term, Custom menu link, Media, Path alias)
    • Content Moderation
    • REST and JSON:API
    • Multilingual functionality
    • Other areas?
  4. Maintenance and technical debt
    • Active maintainers listed with their agreement to maintainer roles documented
    • Issue queue review
  5. API definition and BC policy
  6. Core gates
    • Usability
    • Accessibility
    • Testing
    • Documentation
      • API documentation and definitition
      • Module name and description
      • hook_help()
      • Handbook page
    • Performance

Release notes snippet

Workspaces was added as an experimental module to Drupal core in 2018. Based on uses in real scenarios, all outstanding stability requirements were resolved, and workspaces is now a stable module in Drupal 10.3.0!

Issue fork drupal-3088643

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu created an issue. See original summary.

amateescu’s picture

Status: Active » Needs review
FileSize
888 bytes

Let's start with a small patch :)

Status: Needs review » Needs work

The last submitted patch, 2: 3088643.patch, failed testing. View results

amateescu’s picture

Status: Needs work » Needs review
FileSize
6.95 KB
39 KB
6.08 KB

Most of the test fails are fixed in #3088870: Add missing REST and JSON:API test coverage for the workspace entity type, so here we need to copy the css to Stable in order to fix the last failing test.

The combined patch includes the patch from comment #7 in the issue mentioned above.

The last submitted patch, 4: 3088643-4.patch, failed testing. View results

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Gábor Hojtsy’s picture

Issue summary: View changes
Status: Needs review » Postponed

Updated how this is blocked as per @amateescu.

Sam152’s picture

Wondering if #3132022: Content moderation check does not take into account entity IDs being used by two content entities is a candidate for "WI critical", even if it's technically within an already stable module.

andypost’s picture

Version: 8.9.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

amateescu’s picture

Issue summary: View changes
Status: Postponed » Needs review

Now that the parent roadmap issue has only one "must-have" issue left, I think it's time to open the review process from core maintainers for this one :)

catch’s picture

I've gone through the entire workspaces queue to look for any hidden blockers as well as the roadmap meta.

#2968165: Finish the Views integration means that some listing queries aren't perfectly previewed in workspaces (i.e. if you order by a field that is changed in the current workspace the order is still based on the published revisions), I think this is fine as a should-have given this module can potentially replace the internals of content_moderation and maybe entity form previews in the future, neither of which handle full site preview at all. It won't require any massive refactoring to fix, just applying some existing query alter patterns to more places. Actual entity content is already correctly handled everywhere, it's just ordering and group by that aren't there yet.

#3419548: Workspace switcher block does not check access looked like potential security hardening/protection against mis-configuration, it's already fixed this week.

#3096017: Finalize the Workspaces UI doesn't have lots of activity on the issue itself, but @amateescu confirmed the child issues are up-to-date and most of them are completed. There is a navigation initiative issue looking at workspaces, so it may be better to revisit again as part of that too.

There are 43 open issues in total, fairly even split between bugs and tasks. Everything else is in normal bug/task/feature request territory and more likely to be fixed if workspaces picks up more users once it's stable.

I've been reviewing this initiative since it started and also worked on its Drupal 7 predecessors cps and drafty, so confident removing both the release manager and framework manager review tags here.

catch’s picture

@smustgrave yes that's right, #16 assumes those both land before this issue is RTBCed - one just did.

smustgrave’s picture

Sweet! Pinged @Tim.plunkett about the layout builder as it may be above my head to make that call.

Gábor Hojtsy’s picture

No concerns from core product manager side, removing tag :) Would be great to be able to suggest this amazing feature finally! Further features could be added later to it and/or as contrib modules.

smustgrave’s picture

Status: Needs review » Postponed

Amazing to see this so close! I'm postponing as I've left a comment on #3000749: Layout builder overrides on a single content item not allowed in a workspace if that does need an upgrade path it'll need more work.

catch’s picture

Status: Postponed » Reviewed & tested by the community
Issue tags: +10.3.0 release highlights

The last blocker is in, I think this is ready!

Gábor Hojtsy’s picture

Issue summary: View changes
Issue tags: -Needs release note

Added a brief release note snippet. I am not aware of things users need to do in order to "move" to the stable module, if they are already using workspaces.

Fabianx’s picture

RTBC + 1 - Been using workspaces together with wse in production since a few years on several Enterprise sites.

  • longwave committed 27eda123 on 10.3.x
    Issue #3088643 by amateescu, Gábor Hojtsy, catch, smustgrave: Mark...

  • longwave committed 42ddeb33 on 11.x
    Issue #3088643 by amateescu, Gábor Hojtsy, catch, smustgrave: Mark...
longwave’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Great work, nice to see this finally over the line.

Committed and pushed 42ddeb3337 to 11.x and 27eda1233b to 10.3.x. Thanks!

matthieuscarset’s picture

🙌 Congratulations, what an acheivement! 🙌

Based on uses in real scenarios

Could we have more details about this?
I am very curious about realword Drupal project using workspaces.