_drupal_build_css_path() is being called with first parameter equal to NULL, but then it is used as an array.

$path = $_base . $matches[1];

This causes a notice, in PHP 7.4.

Trying to use values of type null, bool, int, float or resource as an array (such as $null["key"]) will now generate a notice.

CommentFileSizeAuthor
#6 drupal-fix-accessing-NULL-as-array-3084953-10.patch451 bytesapaderno
#3 drupal-drupal_build_css_path_null_as_array-3084953-3.patch832 bytesTaran2L
#2 drupal-drupal_build_css_path_null_as_array-3084953-2.patch898 bytesTaran2L
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Taran2L created an issue. See original summary.

Taran2L’s picture

Taran2L
Primary language Ukrainian
Location Lviv
CreditAttribution: Taran2L at Lemberg Solutions commented
Status: Active » Needs review
FileSize
drupal-drupal_build_css_path_null_as_array-3084953-2.patch898 bytes
Taran2L’s picture

Taran2L
Primary language Ukrainian
Location Lviv
CreditAttribution: Taran2L at Lemberg Solutions commented
FileSize
drupal-drupal_build_css_path_null_as_array-3084953-3.patch832 bytes
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno commented
Title: [PHP7.4] [D7] Trying to access array offset on value of type null in _drupal_build_css_path() » Trying to access array offset on value of type null in _drupal_build_css_path()
Issue tags: +PHP 7.4
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno commented
Issue summary: View changes
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno commented
FileSize
drupal-fix-accessing-NULL-as-array-3084953-10.patch451 bytes
hash6’s picture

hash6 CreditAttribution: hash6 at QED42 commented
Assigned: Unassigned » hash6
izmeez’s picture

izmeez CreditAttribution: izmeez commented

Patch in #6 applies and resolves warnings.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Assigned: hash6 » Unassigned
Status: Needs review » Needs work 
+++ b/includes/common.inc
@@ -3740,7 +3740,7 @@ function _drupal_build_css_path($matches, $base = NULL) {
+  $path = $_base . (isset($matches[1]) ? $matches[1]: '');

Minor nit-pick about this line is that I think according to the coding standards for operators we should have a space on either side of the : here:

$path = $_base . (isset($matches[1]) ? $matches[1] : '');

Otherwise the patch fixes the notice and preserves existing functionality, so once that's addressed this should be RTBC.

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +Pending Drupal 7 commit

@Steven Jones is right about the missing space, but we can fix #6 on commit.

This function doesn't exist in D8 so there's no fix there to backport.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx at Tag1 Consulting commented
Assigned: Unassigned » mcdruid

Approved, let's get this in and fix the typo on commit.

  • mcdruid committed 460ff5d on 7.x 
    Issue #3084953 by Taran2L, kiamlaluno: Trying to access array offset on...
mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid as a volunteer and at Acquia commented
Assigned: mcdruid » Unassigned
Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit

I fixed the whitespace on commit per #9.

Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.