Problem/Motivation

When normalization of links on a resource object creates cacheability information, that information is lost because it is not merged with the cacheability of the rest of the resource object normalization.

This was a small oversight in #2819335: Resource (entity) normalization should use partial caching.

Proposed resolution

Add the link normalization's cacheability information to the cached resource normalization.

Remaining tasks

Patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#5 3077287-9.patch4.44 KBgabesullice
#5 3077287-9--test-only.patch3.51 KBgabesullice
#2 3077287-2.patch945 bytesgabesullice

Comments

gabesullice created an issue. See original summary.

gabesullice’s picture

gabesullice
Primary language English
commented
StatusFileSize
new 3077287-2.patch945 bytes

One-line, simple fix.

gabesullice’s picture

gabesullice
Primary language English
commented
Title: Followup to #2819335: ResourceObjectNormalizationCacher loses link normalization cacheability » Followup to #2819335: ResourceObjectNormalizationCacher doesn't merge link normalization cacheability
gabesullice’s picture

gabesullice
Primary language English
commented
Status: Active » Needs review
gabesullice’s picture

gabesullice
Primary language English
commented
StatusFileSize
new 3077287-9--test-only.patch3.51 KB
new 3077287-9.patch4.44 KB

Test only patch is the interdiff.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

This looks good. @gabesullice please move to RTBC on my account when this comes back green.

The last submitted patch, 5: 3077287-9--test-only.patch, failed testing. View results

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Per #6.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 65491ce and pushed to 8.8.x. Thanks!

  • alexpott committed 65491ce on 8.8.x 
    Issue #3077287 by gabesullice: Followup to #2819335:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.