Views sort criteria and click-sort table headers do not work together as expected [#3059961]

Scenario:
* Have a table view with multiple columns
* All headers are click-sortable
* No default for click-sort headers
* Have multiple sort criteria, including some of the same fields as click-sortable headers

Options:
(1): "Override normal sorting if click sorting is used" disabled
(2): " Override normal sorting if click sorting is used" enabled

Expected behavior:
* Clicking a header will change sort precedence
* AND additional sort criteria will still be applied
* AND sort criteria in conflict with click-sort headers will be discarded

Observed behavior (1):
* Clicking a header takes precedence for sorting
* All sort criteria discarded completely

Observed behavior (2):
* Clicking a header does not impact sort precedence
* Clicking a header only changes sort order (ASC/DESC)

Example:
Events Listing
Headers: Company / Topic / Year
Sort criteria (before clicking table headers): Year (DESC), Company, Topic

If I click "Company", I expect the following ORDER BY to be applied:
Company, Year (DESC), Topic
Instead, what I see is:
option 1: Company
option 2: Year (DESC), Company, Topic

Comment	File	Size	Author
#10	Views-sort-criteria-3059961-10.patch	664 bytes	mdolnik
#10	11.x: PHP 8.2 & MySQL 8 29,826 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

6 June 2019 at 15:01

AaronBauman created an issue. See original summary.

Comment #2

6 June 2019 at 15:01

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #3

6 June 2019 at 15:01

Version:

8.9.x-dev

» 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #4

6 June 2019 at 15:01

Version:

9.1.x-dev

» 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Comment #5

6 June 2019 at 15:01

Version:

9.2.x-dev

» 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #6

6 June 2019 at 15:01

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #7

6 June 2019 at 15:01

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #8

6 June 2019 at 15:01

Version:

9.5.x-dev

» 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #9

6 June 2019 at 15:01

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #10

mdolnik CreditAttribution: mdolnik commented 19 July 2023 at 22:08

Status:

Active

» Needs review

File	Size
Views-sort-criteria-3059961-10.patch	664 bytes
11.x: PHP 8.2 & MySQL 8 29,826 pass

This patch modifies \Drupal\views\Plugin\views\style\Table::buildSortPost() to add existing sort filters after the click-sort has been processed.

This will ensure that either value of Override normal sorting if click sorting is used will keep existing sort filters, but the checking will ensure the click-sort is sorted first, while un-checking will ensure the click-sort is sorted last.