The workflows.api.php file contains the following sentence. (Emphasis is mine.)

For example, Content Moderation module uses its the Workflow Type Plugin to link workflows to entities.

An article should not be used before a possessive pronoun. The correct sentence should be the following one.

For example, the Content Moderation module uses its Workflow Type Plugin to link workflows to entities.

I would not capitalize the words in Workflow Type Plugin, but that is not a grammar mistake, at least.

CommentFileSizeAuthor
#8 fix-articles-3022551-8.patch1.09 KBapaderno
#5 3022551-5.patch1.09 KBoknate
#3 3022551-3.patch873 bytesgovind.maloo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kiamlaluno created an issue. See original summary.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Issue tags: +Novice

I would also add an article in Any module harnessing Workflows module must define a Workflow Type Plugin.
It should be Any module harnessing the Workflows module must define a Workflow Type Plugin.

govind.maloo’s picture

govind.maloo CreditAttribution: govind.maloo at Salsa Digital commented
Status: Active » Needs review
FileSize
3022551-3.patch873 bytes
oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented

Lines containing comments (including docblocks) must wrap as close to 80 characters as possible without going over.

This line is now 81 characters.
* Any module harnessing the Workflows module must define a Workflow Type Plugin.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
FileSize
3022551-5.patch1.09 KB

Here's an updated patch that fixes the line length.

mayaslatinek6@gmail.com’s picture

mayaslatinek6@gmail.com CreditAttribution: mayaslatinek6@gmail.com at Agiledrop - Your Trusted Drupal Teammates commented

Tested the patch provided by @oknate, the patch applies without problems, fixes the wrapping and article placement.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented

+ * plugin. This allows the module to tailor the workflow to its specific

There are two spaces after the period.
Then, it should be Workflow Type Plugin or workflow type plugin. Workflow Type plugin should not be used.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
FileSize
fix-articles-3022551-8.patch1.09 KB
RajeevChoudhary’s picture

RajeevChoudhary CreditAttribution: RajeevChoudhary as a volunteer and at Asentech LLC commented

Tested the patch provided by @kiamlaluno, the patch applies without problems, fixes the spaces after the period.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented

I would think that "Workflow Type" being the proper name of the plugin should be capitalized and that plugin, which is the not part of the name shouldn't be capitalized. I see it's used two other places including the "Plugin" capitalized, so I guess for consistency it's fine.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented

Actually, Workflow Type is not a proper noun, since it doesn't individuate a very specific plugin, or a single plugin. (It would individuate a class of plugins.) Making the example with projects, module is a common noun and Views (to mean the Views module) is a proper noun.
It's common in Drupal to use capitalized word in those cases, so I left them as they are. Differently, I would use Workflow plugin type, in the same way I would use form API instead of Form API I found in many Drupal documentation pages.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Kanopi Studios commented
Issue tags: +fldc19, +sfdug, +dcnj19

Tagging for upcoming contribution days.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Kanopi Studios commented
Issue tags: +midcamp2019

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

PapaGrande’s picture

PapaGrande
Primary language English
CreditAttribution: PapaGrande as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • catch committed 537e190 on 9.1.x 
    Issue #3022551 by kiamlaluno, oknate, govind.maloo: The definite article...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 537e190 and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.