\Drupal\Core\Menu\DefaultMenuLinkTreeManipulators::collectNodeLinks() incorrectly documents its return value in the docblock. Actually, this method returns nothing.

Drupal 8.6 and 8.5 have the same issue.

CommentFileSizeAuthor
#8 3018912-after_patch.png53.47 KBAbhijith S
#2 3018912-2.patch748 bytesmaximpodorov
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

maximpodorov created an issue. See original summary.

maximpodorov’s picture

maximpodorov CreditAttribution: maximpodorov commented
Status: Active » Needs review
FileSize
3018912-2.patch748 bytes
maximpodorov’s picture

maximpodorov CreditAttribution: maximpodorov commented
Issue summary: View changes

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Abhijith S’s picture

Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commented
FileSize
3018912-after_patch.png53.47 KB

Applied patch #2 on 9.2.x and it works fine.The documentation about return is removed in this patch.

after

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

The method return nothing and the patch removes the docblock part with the return values.
For me it is RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.2.x-dev » 9.1.x-dev
Category: Task » Bug report
Status: Reviewed & tested by the community » Fixed

Committed and pushed 36409a3156 to 9.2.x and 19916d48c7 to 9.1.x. Thanks!

Backported the issue to 9.1.x since it is a docs bugs fix.

Hi @Abhijith S thank you for looking into this issue.

Posting screenshots of your codebase or CLI does not advance the issue, since the automated testing infrastructure tells us whether the patch applies correctly.

So, I've removed the issue credit for that screenshot. In the future, you can get credit for issues by reading the issue to understand its purpose, and posting your review or testing of that purpose. Thank you!

  • alexpott committed 36409a3 on 9.2.x 
    Issue #3018912 by maximpodorov: DefaultMenuLinkTreeManipulators::...

  • alexpott committed 19916d4 on 9.1.x 
    Issue #3018912 by maximpodorov: DefaultMenuLinkTreeManipulators::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.