Problem/Motivation

views-admin.js viewsUi.RearrangeFilterHandler addGroupButton & removeGroupButtons variable jQuery selectors are too specific for all themes. The Bootstrap theme turns the inputs referenced in the selectors to buttons which breaks the add/remove group functionality.

Proposed resolution

Remove 'input' from the jQuery selectors.

CommentFileSizeAuthor
#8 update_rearrange_filter_handler_variable_selectors-3013216-8.patch1.36 KBanushrikumari
#2 update_rearrange_filter_handler_variable_selectors-3013216-1.patch1.68 KBaudioroger
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alloyroger created an issue. See original summary.

audioroger’s picture

audioroger CreditAttribution: audioroger at Alloy Magnetic commented
Status: Active » Needs review
FileSize
update_rearrange_filter_handler_variable_selectors-3013216-1.patch1.68 KB

Make patch to remove 'input' from selectors so add/remove group buttons work in Bootstrap and child themes.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 for Hook 42 commented
Version: 8.9.x-dev » 9.1.x-dev
Issue tags: +Needs reroll

If this is still relevant, it needs a reroll for 9.1.x.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 for Hook 42 commented
Status: Needs review » Needs work
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 for Hook 42 commented

Actually, jQuery is phased out from core so maybe this should be a "won't fix".

anushrikumari’s picture

anushrikumari CreditAttribution: anushrikumari at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
update_rearrange_filter_handler_variable_selectors-3013216-8.patch1.36 KB

Rerolled patch for 9.1.x

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at iO commented
Assigned: audioroger » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

We have test coverage for both these buttons in \Drupal\Tests\views_ui\FunctionalJavascript\FilterCriteriaTest, so the tests coming back green means we aren't breaking anything in a clean setup.

Looks good.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: update_rearrange_filter_handler_variable_selectors-3013216-8.patch, failed testing. View results

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Reviewed & tested by the community

Looks like the unrelated test failure, so back to RTBC as per comment #9.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 7274817 and pushed to 9.1.x. Thanks!

  • alexpott committed 7274817 on 9.1.x 
    Issue #3013216 by alloyroger, anushrikumari, Kristen Pol, Lendude:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.