Problem/Motivation

During the content translation/moderation integration in 8.5.x, two messages were added as warning messages, but they are actually not *warnings* IMHO.

See the screenshots in #3002571: Multiple warning messages when having untranslatable fields for one of them, when you have untranslatable fields. That's not a bug, not something you need to do anything about, that's just how it is.

The other one is on /translate, if you have pending translation revisions then you get a warning that you're not allowed to delete them:

This is a bit more warning-ish, it's an explanation why you can't delete a translation.

Proposed resolution

I'm not sure. A green/OK message is also strange?

Maybe show some other visual hint that there are fields that can't be changed/translated?

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#21 3004223_hide_untranslatable_fields_message_20230622.patch6.94 KBhudri
#19 3004334_hide_untranslatable_fields_warning_message_20230117.patch6.92 KBhudri
#11 3004334-11-hide-message-about-untranslatable-fields.patch5.32 KBhudri
#8 3004334-8-hide-message-about-untranslatable-fields.patch1.77 KBhudri
Selection_384.png37.54 KBberdir

Issue fork drupal-3004334

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Messages about hidden translatable fields and » Messages about hidden untranslatable fields and pending revisions

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

hudri’s picture

hudri
Primary language German
Location Austria
commented

I'm in favor of completely removing those messages. This message has no purpose, it is just stating a fact that is already more than just obvious - guess what, the field is not on screen, so you can't edit it ;-)

Hiding non-translatable is not default and was an intentional choice of the site builder. It was either a safety measure to prevent accidental translation, or a simple "reduce clutter" intension. But in both cases and this message is unwanted and does not help at all.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

hudri’s picture

hudri
Primary language German
Location Austria
commented
StatusFileSize
new 3004334-8-hide-message-about-untranslatable-fields.patch1.77 KB

Here is a simple patch that removes the "untranslatable fields hidden" message.

hudri’s picture

hudri
Primary language German
Location Austria
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: 3004334-8-hide-message-about-untranslatable-fields.patch, failed testing. View results

hudri’s picture

hudri
Primary language German
Location Austria
commented
StatusFileSize
new 3004334-11-hide-message-about-untranslatable-fields.patch5.32 KB

Removed functional test and kernel test regarding the warning message

hudri’s picture

hudri
Primary language German
Location Austria
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 11: 3004334-11-hide-message-about-untranslatable-fields.patch, failed testing. View results

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

hudri opened merge request !3258

hudri’s picture

hudri
Primary language German
Location Austria
commented
StatusFileSize
new 3004334_hide_untranslatable_fields_warning_message_20230117.patch6.92 KB

Here is a stale patchfile of the latest merge request, updated for drupal/core:^10

This patch file completely removes the warning message again.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

hudri’s picture

hudri
Primary language German
Location Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 3004223_hide_untranslatable_fields_message_20230622.patch6.94 KB

Stale patch file for tagged stable release v10.1.0 and for 11.x dev branch

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Issue summary needs updating as it was written for D8. And proposed solution wasn't finalized.

hudri closed merge request !3258

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.