[meta] Fix coding standards in core 7.x

This meta issue to tackle an issue in D7 core: coding standard. My goal here is to have a Drupal 7 that passes Drupal coder.

It's a huge task but we need to get over it. It's important to provide a good code quality:

• To help people understand how in-depth mechanisms,
• To provide better fixes,
• To make our IDE happy with a good auto-completion and type hinting.

However, to do this, we have to go through the D7 code from the bottom to the top, and we will probably see small stuff that could be fixed in a follow up (small perf improvements, obvious bugs, etc etc).
But warning, the goal here is not to alter the way D7 core is working, just focus on coding standard.

Things that we should not do:

• Change the PHP logic and syntax inside functions/methods

Things that we should avoid doing:

• Changing functions signatures, we do not have to change the Drupal API in here.
• Changing function return values

As @dawehner said:

In order to fix core coding standards in a maintainable way, all our coding standards issues should be done on a per-rule basis across all of core, rather than fixing standards in individual modules or files.

It means that we have to create a patch that fixes each of these sniffs individually, this is why this issue is a meta issue.

In order to speed up the process, I propose to use Github and specifically named branches instead of patches.

Ex, to fix the sniff Drupal.Commenting.FunctionComment, create a branch named: "Drupal.Commenting.FunctionComment" and submit a PR against my Drupal 7 repo.

Here's the first PRs... more to come:

• Drupal.Array.Array
• Drupal.Classes.ClassDeclaration
• Drupal.Classes.ClassComment
• Drupal.Commenting.DocComment
• Drupal.Commenting.DocCommentAlignment
• Drupal.Commenting.DocCommentStar
• Drupal.Commenting.FileComment
• Drupal.Commenting.InlineComment
• Drupal.Commenting.PostStatementComment
• Drupal.Commenting.VariableComment
• Drupal.ControlStructures.ControlSignature
• Drupal.ControlStructures.InlineControlStructure
• Drupal.CSS.ClassDefinitionNameSpacing
• Drupal.CSS.ColourDefinition
• Drupal.Files.EndFileNewline
• Drupal.Formatting.MultipleStatementAlignment
• Drupal.Formatting.SpaceUnaryOperator
• Drupal.Methods.MethodDeclaration
• Drupal.Classes.PropertyDeclaration
• Drupal.Commenting.FunctionComment
• Drupal.WhiteSpace.Comma
• Drupal.WhiteSpace.ObjectOperatorIndent
• Drupal.WhiteSpace.OperatorSpacing
• Drupal.WhiteSpace.ScopeIndent
• Squiz.Array.ArrayDeclaration
• Squiz.ControlStructures.SwitchDeclaration

To contribute to this issue, install Drupal coder:

1. cd /path/to/a/virgin/drupal/7
2. composer require drupal/coder

Then, to have an overview of all the issue to fix:

./vendor/bin/phpcs -p -s --standard=vendor/drupal/coder/coder_sniffer/Drupal --ignore=vendor/ --warning-severity=0 .

The -s flag will add the name of the Sniff.

So, if you want to check a particular sniff, you can do:

./vendor/bin/phpcs -p -s --standard=vendor/drupal/coder/coder_sniffer/Drupal --ignore=vendor/ --warning-severity=0 --sniffs=Drupal.Commenting.FunctionComment .

Here's a Google Drive spreadsheet with the current status.