Creating a view with revisions triggers Drupal\Component\Plugin\Exception\PluginNotFoundException: The "" plugin does not exist.

Can confirm this is an issue in Drupal 8.5.4.

When I'm trying to create view for content revisions (even if it's just master) I'm getting

Notice: Undefined index: in Drupal\views\Plugin\views\wizard\WizardPluginBase->defaultDisplayFiltersUser() (line 944 of /web/core/modules/views/src/Plugin/views/wizard/WizardPluginBase.php)
#0 /web/core/includes/bootstrap.inc(582): _drupal_error_handler_real(8, 'Undefined index...', '/web...', 944, Array)
#1 /web/core/modules/views/src/Plugin/views/wizard/WizardPluginBase.php(944): _drupal_error_handler(8, 'Undefined index...', '/web...', 944, Array)
#2 /web/core/modules/views/src/Plugin/views/wizard/WizardPluginBase.php(904): Drupal\views\Plugin\views\wizard\WizardPluginBase->defaultDisplayFiltersUser(Array, Object(Drupal\Core\Form\FormState))
#3 /web/core/modules/views/src/Plugin/views/wizard/WizardPluginBase.php(725): Drupal\views\Plugin\views\wizard\WizardPluginBase->defaultDisplayFilters(Array, Object(Drupal\Core\Form\FormState))
#4 /web/core/modules/views/src/Plugin/views/wizard/WizardPluginBase.php(699): Drupal\views\Plugin\views\wizard\WizardPluginBase->buildDisplayOptions(Array, Object(Drupal\Core\Form\FormState))
#5 /web/core/modules/views/src/Plugin/views/wizard/WizardPluginBase.php(1275): Drupal\views\Plugin\views\wizard\WizardPluginBase->instantiateView(Array, Object(Drupal\Core\Form\FormState))
#6 /web/core/modules/views_ui/src/ViewAddForm.php(167): Drupal\views\Plugin\views\wizard\WizardPluginBase->validateView(Array, Object(Drupal\Core\Form\FormState))
#7 [internal function]: Drupal\views_ui\ViewAddForm->validateForm(Array, Object(Drupal\Core\Form\FormState))
#8 /web/core/lib/Drupal/Core/Form/FormValidator.php(83): call_user_func_array(Array, Array)
#9 /web/core/lib/Drupal/Core/Form/FormValidator.php(276): Drupal\Core\Form\FormValidator->executeValidateHandlers(Array, Object(Drupal\Core\Form\FormState))
#10 /web/core/lib/Drupal/Core/Form/FormValidator.php(119): Drupal\Core\Form\FormValidator->doValidateForm(Array, Object(Drupal\Core\Form\FormState), 'view_add_form')
#11 /web/core/lib/Drupal/Core/Form/FormBuilder.php(575): Drupal\Core\Form\FormValidator->validateForm('view_add_form', Array, Object(Drupal\Core\Form\FormState))
#12 /web/core/lib/Drupal/Core/Form/FormBuilder.php(318): Drupal\Core\Form\FormBuilder->processForm('view_add_form', Array, Object(Drupal\Core\Form\FormState))
#13 /web/core/lib/Drupal/Core/Controller/FormController.php(74): Drupal\Core\Form\FormBuilder->buildForm('view_add_form', Object(Drupal\Core\Form\FormState))
#14 [internal function]: Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch))
#15 /web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#16 /web/core/lib/Drupal/Core/Render/Renderer.php(582): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#17 /web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#18 /web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#19 /vendor/symfony/http-kernel/HttpKernel.php(151): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#20 /vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#21 /web/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1,  true)
#22 /web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1,  true)
#23 /web/core/modules/page_cache/src/StackMiddleware/PageCache.php(99): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1,  true)
#24 /web/core/modules/page_cache/src/StackMiddleware/PageCache.php(78): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1,  true)
#25 /web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1,  true)
#26 /web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(52): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1,  true)
#27 /vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1,  true)
#28 /web/core/lib/Drupal/Core/DrupalKernel.php(666): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1,  true)
#29 /web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#130 {main}.

followed by

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "" plugin does not exist. in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 52 of /web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

Error for both standard and custom profiles.

Patch to get views going.

Should I apply it to 8.6 as well?

I encountered the same issue. Basically, when you choose a type filter in the Wizard when creating a content Revisions view, it fails.
Since type is only stored on the node_field_data table and not in the revisions base_table (node_field_revision) this fails.

The lookup of the table based on the base_table or field names is insufficient in this case.

Here's a patch that simply removes the filter for the Content Revision ViewsWizard plugin.
This doesn't fix the Paragraphs plugin, but the same can be done there.

Note, by removing the type filter in the wizard, it will have to be added manually in the view, and requires a relationship on the node data.

Of course, it would be better to allow a type filer for revisions in the wizard directly.

Posted without modification from https://twitter.com/chx/status/1067532945391521799 https://gist.github.com/chx/0832625f9ae14b113824729edf5bbe7a

Nice fix in #9. Adding the test from #2975429: Error when creating a view of content revisions of a specific content type with some modifications.

Also leaving the test for $table in, because the fix in #9 works for node revisions, but not paragraphs.

The fix in #9 is not perfect, since the test fails.

Fixed the failing test (you can't use created on node revisions) and added a test for the missing bundle data on a base table (the paragraphs use case)

Looks great but needs test-only patch

@andypost yeah sorry, forgot! Here we go.

IMO ready

Removed unused use and making sure the RTBC patch is the latest in the thread.

1. +++ b/core/modules/node/src/Plugin/views/wizard/NodeRevision.php
   @@ -95,4 +96,48 @@ protected function defaultDisplayOptions() {
   +    if (($type = $form_state->getValue(['show', 'type'])) && $type != 'all') {
   

   Let's not do assignment in an if for no real reason. Let's do

       $type = $form_state->getValue(['show', 'type']);
       if ($type && $type !== 'all') {
   

   I realise this is c&p from \Drupal\views\Plugin\views\wizard\WizardPluginBase::defaultDisplayFiltersUser

   The other thing here is do we have test coverage of selecting the all option in this case? Setting to needs work to either add coverage or point out the existing coverage.

2. +++ b/core/modules/views/tests/src/Functional/Wizard/EntityTestRevisionTest.php
   @@ -0,0 +1,43 @@
   +  /**
   +   * Tests creating a view of revisions where the type is not on the base table.
   +   */
   +  public function testRevisionsViewWithNoTypeOnBaseTable() {
   

   Nice to have this tested.

#18.1 changed the if. The refactoring of the test actually removed that case (naughty me), so I've added it back in, thanks for spotting that!

Patch from #19 worked on my end. Thanks everyone!

Patch worked for me (Drupal 8.6.10, PHP 7.2) Thx :)

Works for Drupal 8.6.10 and PHP 7.2.13

Back to rtbc - unrelated test fail

Creating @LOBsTerr for creating the issue and myself code review

Committed and pushed 2b5a0b53db to 8.8.x and 5d64617b71 to 8.7.x. Thanks!

diff --git a/core/modules/node/src/Plugin/views/wizard/NodeRevision.php b/core/modules/node/src/Plugin/views/wizard/NodeRevision.php
index 394eb9ba01..14119d4fb5 100644
--- a/core/modules/node/src/Plugin/views/wizard/NodeRevision.php
+++ b/core/modules/node/src/Plugin/views/wizard/NodeRevision.php
@@ -112,7 +112,7 @@ protected function defaultDisplayFiltersUser(array $form, FormStateInterface $fo
         'value' => [$type => $type],
         'entity_type' => 'node',
         'entity_field' => 'type',
-        'plugin_id' =>  'bundle',
+        'plugin_id' => 'bundle',
       ];
     }
     return $filters;
@@ -140,5 +140,4 @@ protected function buildDisplayOptions($form, FormStateInterface $form_state) {
     return $display_options;
   }
 
-
 }

Fixed coding standards on commit.

This is not fixed yet, I mean this ticket should not be closed. Patch from #19 worked. Tested in 8.7 version.

Update: my fault, the version that has this error is 8.6.x and patch from #19 works for it but this is already fixed in 8.7.x and above