drupal/core does not ship a composer.lock. Thanks for that if we install drupal/core with its minimum dependencies, we get egulias/email-validator:1.2.0 but with that version email validation may fail in tests.

error

I have found which commit is required from this library in specific and with that which is the minimum version that we need. I found last time it was bumped in this commit to 1.2.14.

CommentFileSizeAuthor
#2 drupal-core-update-egulias-email-validator-2965887-2.patch501 bytesmxr576
Screen_Shot_2018-04-25_at_7_52_34.png180.45 KBmxr576
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mxr576 created an issue. See original summary.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
CreditAttribution: mxr576 at Pronovix commented
Version: 8.5.x-dev » 8.6.x-dev
FileSize
drupal-core-update-egulias-email-validator-2965887-2.patch501 bytes
mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
CreditAttribution: mxr576 at Pronovix commented
Version: 8.6.x-dev » 8.5.x-dev
Status: Active » Needs review
Related issues: +#2947893: Highest-lowest testing on Drupal core

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Related issues: +#2755401: Upgrade EmailValidator to 2.x

I just stumbled upon this issue after working on #2755401: Upgrade EmailValidator to 2.x earlier this week, so here's a reference, and a heads-up that this issue may be closed soon :)

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
CreditAttribution: mxr576 at Pronovix commented

\o/

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

I'm curious which other dependency in your chain enforces a lower version. composer should otherwise provide the latest version.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Closed (won't fix)

We've completed #2755401: Upgrade EmailValidator to 2.x so this doesn't need fixing anymore.