When We try to install Themes and Module /Project/admin/theme/install/ , We got Refrence
"You can find modules and themes on drupal.org. The following file extensions are supported: zip tar tgz gz bz2. "
to visit the Theme or Module section on drupal.org in order to install the new theme and module.
When we click on the click it redirect to theme and module Section on Drupal.org , But it open in same tab .

So it easier When we click on Theme or Modules link ,It should automatically open next tab for theme or module rather than open in same tab.

Issue fork drupal-2947753

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hiten2112 created an issue. See original summary.

cilefen’s picture

Component: base system » update.module
Status: Needs review » Active
sandipauti’s picture

Update style target=_blank for update link.

ankitjain28may’s picture

I am trying to fix this issue but i am unable to find the file which is rendering this line, Can you please help me in it?

cilefen’s picture

Try `git grep "the text"`.

ankitjain28may’s picture

It returning none. I am new to Drupal, I am trying to debug but i am unable to find that component.

cilefen’s picture

$ git grep 'You can find <'
core/modules/update/src/Form/UpdateManagerInstall.php:      '#markup' => $this->t('You can find <a href=":module_url">modules</a> and <a href=":theme_url">themes</a> on <a href=":drupal_org_url">drupal.org</a>. The following file extensions are supported: %extensions.', [
ankitjain28may’s picture

Assigned: hi_ten_ja » ankitjain28may
Status: Active » Needs review
FileSize
1.62 KB

@cilefen, Thanks for helping me. I have fixed the issue.

cilefen’s picture

Status: Needs review » Needs work
+++ b/sites/development.services.yml
@@ -3,7 +3,10 @@
-  http.response.debug_cacheability_headers: true
+  twig.config:
+    debug: true
+    auto_reload: true
+    cache: false
 services:

This seems out of scope.

ankitjain28may’s picture

cilefen’s picture

Title: Make Links to Open in Next Tab » "You can find modules and themes on drupal.org" links should open in a new tab
Status: Needs work » Needs review
ankitjain28may’s picture

Status: Needs review » Needs work

I will make a write patch.

ankitjain28may’s picture

Status: Needs work » Needs review

Thanks for deleting that two patches.

chanderbhushan’s picture

#10 applied successfully and working fine. Please see attached images. thanks

borisson_’s picture

Status: Needs review » Reviewed & tested by the community

#14 is not helfpul, please don't post these kinds of images. This doesn't provide more information than what the testbot already gives us.

The patch itself does look good. Not sure if we need some kind of validation from the UX or documentation team about this change, but if we don't, I feel comfortable enough to set this to RTBC.

cilefen’s picture

Issue tags: +Usability
alexpott’s picture

Status: Reviewed & tested by the community » Postponed
Related issues: +#2702881: [policy, no patch] Formalize how external links are handled in core

This should be postponed on #2702881: [policy, no patch] Formalize how external links are handled in core - we need a policy on this. Personally I'm not favour of target="_blank". One because a user can pick themselves and two because you have to remember to add rel="noopener" or you introduce a security vulnerability. See https://developers.google.com/web/tools/lighthouse/audits/noopener

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

andrewmacpherson’s picture

Status: Postponed » Closed (works as designed)
Issue tags: +Accessibility

It's strongly preferable to let the user decide whether they want to open the link in a new window/tab, or the current window. Using target="_blank" removes this choice from the user, and prevents the user from returning to the previous page by using the browser's "backwards" function. It isn't possible for users to override target="_blank" specified by a web page.

The relevant part of WCAG is success criterion 3.2.5 Change On Request. Use of target="_blank" is extremely disruptive for many groups of users.

There's no compelling reason for these links to open in a new window. They are on a short form, which will still work fine if the user comes back to it using their browser's backwards button.

I'd close this (works as designed). I don't think we need to postpone it on the outcome of #2702881: [policy, no patch] Formalize how external links are handled in core - it's clear that forcing links to open in new windows needs to be discouraged.

Danh21 made their first commit to this issue’s fork.