When We try to install Themes and Module /Project/admin/theme/install/ , We got Refrence
"You can find modules and themes on drupal.org. The following file extensions are supported: zip tar tgz gz bz2. "
to visit the Theme or Module section on drupal.org in order to install the new theme and module.
When we click on the click it redirect to theme and module Section on Drupal.org , But it open in same tab .
So it easier When we click on Theme or Modules link ,It should automatically open next tab for theme or module rather than open in same tab.
Comment | File | Size | Author |
---|---|---|---|
#10 | Make-Links-to-Open-in-Next-Tab-2947753-10.patch | 1.07 KB | ankitjain28may |
Issue fork drupal-2947753
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
cilefen CreditAttribution: cilefen as a volunteer commentedComment #3
sandipauti CreditAttribution: sandipauti as a volunteer commentedUpdate style target=_blank for update link.
Comment #4
ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commentedI am trying to fix this issue but i am unable to find the file which is rendering this line, Can you please help me in it?
Comment #5
cilefen CreditAttribution: cilefen as a volunteer commentedTry `git grep "the text"`.
Comment #6
ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commentedIt returning none. I am new to Drupal, I am trying to debug but i am unable to find that component.
Comment #7
cilefen CreditAttribution: cilefen as a volunteer commentedComment #8
ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commented@cilefen, Thanks for helping me. I have fixed the issue.
Comment #9
cilefen CreditAttribution: cilefen as a volunteer commentedThis seems out of scope.
Comment #10
ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commentedFixed the patch
Comment #11
cilefen CreditAttribution: cilefen as a volunteer commentedComment #12
ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commentedI will make a write patch.
Comment #13
ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commentedThanks for deleting that two patches.
Comment #14
chanderbhushan CreditAttribution: chanderbhushan as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented#10 applied successfully and working fine. Please see attached images. thanks
Comment #15
borisson_#14 is not helfpul, please don't post these kinds of images. This doesn't provide more information than what the testbot already gives us.
The patch itself does look good. Not sure if we need some kind of validation from the UX or documentation team about this change, but if we don't, I feel comfortable enough to set this to RTBC.
Comment #16
cilefen CreditAttribution: cilefen as a volunteer commentedComment #17
alexpottThis should be postponed on #2702881: [policy, no patch] Formalize how external links are handled in core - we need a policy on this. Personally I'm not favour of target="_blank". One because a user can pick themselves and two because you have to remember to add
rel="noopener"
or you introduce a security vulnerability. See https://developers.google.com/web/tools/lighthouse/audits/noopenerComment #22
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedIt's strongly preferable to let the user decide whether they want to open the link in a new window/tab, or the current window. Using
target="_blank"
removes this choice from the user, and prevents the user from returning to the previous page by using the browser's "backwards" function. It isn't possible for users to overridetarget="_blank"
specified by a web page.The relevant part of WCAG is success criterion 3.2.5 Change On Request. Use of
target="_blank"
is extremely disruptive for many groups of users.There's no compelling reason for these links to open in a new window. They are on a short form, which will still work fine if the user comes back to it using their browser's backwards button.
I'd close this (works as designed). I don't think we need to postpone it on the outcome of #2702881: [policy, no patch] Formalize how external links are handled in core - it's clear that forcing links to open in new windows needs to be discouraged.