Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.drupal-7.56\includes\database\select.inc has function
public function orderBy($field, $direction = 'ASC') {
// Only allow ASC and DESC, default to ASC.
$direction = strtoupper($direction) == 'DESC' ? 'DESC' : 'ASC';
$this->order[$field] = $direction;
return $this;
}
so it means, that I can't sort data -> ASC NULLS FIRST OR DESC NULLS LAST, etc.
should be changed to something like this:
public function orderBy($field, $direction = 'ASC') {
// Only allow ASC and DESC, default to ASC.
$direction = strtoupper($direction);
if ($direction !="ASC NULLS FIRST"){
$direction == 'DESC' ? 'DESC' : 'ASC';
}
//
$this->order[$field] = $direction;
return $this;
}
MySQL exports nulls first, but PostgreSQL export nulls last, so there is big problem if db are switched and there is no way to fix this problem, because there is only ASC and DESC values allowed.
Comments
Comment #2
B.Mafia CreditAttribution: B.Mafia commentedComment #3
MustangGB CreditAttribution: MustangGB commentedSeems like a fair request, although not many people are complaining about it, doesn't appear to lead to data loss, and there is a workaround (pick your DB wisely), so not sure this counts as critical.
Comment #4
Liam MorlandComment #5
pounardThe best solution would be to have the
NULL FIRSTS | LASTgeneric feature on the query builder, whatever is the SQL engine, then business-specific code would call$select->orderByNullFirst()by themselves whenever necessary. Only SQLite will not support this, but both MySQL and PostgreSQL do.Comment #6
bzrudi71 CreditAttribution: bzrudi71 as a volunteer commentedHere is how we did it for Drupal 8 - guess this could be backported. #2443657: PostgreSQL: Fix system\Tests\Entity\EntityQueryTest
Comment #7
poker10 CreditAttribution: poker10 at ActivIT s.r.o. commentedAdding a patch to backport D8 issue: #2443657: PostgreSQL: Fix system\Tests\Entity\EntityQueryTest
However this will change the ORDER BY behavior with NULLs in PostgreSQL so possibly it can cause some regressions in contrib modules (if these relies on such order). So it needs to be considered if we want the consistent behavior between MySQL/PostgreSQL and if it is worth the potential troubles (in this D7 stage).