[META] Check that all field formatter types are mapped and tested [#2944604]

Follow-up for #2843617: Field formatter mappings defined in getFieldFormatterMap have no effect.

We need to check that all field formatter types from Drupal 6 & 7 are correctly mapped to Drupal 8 field formatter types and that they are tested.

We also need to clean the static map in d6_field_formatter_settings and ideally move it to the field plugins getFieldFormatterMap() methods.

Example of inconsistency between the static map and field plugins:

From the d6_field_formatter_settings:

  default: email_mailto
  spamspan: email_mailto
  contact: email_mailto
  plain: basic_string

And from the Email field plugin:

  'email_formatter_default' => 'basic_string',
  'email_formatter_contact' => 'basic_string',
  'email_formatter_plain' => 'basic_string',
  'email_formatter_spamspan' => 'basic_string',

The formatter types are not even the same and the mappings are different.

Comments

Comment #1

14 February 2018 at 03:06

maxocub created an issue. See original summary.

Comment #2

maxocub CreditAttribution: maxocub as a volunteer commented 14 February 2018 at 15:20

Issue summary:

View changes

Comment #3

maxocub CreditAttribution: maxocub as a volunteer commented 11 March 2018 at 19:06

Status:

Postponed

» Active

Parent issue is fixed.

Comment #4

11 March 2018 at 19:06

Version:

8.6.x-dev

» 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #5

11 March 2018 at 19:06

Version:

8.7.x-dev

» 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #6

11 March 2018 at 19:06

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #7

11 March 2018 at 19:06

Version:

8.9.x-dev

» 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #8

11 March 2018 at 19:06

Version:

9.1.x-dev

» 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Comment #9

11 March 2018 at 19:06

Version:

9.2.x-dev

» 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #10

quietone CreditAttribution: quietone as a volunteer commented 11 May 2021 at 02:53

Title:

Check that all field formatter types are mapped and tested

» [Meta] Check that all field formatter types are mapped and tested

Comment #11

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 11 May 2021 at 09:05

Title:	[Meta] Check that all field formatter types are mapped and tested	» [META] Check that all field formatter types are mapped and tested
Category:	Task	» Plan

Thanks for pointing me to this issue!

Comment #12

quietone CreditAttribution: quietone as a volunteer commented 23 October 2021 at 05:33

Status:

Active

» Fixed

The reality is that we are not searching for field formatter types that should be migrated. We have been re-actively adding them when someone files an issue and it is decided that a migration for the formatter should be handled by core. This is all on a case by case basis.

As marvil07 said at the migrate meeting, "a responsive on-demand approach sounds like the more natural path forward"

Therefor closing this, 'fixed' seems the best status. Correct me if I am wrong.