Problem/Motivation

Umami has a complex layout for the Recipe content type. So far, it has been addressed with custom markup in the twig file.

The requirements for a core theme to support the potential for fields to be moved around by a user via the manage display settings for the recipe content type were discussed. Some potential issues:

  • But it has been discarded so far because the Field Layout module is experimental.
  • We may not be able to produce styling that will always look great given the repositioning of a field.
  • The module could be disabled while the user is testing Drupal.

Attached is a screenshot of a prototype layout that supports this approach for recipe content type. This issue covers work on theming out the recipe content type's layout using this method ready for review.

Proposed resolution

It would be great to have addressed the integration with Field Layout when it becomes stable to be able to showcase it.

One approach discussed was to have a simple and one-column alternative design as a fallback if the module is disabled.

Remaining tasks

To define.

User interface changes

To define.

CommentFileSizeAuthor
manage-display-layout.png137.99 KBckrina
full-recipe.jpg1.51 MBckrina
recipe-layout.png992.86 KBckrina
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ckrina created an issue. See original summary.

ckrina’s picture

Title: Consider showcasing Layout module in Umami Demo Profile » Consider showcasing Field Layout module in Umami Demo Profile
Eli-T’s picture

@ckrina with respect to

  • The module could be disabled while the user is testing Drupal.

I don't think we should worry about that when it comes to adding new capabilities to Umami. There are already a large number of modules which if uninstalled will cause Umami to 'break' in some way. We shouldn't shy away from using new stable additions to core where appropriate in case people go and turn them off. In fact, if they do go and turn them off, they will see the resultant changes and learn from them!

ckrina’s picture

My developer side agrees with you, but if I'm trying to place myself in a Drupal evaluator position I'd expect Drupal to not "break" with something like this. Of course we can't assure Drupal will work with each combination of modules, but I think this one is really isolated and """"easily"""" solvable.

markconroy’s picture

Issue tags: +dclondon
mariohernandez’s picture

@ckrina I think if we build the recipe page using the component based approach we can help things from breaking if fields get moved around. Let me know if this is something I can help with.

Eli-T’s picture

Issue tags: -dclondon +Nwdug_may18
Eli-T’s picture

Note that with respect to the discussion in #3 and #4, now we have #2952888, we can mandate the user is prevented from disabling specific modules if we so desire.

This is just for info, I'm not saying we should or shouldn't do that at this point - will raise a separate issue to discuss how/if we exploit that.

Eli-T’s picture

markconroy’s picture

Status: Active » Postponed
Issue tags: +Umami new feature

I'm setting this as postponed.

I don't see it as a feature we are going to work on in order to get Umami unhidden.

I'm very happy for us to work on this straightaway then, as I do think it's a feature we should support, so the only reason it is being postponed is so we can focus as must as possible on the items that help us get unhidden.

I am attaching the 'Umami new feature' tag to this item.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Eli-T’s picture

Status: Postponed » Closed (won't fix)

Following discussion with @tedbow at DrupalEurope, it appears Field Layout's capabilities for laying out content are duplicated by Layout Builder. Layout Builder is going to be the more supported option, with Field Layout being potentially deprecated or being targeted specifically at layout of fields in edit forms rather than display. That by itself does not seem something to prioritise demonstrating in Umami, so closing this ticket.