Views attachments are not rendered in the specified order

This worked for me

Hi all, checking the patch #5, the test is failing for the Drupal\Tests\views\Functional\Plugin\DisplayTest because two attachments contains the same position, and when you add this $attached_displays[$display['position']] = $display_id;, a view display id is removed.

in the current patch, the approach is to sort first the view displays regarding the position before to get the attached_displays array.

1. +++ b/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
   @@ -688,11 +688,15 @@ public function usesExposedFormInBlock() {
   +    // Sort displays regarding position value.
   

   Reads a bit funny.

   How about:

   "Sort the displays by their position."

2. +++ b/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
   @@ -688,11 +688,15 @@ public function usesExposedFormInBlock() {
   +    uasort($all_displays, function ($a, $b) { return ($a["position"] <= $b["position"]) ? -1 : 1; });
   

   Should use SortArray::sortByKeyString() here.

Patch added.

+++ b/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
@@ -688,11 +689,15 @@ public function usesExposedFormInBlock() {
+    //Sort the displays by their position.

Missing space after the //

+++ b/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
@@ -692,8 +693,8 @@
+    SortArray::sortByKeyString($all_displays, function ($a, $b) { return ($a["position"] <= $b["position"]) ? -1 : 1; });

That's not how this method is used. It's a callback for uasort().

Here's a corrected patch.

LGTM!

Patch itself looks OK, but this needs a test.

Adds a test for the work done in #13.

In order to not break the alphabetical render ordering of existing display attachments, we need an update hook to rewrite positional ordering in alphabetical order.

Re-rolled #17 for 9.4.

Fixing failed tests of patch #25.

Re #19:

Let's discuss this by looking at the following example:

1) Display "Block";
2) Display "Attachment 1";
3) Display "Attachment 2";
both attachments were added to "Block".

Sites without this patch will always display attachments in the following order: 2) and 3) ignoring their position.
Sites with this patch will consider the position, so it can be either 2), 3) or 3), 2) depending on the configuration.

The proposed update hook will change the positions and preserve the behavior for sites without the applied patch.
But if the patch is already applied and the position was changed, there is no way to know that, right?

Perhaps the change record will be enough in this case?

@Matroskeen we can't really take sites that already use this patch into consideration here when writing the update. For this issue that MIGHT still be doable, but for larger and longer running issues we just need to let that go. People that have applied patches need to be aware that things can shift.
So we only consider sites that are unaware of this bug when doing the update.

Fixed for 9.5.x-dev

Rerolled patch

As per comments #19, #29, and #30, we need an update hook to take care of existing views. Back to Needs Work for that.

Until we get this fixed properly, using the ReOrder Displays option. I've got a hack - If you go under Advanced in the view and change the Machine Name to be in Alphabetical order for how you want, It will reorder the view's attachments on the front end.

ie:
Let's say your parent view's machine name is "daily" and your attachments' machine names are "attachment_1" and "attachment_2". You want the order to be: daily, attachment_2, attachment1. So now you rename the attachments' machine names: "attachment_2" becomes "daily_1" and "attachment_1" becomes "daily_2"

Save the view and you should see everything in the order you want.

Full credit to Ruc Van over here: https://drupal.stackexchange.com/questions/242274/how-can-i-order-views-...
for figuring this out.

Having same problem and also same solution as #31

You can use numbers to set your order, but if you don't like to use "standard" names on your attachments, you can use text instead and drupal view will order alphabetical

Re-rolling patch #32 to 10.0.x, I haven't fixed the issues mentioned in #19, #29, and #30 to write an update update hook. Will work on it once I have some time. Not changing the issue status for the same reason