The Out-of-the-Box Experience initiative team has been doing amazing work trying to prep Umami for shipping in a tagged release. The profile + theme was already been committed to 8.6.x as of a few weeks ago, but the product management is universally aligned that the sooner we can get this amazing functionality out to people, the better it is for Drupal as a whole, and Drupal 8 adoption specifically.

In a discussion with release managers, however, there were concerns raised about shipping it in 8.5.0 given that it was only committed recently (and after the alpha deadline) which—unlike something like Layout Builder which was committed months previously—doesn't leave much room for widespread testing of functionality ahead of release. This is particularly nervous-making given 8.5 has a very short RC cycle in which to flesh out bugs. Additionally, further inspecting might raise some unknown unknowns, such as #2942589: [policy, no patch] Can we (and to what extent) make changes to experimental profiles during a patch release? (which is a "now known unknown unknown" :D /HT @catch) which would impact in what way the profile could evolve within a tagged release and not diverge too much from 8.6.

A compromise was suggested, and seems to have backing of most of the core committer team, of backporting the profile+theme to 8.5, but marking them "hidden," at least for now. This would still make them available in 8.5, installable via Drush (not for evaluators obviously, but for QA testers), and would let us possibly mark Umami unhidden in a later point release (like 8.5.1) to open them up to their intended audience (evaluators, people new to Drupal, people doing Drupal demos, etc.).

We will keep the profile non-hidden (i.e., shown in the installer) in 8.6.x so that beta testers can easily test the demo by using the development tarball.

Commit instructions

git co 8.5.x
git pull
git log --reverse --pretty=format:'%h' 8.6.x -- core/profiles/demo_umami | xargs  git cherry-pick -x

And then apply https://www.drupal.org/files/issues/2943004.4.patch, commit and push as per normal.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webchick created an issue. See original summary.

xjm’s picture

Issue summary: View changes

Adding a bit to the summary about the dev tarball; this change would be 8.5.x-only.

alexpott’s picture

To cherry pick all the commits to the umami profile from 8.6.x to 8.5.x you can run the following command on the 8.5.x branch from the root directory.

git log --reverse --pretty=format:'%h' 8.6.x -- core/profiles/demo_umami | xargs git cherry-pick -x

alexpott’s picture

Status: Active » Needs review
FileSize
1.8 MB
442 bytes

Here's a patch that does #3 and hides the profile to test that tests pass with the profile hidden.

Another patch attached to just hide the profile. Not tested because it won't apply to 8.5.x on its own.

alexpott’s picture

The only commit that is picked that has affected more than just umami is #2939940: Update stylelint rules color-hex-case to be consistent with Drupal's CSS standards and that was backported to 8.5.x so cherry picking that make sense as it will only affect the umami profile.

alexpott’s picture

Issue summary: View changes

Yay the tests passed. I've looked in the test log and confirmed that the umami tests ran as expected. Added commit instruction to the issue summary.

alexpott’s picture

Here's a list of changed files:

core/lib/Drupal/Core/Installer/Form/SelectProfileForm.php
core/modules/system/src/Tests/Installer/SingleVisibleProfileTest.php
core/profiles/demo_umami/config/install/block.block.breadcrumbs.yml
core/profiles/demo_umami/config/install/block.block.help.yml
core/profiles/demo_umami/config/install/block.block.seven_breadcrumbs.yml
core/profiles/demo_umami/config/install/block.block.seven_content.yml
core/profiles/demo_umami/config/install/block.block.seven_help.yml
core/profiles/demo_umami/config/install/block.block.seven_local_actions.yml
core/profiles/demo_umami/config/install/block.block.seven_login.yml
core/profiles/demo_umami/config/install/block.block.seven_messages.yml
core/profiles/demo_umami/config/install/block.block.seven_page_title.yml
core/profiles/demo_umami/config/install/block.block.seven_primary_local_tasks.yml
core/profiles/demo_umami/config/install/block.block.seven_secondary_local_tasks.yml
core/profiles/demo_umami/config/install/block.block.umami_account_menu.yml
core/profiles/demo_umami/config/install/block.block.umami_branding.yml
core/profiles/demo_umami/config/install/block.block.umami_content.yml
core/profiles/demo_umami/config/install/block.block.umami_footer.yml
core/profiles/demo_umami/config/install/block.block.umami_local_tasks.yml
core/profiles/demo_umami/config/install/block.block.umami_main_menu.yml
core/profiles/demo_umami/config/install/block.block.umami_messages.yml
core/profiles/demo_umami/config/install/block.block.umami_page_title.yml
core/profiles/demo_umami/config/install/block.block.umami_search.yml
core/profiles/demo_umami/config/install/block.block.views_block__articles_aside_block_1.yml
core/profiles/demo_umami/config/install/block.block.views_block__promoted_items_block_1.yml
core/profiles/demo_umami/config/install/block_content.type.banner_block.yml
core/profiles/demo_umami/config/install/block_content.type.basic.yml
core/profiles/demo_umami/config/install/block_content.type.disclaimer_block.yml
core/profiles/demo_umami/config/install/block_content.type.footer_promo_block.yml
core/profiles/demo_umami/config/install/contact.form.feedback.yml
core/profiles/demo_umami/config/install/core.base_field_override.node.page.promote.yml
core/profiles/demo_umami/config/install/core.base_field_override.node.recipe.title.yml
core/profiles/demo_umami/config/install/core.date_format.umami_dates.yml
core/profiles/demo_umami/config/install/core.entity_form_display.block_content.banner_block.default.yml
core/profiles/demo_umami/config/install/core.entity_form_display.block_content.basic.default.yml
core/profiles/demo_umami/config/install/core.entity_form_display.block_content.disclaimer_block.default.yml
core/profiles/demo_umami/config/install/core.entity_form_display.block_content.footer_promo_block.default.yml
core/profiles/demo_umami/config/install/core.entity_form_display.contact_message.feedback.default.yml
core/profiles/demo_umami/config/install/core.entity_form_display.node.article.default.yml
core/profiles/demo_umami/config/install/core.entity_form_display.node.page.default.yml
core/profiles/demo_umami/config/install/core.entity_form_display.node.recipe.default.yml
core/profiles/demo_umami/config/install/core.entity_form_display.user.user.default.yml
core/profiles/demo_umami/config/install/core.entity_view_display.block_content.banner_block.default.yml
core/profiles/demo_umami/config/install/core.entity_view_display.block_content.basic.default.yml
core/profiles/demo_umami/config/install/core.entity_view_display.block_content.disclaimer_block.default.yml
core/profiles/demo_umami/config/install/core.entity_view_display.block_content.footer_promo_block.default.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.article.default.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.article.full.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.article.highlighted_bottom.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.article.highlighted_medium.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.article.highlighted_small.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.article.highlighted_top.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.article.rss.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.article.teaser.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.page.default.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.page.teaser.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.recipe.default.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.recipe.full.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.recipe.highlighted_bottom.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.recipe.highlighted_medium.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.recipe.highlighted_small.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.recipe.highlighted_top.yml
core/profiles/demo_umami/config/install/core.entity_view_display.node.recipe.teaser.yml
core/profiles/demo_umami/config/install/core.entity_view_display.user.user.compact.yml
core/profiles/demo_umami/config/install/core.entity_view_display.user.user.default.yml
core/profiles/demo_umami/config/install/core.entity_view_mode.node.highlighted_bottom.yml
core/profiles/demo_umami/config/install/core.entity_view_mode.node.highlighted_medium.yml
core/profiles/demo_umami/config/install/core.entity_view_mode.node.highlighted_small.yml
core/profiles/demo_umami/config/install/core.entity_view_mode.node.highlighted_top.yml
core/profiles/demo_umami/config/install/editor.editor.basic_html.yml
core/profiles/demo_umami/config/install/editor.editor.full_html.yml
core/profiles/demo_umami/config/install/field.field.block_content.banner_block.field_banner_image.yml
core/profiles/demo_umami/config/install/field.field.block_content.banner_block.field_content_link.yml
core/profiles/demo_umami/config/install/field.field.block_content.banner_block.field_summary.yml
core/profiles/demo_umami/config/install/field.field.block_content.banner_block.field_title.yml
core/profiles/demo_umami/config/install/field.field.block_content.basic.body.yml
core/profiles/demo_umami/config/install/field.field.block_content.disclaimer_block.field_copyright.yml
core/profiles/demo_umami/config/install/field.field.block_content.disclaimer_block.field_disclaimer.yml
core/profiles/demo_umami/config/install/field.field.block_content.footer_promo_block.field_content_link.yml
core/profiles/demo_umami/config/install/field.field.block_content.footer_promo_block.field_promo_image.yml
core/profiles/demo_umami/config/install/field.field.block_content.footer_promo_block.field_summary.yml
core/profiles/demo_umami/config/install/field.field.block_content.footer_promo_block.field_title.yml
core/profiles/demo_umami/config/install/field.field.node.article.body.yml
core/profiles/demo_umami/config/install/field.field.node.article.field_image.yml
core/profiles/demo_umami/config/install/field.field.node.article.field_tags.yml
core/profiles/demo_umami/config/install/field.field.node.page.body.yml
core/profiles/demo_umami/config/install/field.field.node.recipe.field_author.yml
core/profiles/demo_umami/config/install/field.field.node.recipe.field_cooking_time.yml
core/profiles/demo_umami/config/install/field.field.node.recipe.field_difficulty.yml
core/profiles/demo_umami/config/install/field.field.node.recipe.field_image.yml
core/profiles/demo_umami/config/install/field.field.node.recipe.field_ingredients.yml
core/profiles/demo_umami/config/install/field.field.node.recipe.field_number_of_servings.yml
core/profiles/demo_umami/config/install/field.field.node.recipe.field_preparation_time.yml
core/profiles/demo_umami/config/install/field.field.node.recipe.field_recipe_category.yml
core/profiles/demo_umami/config/install/field.field.node.recipe.field_recipe_instruction.yml
core/profiles/demo_umami/config/install/field.field.node.recipe.field_summary.yml
core/profiles/demo_umami/config/install/field.field.node.recipe.field_tags.yml
core/profiles/demo_umami/config/install/field.field.user.user.user_picture.yml
core/profiles/demo_umami/config/install/field.storage.block_content.field_banner_image.yml
core/profiles/demo_umami/config/install/field.storage.block_content.field_content_link.yml
core/profiles/demo_umami/config/install/field.storage.block_content.field_copyright.yml
core/profiles/demo_umami/config/install/field.storage.block_content.field_disclaimer.yml
core/profiles/demo_umami/config/install/field.storage.block_content.field_promo_image.yml
core/profiles/demo_umami/config/install/field.storage.block_content.field_summary.yml
core/profiles/demo_umami/config/install/field.storage.block_content.field_title.yml
core/profiles/demo_umami/config/install/field.storage.node.field_author.yml
core/profiles/demo_umami/config/install/field.storage.node.field_cooking_time.yml
core/profiles/demo_umami/config/install/field.storage.node.field_difficulty.yml
core/profiles/demo_umami/config/install/field.storage.node.field_image.yml
core/profiles/demo_umami/config/install/field.storage.node.field_ingredients.yml
core/profiles/demo_umami/config/install/field.storage.node.field_number_of_servings.yml
core/profiles/demo_umami/config/install/field.storage.node.field_preparation_time.yml
core/profiles/demo_umami/config/install/field.storage.node.field_recipe_category.yml
core/profiles/demo_umami/config/install/field.storage.node.field_recipe_instruction.yml
core/profiles/demo_umami/config/install/field.storage.node.field_summary.yml
core/profiles/demo_umami/config/install/field.storage.node.field_tags.yml
core/profiles/demo_umami/config/install/field.storage.user.user_picture.yml
core/profiles/demo_umami/config/install/filter.format.basic_html.yml
core/profiles/demo_umami/config/install/filter.format.full_html.yml
core/profiles/demo_umami/config/install/filter.format.restricted_html.yml
core/profiles/demo_umami/config/install/image.style.large_21_9.yml
core/profiles/demo_umami/config/install/image.style.large_21_9_2x.yml
core/profiles/demo_umami/config/install/image.style.large_3_2_2x.yml
core/profiles/demo_umami/config/install/image.style.large_3_2_768x512.yml
core/profiles/demo_umami/config/install/image.style.medium_21_9.yml
core/profiles/demo_umami/config/install/image.style.medium_3_2_2x.yml
core/profiles/demo_umami/config/install/image.style.medium_3_2_600x400.yml
core/profiles/demo_umami/config/install/image.style.medium_8_7.yml
core/profiles/demo_umami/config/install/image.style.scale_crop_7_3_large.yml
core/profiles/demo_umami/config/install/image.style.small_21_9.yml
core/profiles/demo_umami/config/install/image.style.square_large.yml
core/profiles/demo_umami/config/install/image.style.square_medium.yml
core/profiles/demo_umami/config/install/image.style.square_small.yml
core/profiles/demo_umami/config/install/node.type.article.yml
core/profiles/demo_umami/config/install/node.type.page.yml
core/profiles/demo_umami/config/install/node.type.recipe.yml
core/profiles/demo_umami/config/install/rdf.mapping.node.article.yml
core/profiles/demo_umami/config/install/rdf.mapping.node.page.yml
core/profiles/demo_umami/config/install/rdf.mapping.taxonomy_term.tags.yml
core/profiles/demo_umami/config/install/responsive_image.styles.3_2_image.yml
core/profiles/demo_umami/config/install/responsive_image.styles.hero_or_banner.yml
core/profiles/demo_umami/config/install/responsive_image.styles.square.yml
core/profiles/demo_umami/config/install/system.theme.yml
core/profiles/demo_umami/config/install/taxonomy.vocabulary.ingredients.yml
core/profiles/demo_umami/config/install/taxonomy.vocabulary.recipe_category.yml
core/profiles/demo_umami/config/install/taxonomy.vocabulary.recipe_cuisine.yml
core/profiles/demo_umami/config/install/taxonomy.vocabulary.tags.yml
core/profiles/demo_umami/config/install/user.role.administrator.yml
core/profiles/demo_umami/config/install/views.view.articles_aside.yml
core/profiles/demo_umami/config/install/views.view.featured_articles.yml
core/profiles/demo_umami/config/install/views.view.frontpage.yml
core/profiles/demo_umami/config/install/views.view.promoted_items.yml
core/profiles/demo_umami/config/install/views.view.recipes.yml
core/profiles/demo_umami/config/install/views.view.taxonomy_term.yml
core/profiles/demo_umami/config/optional/block.block.umami_banner_recipes.yml
core/profiles/demo_umami/config/optional/block.block.umami_disclaimer.yml
core/profiles/demo_umami/config/optional/block.block.umami_footer_promo.yml
core/profiles/demo_umami/config/optional/image.style.max_1300x1300.yml
core/profiles/demo_umami/config/optional/image.style.max_2600x2600.yml
core/profiles/demo_umami/config/optional/image.style.max_325x325.yml
core/profiles/demo_umami/config/optional/image.style.max_650x650.yml
core/profiles/demo_umami/config/optional/responsive_image.styles.narrow.yml
core/profiles/demo_umami/config/optional/responsive_image.styles.wide.yml
core/profiles/demo_umami/css/toolbar-warning.css
core/profiles/demo_umami/demo_umami.info.yml
core/profiles/demo_umami/demo_umami.install
core/profiles/demo_umami/demo_umami.libraries.yml
core/profiles/demo_umami/demo_umami.links.menu.yml
core/profiles/demo_umami/demo_umami.profile
core/profiles/demo_umami/modules/demo_umami_content/default_content/LICENCE.txt
core/profiles/demo_umami/modules/demo_umami_content/default_content/article_body/.htaccess
core/profiles/demo_umami/modules/demo_umami_content/default_content/article_body/give-it-a-go-and-grow-your-own-herbs.html
core/profiles/demo_umami/modules/demo_umami_content/default_content/article_body/lets-hear-it-for-carrots.html
core/profiles/demo_umami/modules/demo_umami_content/default_content/article_body/the-real-deal-for-supermarket-savvy-shopping.html
core/profiles/demo_umami/modules/demo_umami_content/default_content/article_body/the-umami-guide-to-our-favourite-mushrooms.html
core/profiles/demo_umami/modules/demo_umami_content/default_content/articles.csv
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/.htaccess
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/chocolate-brownie-umami.jpg
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/heritage-carrots.jpg
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/home-grown-herbs.jpg
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/mediterranean-quiche-umami.jpg
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/mushrooms-umami.jpg
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/pizza-umami.jpg
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/supermarket-savvy-umami.jpg
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/thai-green-curry-umami.jpg
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/umami-bundle.png
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/veggie-pasta-bake-hero-umami.jpg
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/veggie-pasta-bake-umami.jpg
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/victoria-sponge-umami.jpg
core/profiles/demo_umami/modules/demo_umami_content/default_content/images/watercress-soup-umami.jpg
core/profiles/demo_umami/modules/demo_umami_content/default_content/pages.csv
core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/.htaccess
core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/chocolate-brownie-umami.html
core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/mediterranean-quiche-umami.html
core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/pizza-umami.html
core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/thai-green-curry-umami.html
core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/veggie-pasta-bake-umami.html
core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/victoria-sponge-umami.html
core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/watercress-soup-umami.html
core/profiles/demo_umami/modules/demo_umami_content/default_content/recipes.csv
core/profiles/demo_umami/modules/demo_umami_content/demo_umami_content.info.yml
core/profiles/demo_umami/modules/demo_umami_content/demo_umami_content.install
core/profiles/demo_umami/modules/demo_umami_content/src/InstallHelper.php
core/profiles/demo_umami/modules/demo_umami_content/tests/src/Functional/UninstallDefaultContentTest.php
core/profiles/demo_umami/tests/src/Functional/DemoUmamiProfileTest.php
core/profiles/demo_umami/themes/umami/css/base.css
core/profiles/demo_umami/themes/umami/css/components/blocks/articles-aside/articles-aside.css
core/profiles/demo_umami/themes/umami/css/components/blocks/banner/banner.css
core/profiles/demo_umami/themes/umami/css/components/blocks/branding/branding.css
core/profiles/demo_umami/themes/umami/css/components/blocks/disclaimer/disclaimer.css
core/profiles/demo_umami/themes/umami/css/components/blocks/footer-promo/footer-promo.css
core/profiles/demo_umami/themes/umami/css/components/blocks/page-title/page-title.css
core/profiles/demo_umami/themes/umami/css/components/blocks/quicklinks/quicklinks.css
core/profiles/demo_umami/themes/umami/css/components/blocks/search/search-results.css
core/profiles/demo_umami/themes/umami/css/components/blocks/search/search.css
core/profiles/demo_umami/themes/umami/css/components/content-types/article/article.css
core/profiles/demo_umami/themes/umami/css/components/content-types/recipe/recipe.css
core/profiles/demo_umami/themes/umami/css/components/content/full/node-full.css
core/profiles/demo_umami/themes/umami/css/components/content/highlighted-bottom/highlighted-bottom.css
core/profiles/demo_umami/themes/umami/css/components/content/highlighted-medium/highlighted-medium.css
core/profiles/demo_umami/themes/umami/css/components/content/highlighted-small/highlighted-small.css
core/profiles/demo_umami/themes/umami/css/components/content/highlighted-top/highlighted-top.css
core/profiles/demo_umami/themes/umami/css/components/content/node.css
core/profiles/demo_umami/themes/umami/css/components/fields/label-items.css
core/profiles/demo_umami/themes/umami/css/components/forms/buttons.css
core/profiles/demo_umami/themes/umami/css/components/forms/contact.css
core/profiles/demo_umami/themes/umami/css/components/messages/messages.css
core/profiles/demo_umami/themes/umami/css/components/navigation/breadcrumbs/breadcrumbs.css
core/profiles/demo_umami/themes/umami/css/components/navigation/menu-account/menu-account.css
core/profiles/demo_umami/themes/umami/css/components/navigation/menu-footer/menu-footer.css
core/profiles/demo_umami/themes/umami/css/components/navigation/menu-main/menu-main.css
core/profiles/demo_umami/themes/umami/css/components/navigation/more-link/more-link.css
core/profiles/demo_umami/themes/umami/css/components/navigation/skip-link/skip-link.css
core/profiles/demo_umami/themes/umami/css/components/navigation/tabs/tabs.css
core/profiles/demo_umami/themes/umami/css/components/regions/bottom/bottom.css
core/profiles/demo_umami/themes/umami/css/components/regions/footer/footer.css
core/profiles/demo_umami/themes/umami/css/components/regions/header/header.css
core/profiles/demo_umami/themes/umami/css/components/views/frontpage.css
core/profiles/demo_umami/themes/umami/css/components/views/promoted-items.css
core/profiles/demo_umami/themes/umami/css/layout/grid-2.css
core/profiles/demo_umami/themes/umami/css/layout/grid-3.css
core/profiles/demo_umami/themes/umami/css/layout/grid-4.css
core/profiles/demo_umami/themes/umami/css/layout/layout-2-col.css
core/profiles/demo_umami/themes/umami/css/layout/layout.css
core/profiles/demo_umami/themes/umami/images/svg/cake.svg
core/profiles/demo_umami/themes/umami/images/svg/chefs-hat.svg
core/profiles/demo_umami/themes/umami/images/svg/difficulty.svg
core/profiles/demo_umami/themes/umami/images/svg/health.svg
core/profiles/demo_umami/themes/umami/images/svg/knife.svg
core/profiles/demo_umami/themes/umami/images/svg/learn-to-cook.svg
core/profiles/demo_umami/themes/umami/images/svg/menu-icon.svg
core/profiles/demo_umami/themes/umami/images/svg/pointer--white.svg
core/profiles/demo_umami/themes/umami/images/svg/pointer.svg
core/profiles/demo_umami/themes/umami/images/svg/search.svg
core/profiles/demo_umami/themes/umami/images/svg/serves.svg
core/profiles/demo_umami/themes/umami/images/svg/spoon.svg
core/profiles/demo_umami/themes/umami/images/svg/timer.svg
core/profiles/demo_umami/themes/umami/images/svg/whisk.svg
core/profiles/demo_umami/themes/umami/js/components/navigation/menu-main/menu-main.es6.js
core/profiles/demo_umami/themes/umami/js/components/navigation/menu-main/menu-main.js
core/profiles/demo_umami/themes/umami/logo.svg
core/profiles/demo_umami/themes/umami/screenshot.png
core/profiles/demo_umami/themes/umami/templates/components/banner-block/block--bundle--banner-block.html.twig
core/profiles/demo_umami/themes/umami/templates/components/branding/block--system-branding-block.html.twig
core/profiles/demo_umami/themes/umami/templates/components/footer-promo-block/block--bundle--footer-promo-block.html.twig
core/profiles/demo_umami/themes/umami/templates/components/messages/status-messages.html.twig
core/profiles/demo_umami/themes/umami/templates/components/navigation/block--system-menu-block--footer.html.twig
core/profiles/demo_umami/themes/umami/templates/components/navigation/block--umami-main-menu.html.twig
core/profiles/demo_umami/themes/umami/templates/components/navigation/breadcrumb.html.twig
core/profiles/demo_umami/themes/umami/templates/components/navigation/menu--main.html.twig
core/profiles/demo_umami/themes/umami/templates/components/navigation/menu-local-task.html.twig
core/profiles/demo_umami/themes/umami/templates/components/navigation/menu.html.twig
core/profiles/demo_umami/themes/umami/templates/components/quicklinks/block--umami-quick-links.html.twig
core/profiles/demo_umami/themes/umami/templates/components/search/block--search-form-block.html.twig
core/profiles/demo_umami/themes/umami/templates/content/node--article--full.html.twig
core/profiles/demo_umami/themes/umami/templates/content/node--highlighted-bottom.html.twig
core/profiles/demo_umami/themes/umami/templates/content/node--highlighted-medium.html.twig
core/profiles/demo_umami/themes/umami/templates/content/node--highlighted-small.html.twig
core/profiles/demo_umami/themes/umami/templates/content/node--highlighted-top.html.twig
core/profiles/demo_umami/themes/umami/templates/content/node--recipe--full.html.twig
core/profiles/demo_umami/themes/umami/templates/content/node.html.twig
core/profiles/demo_umami/themes/umami/templates/layout/page.html.twig
core/profiles/demo_umami/themes/umami/umami.breakpoints.yml
core/profiles/demo_umami/themes/umami/umami.info.yml
core/profiles/demo_umami/themes/umami/umami.libraries.yml
core/profiles/demo_umami/themes/umami/umami.theme
core/tests/Drupal/FunctionalJavascriptTests/Core/Installer/Form/SelectProfileFormTest.php
core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php

The changes outside core/profiles/demo_umami are test changes to make them pass now umami is here and the change to the installer to hard-code the warning.

alexpott’s picture

The commits included in #4 are:

* 9108ff0983 - Issue #2941902 by smaz: Reduce the file size for bundled images in Umami (29 hours ago) <Alex Pott>
* 3c43071ab7 - Issue #2942406 by Eli-T, markconroy, andrewmacpherson: Text alternative for Umami mobile search link (30 hours ago) <Alex Pott>
* 6eee27d88d - Issue #2941837 by Eli-T, kjay, cehfisher: Move article body out of csv file in to their own text file (2 days ago) <Alex Pott>
* fa3e38e10d - Issue #2938185 by tedbow, JayKandari, navneet0693, acbramley, Eli-T, larowlan, webchick, markconroy, andrewmacpherson, David_Rothstein, smaz, ckrina: When installing Umami, only show warning if 'Demo Umami' radio button is selected (and ensure that it is obvious that warning message only applies to the Umami profile) (4 days ago) <webchick>
* e38bc88695 - Issue #2941558 by markconroy, Eli-T, oakulm: Theme does not provide logged in users menu item or controls to edit his/hers user details (4 days ago) <Gabor Hojtsy>
* f00dc6733c - Issue #2942007 by David_Rothstein, navneet0693, andrewmacpherson: Move the footer promo block image to a field, for better configurability and accessibility (4 days ago) <Gabor Hojtsy>
* 39e2179807 - Issue #2940362 by Eli-T, kjay, navneet0693, markconroy, larowlan, Gábor Hojtsy: Move recipe instruction out of csv file in to their own text file (4 days ago) <Gabor Hojtsy>
* 40af3f5ad2 - Issue #2938805 by markconroy, David_Rothstein, ckrina, Eli-T: Finalise the wording of the warning message on the status report page (5 days ago) <Lee Rowlands>
* 61a032b94d - Issue #2941582 by markconroy, Eli-T, smaz, ckrina, steveparks: Create a drupal.org documentation page for Umami profile to explain why it shouldn't be used in production sites (6 days ago) <Lee Rowlands>
* e2553504da - Issue #2939019 by David_Rothstein: Umami theme has a confusing theme description (7 days ago) <Nathaniel Catchpole>
* 9c783555d0 - Issue #2941488 by larowlan, Eli-T: Add a .htaccess file to core/profiles/demo_umami/modules/demo_umami_content/default_content/images to prevent direct downloading of images (7 days ago) <Alex Pott>
* 41baf345af - Issue #2938186 by navneet0693, John Cook, Eli-T, markconroy, smaz, ckrina, andrewmacpherson, larowlan: Set toolbar warning message to only appear on admin/edit pages (8 days ago) <Lee Rowlands>
* b1e477ec25 - Issue #2938900 by David_Rothstein, navneet0693, JayKandari: Replace profile-defined blocks with custom blocks to fix a variety of problems (8 days ago) <Lee Rowlands>
* aa3dcb5b93 - Issue #2938686 by Adam_Moulsdale, andrewmacpherson: Pink button/link style in Umami fails WCAG 2.0 SC 1.4.3 Contrast (minimum) (8 days ago) <Nathaniel Catchpole>
* 66f7227799 - Issue #2939940 by bmx269, joelpittet: Update stylelint rules color-hex-case to be consistent with Drupal's CSS standards (12 days ago) <Alex Pott>
* 490ad56034 - Issue #2939018 by smaz, David_Rothstein: Umami theme and modules don't have version numbers in their info files (13 days ago) <Gabor Hojtsy>
* 19842c8b24 - Issue #2939835 by David_Rothstein, markconroy: Documentation for testAppearance() says that it tests that Umami is the default theme, but it doesn't (13 days ago) <Gabor Hojtsy>
* 056e61b89c - Issue #2938170 by navneet0693, andrewmacpherson, markconroy, owenpm3, larowlan: Enable ALT text for Banner Block image field (2 weeks ago) <Lee Rowlands>
* 6e06ffed0b - Issue #2938918 by David_Rothstein, markconroy, larowlan: Impossible to switch back to the Umami theme after switching away from it (2 weeks ago) <Nathaniel Catchpole>
* b7ec9fab52 - Issue #2938187 by markconroy, andrewmacpherson: Homepage/Recipes page banner image is duplicating on small screens (2 weeks ago) <Lee Rowlands>
* 42c9e7bbd0 - Issue #2937636 by piyuesh23, markconroy: Umami Theme - follow-up - Use hook_form_alter() for search block placeholder (3 weeks ago) <Nathaniel Catchpole>
* 222377929b - Issue #2938360 by markconroy: Change hook_preprocess_block to use $variables instead of $vars (3 weeks ago) <Nathaniel Catchpole>
* c212be4599 - Issue #2937894 by navneet0693: Remove unneeded schema entry from demo_umami.schema.yml (3 weeks ago) <Lee Rowlands>
* aead8ca408 - Issue #2809635 by markconroy, navneet0693, alexpott, smaz, larowlan, Eli-T, webchick, yoroy, ikit-claw, budda, kjay, timmillwood, tkoleary, Gábor Hojtsy, andrewmacpherson, lauriii, JayKandari, jibran, ok_lyndsey, big_man, ckrina, nathancz, Paul_Gregory, vijaycs85, SharJay, tomphippen, tim.plunkett, Tarun Lewis, cehfisher, kreynen, Petr Illek, mariohernandez, thamas, thatdamnqa, John Cook, philipnorton42, h2cm, kattekrab, martin_q, waako: Create experimental installation profile (3 weeks ago) <webchick>
catch’s picture

Just to confirm I proposed this as the lowest-risk way to get Umami into 8.5.x, and xjm seconded it. Let's us have the codebase in-line and defer exactly how we launch things to not this week.

smaz’s picture

Status: Needs review » Reviewed & tested by the community

Manually testing this:

Code base:
All code has been brought across, it appears no code/commits have been missed.

Installer:
Umami is not available to select. When removing the hidden setting that has been added, it does show up & the warning when the profile is selected works as expected.

Umami successfully installs via Drush.

Default content:
All content & blocks were imported ok

Toolbar warning:
Only visible on the correct pages, and links through to the correct documentation page.

Status report page:
Experimental profile warning present.

Home page:
All expected content present & ok.

Articles listing page:
All as expected.

Article page:
All as expected, including promoted content not including the current article.

Recipes listing page:
All as expected.

Recipe page:
All as expected.

Taxonomy term page:
All as expected,

Search page:
Expected search results returned when searching for 'Vegan' (1 recipe) and 'Carrots' (1 article).

User page:
View / edit tabs present (recent issue that was fixed)

Editing a recipe:
Able to update the content without issue.

Quickedit:
Able to quick edit a recipe without issue.

Anonymous users:
Anonymous users able to access all public sections of the site.

Breadcrumb::
Correct path, containing the current page title as the last item. Includes testing the path on search pages ends with 'Search for [search term]'.

Responsive theming
A quick check, everything appears ok including the responsive hamburger menu.

Menus:
All menu items present.

I'm fairly happy this is the same as it is in 8.6, so happy to RTBC!

smaz’s picture

If there's commit credits going for reviews, please also add:

jaykandari
eli-t

Both were also reviewing this manually.

alexpott’s picture

Crediting @smaz for the thorough review and the committers for the release management discussions.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed d575b05 and pushed to 8.5.x. Thanks!

  • alexpott committed d575b05 on 8.5.x
    Issue #2943004 by alexpott, webchick, smaz, xjm, catch: Backport Umami...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.