Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
#2158003: Remove Block Cache API in favor of blocks returning #cache with cache tags introduced this hunk to template_preprocess_block():
// A block's label is configuration: it is static. Allow dynamic labels to be
// set in the render array.
if (isset($variables['elements']['content']['#title']) && !empty($variables['configuration']['label_display'])) {
$variables['label'] = $variables['elements']['content']['#title'];
}
This is *after* the label is retrieved from the config:
$variables['label'] = !empty($variables['configuration']['label_display']) ? $variables['configuration']['label'] : '';
Proposed resolution
Decide what to do about this.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
figure-out-if-this-has-test-coverage.patch | 949 bytes | tim.plunkett | |
Comments
Comment #2
tim.plunkettImplicit test coverage through Views. Hmm.