Problem/Motivation

Drupal\Tests\simpletest\FunctionalJavascript\JavascriptGetDrupalSettingsTest and Drupal\Tests\simpletest\FunctionalJavascript\BrowserWithJavascriptTest exist in the simpletest module.

They test the behavior of the functional JavaScript framework, which does not exist in the simpletest module and does not need it.

Proposed resolution

Move these tests to core/tests/Drupal/FunctionalJavascriptTests/.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 2942314-3.patch1.67 KBLendude
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mile23 created an issue. See original summary.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Dx Experts commented
Status: Active » Needs review
FileSize
2942314-3.patch1.67 KB

Here we go.

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

LGTM

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed d1eee651be to 8.7.x and 23c5b7000e to 8.6.x. Thanks!

  • alexpott committed d1eee65 on 8.7.x 
    Issue #2942314 by Lendude: Move JavascriptGetDrupalSettingsTest,...

  • alexpott committed 23c5b70 on 8.6.x 
    Issue #2942314 by Lendude: Move JavascriptGetDrupalSettingsTest,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.