Arising from #2773645: Allow hook_entity_field_access() to grant field-level access to User fields: 'forbidden' -> 'neutral', @Wim Leers pointed out that we can now convert the code in checkFieldAccess to make use of allowedIf. This actually subtly changes what caching is done by in the forbidden case.
@Berdir has confirmed that the new behavior is correct, but none the less it is a change from now, and needs slightly subtle test fixes and perhaps a change notice. Hence this has been split to a separate issue.
The changes are described by the attached interdiff. It isn't possible to create a patch until #2773645: Allow hook_entity_field_access() to grant field-level access to User fields: 'forbidden' -> 'neutral' has been fixed.
Comment | File | Size | Author |
---|---|---|---|
#2 | user-tidy_access.2941966-2.patch | 1.57 KB | AdamPS |
user-access.2773645-interdiff-56-62.txt | 1.57 KB | AdamPS |
Comments
Comment #2
AdamPS CreditAttribution: AdamPS at AlbanyWeb commented#2773645 has been fixed so the interdiff should now apply correctly as a patch - let's check that with "needs review". Tests will be broken and need work.
Comment #4
borisson_This is no longer postponed.