FieldStorageConfigStorage incorrectly attempts to load by properties if the conditions array contains the keys 'entity_type' and 'field_name'. This is due to the way that specific IDs are attempted to be loaded, but do not contain a period between the entity type and the field name, merging the two together (e.g. nodebody instead of node.body).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thomas.pischke.newscycle’s picture

thomas.pischke.newscycle’s picture

Status: Active » Needs review

Status: Needs review » Needs work
amateescu’s picture

Issue tags: +Needs tests

Oh wow, very nice catch! We need to add a test for this, probably somewhere inside \Drupal\Tests\field\Kernel\FieldStorageCrudTest :)

thomas.pischke.newscycle’s picture

Ah, whoops, I created the patch from the wrong directory. Moved it out to the parent level.

thomas.pischke.newscycle’s picture

thomas.pischke.newscycle’s picture

Status: Needs work » Needs review
borisson_’s picture

Status: Needs review » Needs work

Setting to needs work, so we remember to write tests for this, based on #5.

Version: 8.4.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Branches prior to 8.8.x are not supported, and Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

init90’s picture