Site email address in the install profile form is no longer copied to the user email address [#2941106]

Problem/Motivation

Prior to #2925064: [1/2] JS codestyle: no-restricted-syntax the site email address was copied to the user email address:

The browser also displays a javascript error in drupal.js?v=8.5.0-dev:13:

 Uncaught TypeError: Array.prototype.push called on null or undefined
    at push (<anonymous>)
    at Array.forEach (<anonymous>)
    at Object.attach (system.js?v=8.5.0-dev:13)
    at drupal.js?v=8.5.0-dev:25
    at Array.forEach (<anonymous>)
    at Object.Drupal.attachBehaviors (drupal.js?v=8.5.0-dev:22)
    at drupal.init.js:16
    at HTMLDocument.t (ready.min.js?v=1.0.8:4)

Proposed resolution

Restore the behavior where the entered site mail address is copied to the user email adress
Fix the javascript error

Remaining tasks

Write a patch
Review
Commit

User interface changes

The site email address in the install profile form is copied to the user email address

API changes

None.

Data model changes

None.

Comment	File	Size	Author
#5	system.patch	1.32 KB	droplet
#5	8.6.x: PHP 7 & MySQL 5.5 23,504 pass
#2	site-mail-copied-to-user-mail.gif	57.83 KB	idebr

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

31 January 2018 at 18:50

idebr created an issue. See original summary.

Comment #2

idebr CreditAttribution: idebr at ezCompany commented 31 January 2018 at 18:54

Issue summary:

View changes

File	Size
site-mail-copied-to-user-mail.gif	57.83 KB

Comment #3

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented 8 February 2018 at 10:22

Assigned:

Unassigned

» msankhala

Assigning me and trying to reproduce this issue in 8.6.x-dev.

Comment #4

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented 8 February 2018 at 11:23

I can reproduce this issue on 8.6.x branch as well. Browser throw this error in console mentioned by @idebr on Configure site installation step. I think this issue is to do with https://github.com/ded/domready library used by drupal.

Comment #5

droplet CreditAttribution: droplet commented 8 February 2018 at 12:48

Assigned:	msankhala	» Unassigned
Status:	Active	» Needs review
Issue tags:		+syntax error

File	Size
system.patch	1.32 KB
8.6.x: PHP 7 & MySQL 5.5 23,504 pass

Comment #6

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented 10 February 2018 at 13:06

I can confirm patch #5 fixes this issue on 8.6.x branch. +1 @droplet for patch.

Comment #7

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented 12 February 2018 at 09:59

Status:

Needs review

» Reviewed & tested by the community

I am not sure if Javascript Test is required for this or not. Moving it to RTBC feel free to open again if TestCase is required or there is any other bug related to this.

Comment #8

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Acro Commerce commented 12 February 2018 at 10:48

Status:	Reviewed & tested by the community	» Fixed
Issue tags:	-Needs tests

Given this is a regression introduced by a code style improvement I think we should commit the fix but open a followup for testing. Especially as this affects the 8.5.0 beta.

Committed 3840ad2 and pushed to 8.6.x. Thanks!

@msankhala thanks for reviewing the issue and testing it. Whilst your reviews didn't materially affect the patch you provided evidence of testing and how you did it. So I'm crediting you on d.o but not on the patch.

Comment #9

12 February 2018 at 10:48

alexpott committed 3840ad2 on 8.6.x

Issue #2941106 by droplet, idebr: Site email address in the install...

Comment #10

12 February 2018 at 10:48

alexpott committed 1cf6343 on 8.5.x

Issue #2941106 by droplet, idebr: Site email address in the install...

Comment #11

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Acro Commerce commented 12 February 2018 at 10:49

Backported to 8.5.x since this is a regression introduced in the development of that patch that could impact live site's UIs.

Committed 1cf6343 and pushed to 8.5.x. Thanks!

Comment #12

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Acro Commerce commented 12 February 2018 at 10:53

Added test followup #2944089: Test Drupal.behaviors.copyFieldValue javascript

Comment #13

dawehner

German

CreditAttribution: dawehner at Chapter Three commented 12 February 2018 at 16:28

In case someone is curious why this doesn't work:

arr.forEach(function callback(currentValue[, index[, array]]) {
    //your iterator
}[, thisArg]);

```arr.push(element1[, ...[, elementN]])```

So, each bit of the forEach would push the value, index and array all the time. In order words, let's never be clever about these functions for build in functions.