Followup to #2875394: Replace all calls to db_query, which is deprecated

core/tests/Drupal/KernelTests/Core/Database/ replacemets in another issue - #2939387: Replace all calls to db_query [core/test/../Database]

grep -inr --exclude-dir=Database -e "db_query" core/tests/

CommentFileSizeAuthor
#7 interdiff-2939389-05-07.txt455 bytesvoleger
#7 replace_all_db_query_calls-2939389-07-8.6.x.patch10.51 KBvoleger
#5 interdiff-2939389-03-05.txt8.47 KBvoleger
#5 replace_all_db_query_calls-2939389-05-8.6.x.patch10.51 KBvoleger
#3 interdiff-2939389-02-03.txt6.6 KBvoleger
#3 replace_all_db_query_calls-2939389-03-8.6.x.patch8.28 KBvoleger
#2 replace_all_db_query_calls-2939389-02-8.6.x.patch8.03 KBvoleger
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

voleger created an issue. See original summary.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at Lemberg Solutions, Drupal Ukraine Community for Drupal Ukraine Community, Lemberg Solutions commented
Assigned: voleger » Unassigned
Issue summary: View changes
Status: Active » Needs review
FileSize
replace_all_db_query_calls-2939389-02-8.6.x.patch8.03 KB
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at Lemberg Solutions, Drupal Ukraine Community for Drupal Ukraine Community, Lemberg Solutions commented
FileSize
replace_all_db_query_calls-2939389-03-8.6.x.patch8.28 KB
interdiff-2939389-02-03.txt6.6 KB

Reformat changes

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at Lemberg Solutions, Drupal Ukraine Community for Drupal Ukraine Community, Lemberg Solutions commented
Issue summary: View changes

grep -inr --exclude-dir=Database -e "db_query" core/tests/

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at Lemberg Solutions, Drupal Ukraine Community for Drupal Ukraine Community, Lemberg Solutions commented
FileSize
replace_all_db_query_calls-2939389-05-8.6.x.patch10.51 KB
interdiff-2939389-03-05.txt8.47 KB

Status: Needs review » Needs work

The last submitted patch, 5: replace_all_db_query_calls-2939389-05-8.6.x.patch, failed testing. View results

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at Lemberg Solutions, Drupal Ukraine Community for Drupal Ukraine Community, Lemberg Solutions commented
Status: Needs work » Needs review
FileSize
replace_all_db_query_calls-2939389-07-8.6.x.patch10.51 KB
interdiff-2939389-05-07.txt455 bytes

Oops.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented

Tests are green. Ready for review.

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
CreditAttribution: joshmiller at Acro Commerce commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

core/tests/Drupal/KernelTests/Core/Database/UpdateTest.php still has a usage.

This patch should be scripted. And done in one issue. See #2849669: Fix \Drupal\Component\Utility\Unicode() because of the Symfony mbstring polyfill and #2958429: Properly deprecate SafeMarkup::format(). The patch should also add an @trigger_error to db_query().

Putting at needs works so that everything can be migrated to #2875394: Replace all calls to db_query, which is deprecated. For more info on why this is the right approach see https://www.drupal.org/core/scope#examples specifically the example of entity_load()

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

@voleger forgot to say thanks for all the work here! Cleaning up the tech debt is something I'm really keen on too and it'll be amazing to get to a point where we're doing a lot less legacy stuff.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Status: Needs work » Closed (duplicate)

So we will work on the scripted patch.
Follow #2875394: Replace all calls to db_query, which is deprecated